All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix mono
Date: Sun, 27 Jan 2013 10:58:47 +0800	[thread overview]
Message-ID: <20130127025844.GC4650@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1343658253.242147.1359209821129.JavaMail.root@advansee.com>


[-- Attachment #1.1: Type: text/plain, Size: 761 bytes --]

On Sat, Jan 26, 2013 at 03:17:01PM +0100, Benoît Thébaudeau wrote:
> On Saturday, January 26, 2013 9:55:14 AM, Mark Brown wrote:

> > So, this doesn't actually fix mono - it removes support for it.

> Yes, for this driver, but this fixes mono for the whole system, meaning that
> e.g. it fixes mono playback support with players like MPlayer. I will reword if
> you prefer.

Yes, please.

> I've only tested with I²S (imx-ssi). But for all the available DAI modes, the
> data sheet gives the encoding for both stereo channels (from p. 21), and nowhere
> it says that mono is an option for DAI:

I2S isn't really relevant here, it's not possible to clock I2S as a mono
interface.

> I will retest with DSP modes if you prefer.

Yes, please.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2013-01-27  2:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26  8:55 ` Mark Brown
2013-01-26 14:17   ` Benoît Thébaudeau
2013-01-27  2:58     ` Mark Brown [this message]
2013-01-28 21:03       ` Benoît Thébaudeau
2013-01-29  2:01         ` Mark Brown
2013-01-29 20:40           ` Benoît Thébaudeau
2013-01-30  2:11             ` Mark Brown
2013-01-30 11:17               ` Benoît Thébaudeau
2013-01-29 20:31 ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Benoît Thébaudeau
2013-01-30  2:15   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130127025844.GC4650@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=benoit.thebaudeau@advansee.com \
    --cc=fabio.estevam@freescale.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.