From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Fix mono
Date: Tue, 29 Jan 2013 21:40:18 +0100 (CET) [thread overview]
Message-ID: <832331151.478537.1359492018900.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20130129020128.GE4748@opensource.wolfsonmicro.com>
On Tuesday, January 29, 2013 3:01:32 AM, Mark Brown wrote:
> On Mon, Jan 28, 2013 at 10:03:40PM +0100, Benoît Thébaudeau wrote:
>
> > 1) snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffc, 0xffffffc, 2, 0);
> > -> all DAI formats: wrong sample rate for L/R, playing twice too fast
>
> > 2) snd_soc_dai_set_tdm_slot(cpu_dai, 0xffffffe, 0xffffffe, 1, 0);
> > -> all DAI formats: nothing on R, wrong sample rate for L, playing twice
> > too
> > fast, plus loud noise superimposed for LEFT_J
>
> Why are you having to call this in the first place?
For I²S, because the reference manual of the i.MX25 says that SSI.STCCR.DC
should be set to 1 (i.e. 2 channels) in this mode. This also allowed to test
several settings for mono.
For DSP modes, because stereo doesn't work without this call (right channel
missing).
> Anyway, I guess we do have a hardware limiation here so I'll apply the
> patch when you resend it.
OK. I have just resent it.
Best regards,
Benoît
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-01-29 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 17:19 [PATCH] ASoC: tlv320aic3x: Fix mono Benoît Thébaudeau
2013-01-26 8:55 ` Mark Brown
2013-01-26 14:17 ` Benoît Thébaudeau
2013-01-27 2:58 ` Mark Brown
2013-01-28 21:03 ` Benoît Thébaudeau
2013-01-29 2:01 ` Mark Brown
2013-01-29 20:40 ` Benoît Thébaudeau [this message]
2013-01-30 2:11 ` Mark Brown
2013-01-30 11:17 ` Benoît Thébaudeau
2013-01-29 20:31 ` [PATCH v2] ASoC: tlv320aic3x: Remove mono support Benoît Thébaudeau
2013-01-30 2:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=832331151.478537.1359492018900.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.