Re: [PATCHv2 6/9] zsmalloc: promote to lib/

[Minchan Kim <minchan@kernel.org>]

On Mon, Jan 28, 2013 at 01:01:16PM +0900, Minchan Kim wrote:
> On Mon, Jan 07, 2013 at 02:24:37PM -0600, Seth Jennings wrote:
> > This patch promotes the slab-based zsmalloc memory allocator
> > from the staging tree to lib/
> > 
> > zswap depends on this allocator for storing compressed RAM pages
> > in an efficient way under system wide memory pressure where
> > high-order (greater than 0) page allocation are very likely to
> > fail.
> > 
> > For more information on zsmalloc and its internals, read the
> > documentation at the top of the zsmalloc.c file.
> > 
> > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> 
> Seth, zsmalloc has a bug[1], I sent a patch totay. If it want't known,
> it mighte be no problem to promote but it's known bug so let's fix it
> before promoting.
> 
> Another question. Why do you promote zsmalloc in this patchset?
> It might make you hard to merge even zswap into staging.

When I look at [8/9], I realized you are trying to merge this patch
into mm/, NOT staging. I don't know history why zsmalloc/zram/zscache was
in staging at the beginning but personally, I don't ojbect zswap into /mm
directly because I got realized staging is very deep hole to get out,
expecially related to mm stuff. ;-)

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>