* [patch] padata: test correct variable in ->store function
@ 2013-01-26 7:49 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-01-26 7:49 UTC (permalink / raw)
To: Steffen Klassert, Dan Kruchinin; +Cc: linux-crypto, kernel-janitors
It's testing for ->show but calling ->store().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. I don't know if it affects real life.
diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..7ac61c1 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -1013,7 +1013,7 @@ static ssize_t padata_sysfs_store(struct kobject *kobj, struct attribute *attr,
pinst = kobj2pinst(kobj);
pentry = attr2pentry(attr);
- if (pentry->show)
+ if (pentry->store)
ret = pentry->store(pinst, attr, buf, count);
return ret;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] padata: test correct variable in ->store function
@ 2013-01-26 7:49 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2013-01-26 7:49 UTC (permalink / raw)
To: Steffen Klassert, Dan Kruchinin; +Cc: linux-crypto, kernel-janitors
It's testing for ->show but calling ->store().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. I don't know if it affects real life.
diff --git a/kernel/padata.c b/kernel/padata.c
index 072f4ee..7ac61c1 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -1013,7 +1013,7 @@ static ssize_t padata_sysfs_store(struct kobject *kobj, struct attribute *attr,
pinst = kobj2pinst(kobj);
pentry = attr2pentry(attr);
- if (pentry->show)
+ if (pentry->store)
ret = pentry->store(pinst, attr, buf, count);
return ret;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] padata: test correct variable in ->store function
2013-01-26 7:49 ` Dan Carpenter
@ 2013-01-28 9:48 ` Steffen Klassert
-1 siblings, 0 replies; 4+ messages in thread
From: Steffen Klassert @ 2013-01-28 9:48 UTC (permalink / raw)
To: Dan Carpenter, Herbert Xu; +Cc: Dan Kruchinin, linux-crypto, kernel-janitors
On Sat, Jan 26, 2013 at 10:49:46AM +0300, Dan Carpenter wrote:
> It's testing for ->show but calling ->store().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks like a copy and paste error.
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Herbert, are you going to take this one?
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] padata: test correct variable in ->store function
@ 2013-01-28 9:48 ` Steffen Klassert
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Klassert @ 2013-01-28 9:48 UTC (permalink / raw)
To: Dan Carpenter, Herbert Xu; +Cc: Dan Kruchinin, linux-crypto, kernel-janitors
On Sat, Jan 26, 2013 at 10:49:46AM +0300, Dan Carpenter wrote:
> It's testing for ->show but calling ->store().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks like a copy and paste error.
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Herbert, are you going to take this one?
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-28 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-26 7:49 [patch] padata: test correct variable in ->store function Dan Carpenter
2013-01-26 7:49 ` Dan Carpenter
2013-01-28 9:48 ` Steffen Klassert
2013-01-28 9:48 ` Steffen Klassert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.