All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sebastian Andrzej Siewior
	<sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [git pull] ioapic-cleanups-for-v3.9
Date: Mon, 28 Jan 2013 16:58:02 +0100	[thread overview]
Message-ID: <20130128155757.GA3643@8bytes.org> (raw)
In-Reply-To: <20130125104915.GB23332-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 3884 bytes --]

Hi Ingo,

On Fri, Jan 25, 2013 at 11:49:15AM +0100, Ingo Molnar wrote:
> Hm, there are some not so trivial looking conflicts in 
> io_apic.c, due to the MSI patches I applied yesterday:
> 
>  5ca72c4f7c41 AHCI: Support multiple MSIs
>  08261d87f7d1 PCI/MSI: Enable multiple MSIs with pci_enable_msi_block_auto()
>  51906e779f2b x86/MSI: Support multiple MSIs in presense of IRQ remapping
> 
> Could you please resolve them and resend?

Okay, I resolved the conflicts and tested the result again. Here it is:

The following changes since commit 5ca72c4f7c412c2002363218901eba5516c476b1:

  AHCI: Support multiple MSIs (2013-01-24 17:25:13 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/ioapic-cleanups-for-tip

for you to fetch changes up to a1bb20c232d066de0762f8e7cf332e5ce8385210:

  x86, irq: Move irq_remapped out of x86 core code (2013-01-28 12:51:52 +0100)

----------------------------------------------------------------
Cleanup X86 IOAPIC code from interrupt remapping details

These patches move all interrupt remapping specific checks out of the
x86 core code and replaces the respective call-sites with function
pointers. As a result the interrupt remapping code is better abstraced
from x86 core interrupt handling code.

The code was rebased to v3.8-rc4 and tested on systems with AMD-Vi and
Intel VT-d (both capable of interrupt remapping). The systems were
tested with IOMMU enabled and with IOMMU disabled. No issues were found.

----------------------------------------------------------------
Joerg Roedel (19):
      x86, apic: Move irq_remapping_enabled checks into IRQ-remapping code
      x86, apic: Mask IO-APIC and PIC unconditionally on LAPIC resume
      x86, io_apic: Introduce x86_io_apic_ops.disable()
      x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging
      x86, hpet: Introduce x86_msi_ops.setup_hpet_msi
      x86, msi: Use IRQ remapping specific setup_msi_irqs routine
      x86, io_apic: Introduce set_affinity function pointer
      x86, io_apic: Convert setup_ioapic_entry to function pointer
      x86, io_apic: Move irq_remapping_enabled checks out of check_timer()
      x86, io_apic: Remove irq_remapping_enabled check in setup_timer_IRQ0_pin
      x86, irq: Move irq_remapping_enabled declaration to iommu code
      x86, irq: Add data structure to keep AMD specific irq remapping information
      x86, io-apic: Move CONFIG_IRQ_REMAP code out of x86 core
      x86, io-apic: Remove !irq_remapped() check from __target_IO_APIC_irq()
      x86, irq: Move irq_remapped() check into free_remapped_irq
      x86, irq: Introduce setup_remapped_irq()
      x86, msi: Introduce x86_msi.compose_msi_msg call-back
      x86, io_apic: Introduce eoi_ioapic_pin call-back
      x86, irq: Move irq_remapped out of x86 core code

 arch/x86/include/asm/hpet.h          |    5 +-
 arch/x86/include/asm/hw_irq.h        |   13 +-
 arch/x86/include/asm/io_apic.h       |   28 +++
 arch/x86/include/asm/irq_remapping.h |   40 ++-
 arch/x86/include/asm/pci.h           |    3 +
 arch/x86/include/asm/x86_init.h      |   27 +-
 arch/x86/kernel/apic/apic.c          |   28 +--
 arch/x86/kernel/apic/io_apic.c       |  446 +++++++++++-----------------------
 arch/x86/kernel/hpet.c               |    2 +-
 arch/x86/kernel/x86_init.c           |   24 +-
 drivers/iommu/amd_iommu.c            |    8 +-
 drivers/iommu/dmar.c                 |    2 +
 drivers/iommu/intel-iommu.c          |    2 +
 drivers/iommu/intel_irq_remapping.c  |   12 +
 drivers/iommu/irq_remapping.c        |  231 +++++++++++++++++-
 drivers/iommu/irq_remapping.h        |    1 +
 include/linux/irq.h                  |    3 +
 17 files changed, 504 insertions(+), 371 deletions(-)

Please pull.

Thanks,

	Joerg


[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] ioapic-cleanups-for-v3.9
Date: Mon, 28 Jan 2013 16:58:02 +0100	[thread overview]
Message-ID: <20130128155757.GA3643@8bytes.org> (raw)
In-Reply-To: <20130125104915.GB23332@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3884 bytes --]

Hi Ingo,

On Fri, Jan 25, 2013 at 11:49:15AM +0100, Ingo Molnar wrote:
> Hm, there are some not so trivial looking conflicts in 
> io_apic.c, due to the MSI patches I applied yesterday:
> 
>  5ca72c4f7c41 AHCI: Support multiple MSIs
>  08261d87f7d1 PCI/MSI: Enable multiple MSIs with pci_enable_msi_block_auto()
>  51906e779f2b x86/MSI: Support multiple MSIs in presense of IRQ remapping
> 
> Could you please resolve them and resend?

Okay, I resolved the conflicts and tested the result again. Here it is:

The following changes since commit 5ca72c4f7c412c2002363218901eba5516c476b1:

  AHCI: Support multiple MSIs (2013-01-24 17:25:13 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/ioapic-cleanups-for-tip

for you to fetch changes up to a1bb20c232d066de0762f8e7cf332e5ce8385210:

  x86, irq: Move irq_remapped out of x86 core code (2013-01-28 12:51:52 +0100)

----------------------------------------------------------------
Cleanup X86 IOAPIC code from interrupt remapping details

These patches move all interrupt remapping specific checks out of the
x86 core code and replaces the respective call-sites with function
pointers. As a result the interrupt remapping code is better abstraced
from x86 core interrupt handling code.

The code was rebased to v3.8-rc4 and tested on systems with AMD-Vi and
Intel VT-d (both capable of interrupt remapping). The systems were
tested with IOMMU enabled and with IOMMU disabled. No issues were found.

----------------------------------------------------------------
Joerg Roedel (19):
      x86, apic: Move irq_remapping_enabled checks into IRQ-remapping code
      x86, apic: Mask IO-APIC and PIC unconditionally on LAPIC resume
      x86, io_apic: Introduce x86_io_apic_ops.disable()
      x86, io_apic: Introduce x86_io_apic_ops.print_entries for debugging
      x86, hpet: Introduce x86_msi_ops.setup_hpet_msi
      x86, msi: Use IRQ remapping specific setup_msi_irqs routine
      x86, io_apic: Introduce set_affinity function pointer
      x86, io_apic: Convert setup_ioapic_entry to function pointer
      x86, io_apic: Move irq_remapping_enabled checks out of check_timer()
      x86, io_apic: Remove irq_remapping_enabled check in setup_timer_IRQ0_pin
      x86, irq: Move irq_remapping_enabled declaration to iommu code
      x86, irq: Add data structure to keep AMD specific irq remapping information
      x86, io-apic: Move CONFIG_IRQ_REMAP code out of x86 core
      x86, io-apic: Remove !irq_remapped() check from __target_IO_APIC_irq()
      x86, irq: Move irq_remapped() check into free_remapped_irq
      x86, irq: Introduce setup_remapped_irq()
      x86, msi: Introduce x86_msi.compose_msi_msg call-back
      x86, io_apic: Introduce eoi_ioapic_pin call-back
      x86, irq: Move irq_remapped out of x86 core code

 arch/x86/include/asm/hpet.h          |    5 +-
 arch/x86/include/asm/hw_irq.h        |   13 +-
 arch/x86/include/asm/io_apic.h       |   28 +++
 arch/x86/include/asm/irq_remapping.h |   40 ++-
 arch/x86/include/asm/pci.h           |    3 +
 arch/x86/include/asm/x86_init.h      |   27 +-
 arch/x86/kernel/apic/apic.c          |   28 +--
 arch/x86/kernel/apic/io_apic.c       |  446 +++++++++++-----------------------
 arch/x86/kernel/hpet.c               |    2 +-
 arch/x86/kernel/x86_init.c           |   24 +-
 drivers/iommu/amd_iommu.c            |    8 +-
 drivers/iommu/dmar.c                 |    2 +
 drivers/iommu/intel-iommu.c          |    2 +
 drivers/iommu/intel_irq_remapping.c  |   12 +
 drivers/iommu/irq_remapping.c        |  231 +++++++++++++++++-
 drivers/iommu/irq_remapping.h        |    1 +
 include/linux/irq.h                  |    3 +
 17 files changed, 504 insertions(+), 371 deletions(-)

Please pull.

Thanks,

	Joerg


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-01-28 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-25 10:00 [git pull] ioapic-cleanups-for-v3.9 Joerg Roedel
2013-01-25 10:00 ` Joerg Roedel
     [not found] ` <20130125100040.GA13908-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-01-25 10:49   ` Ingo Molnar
2013-01-25 10:49     ` Ingo Molnar
     [not found]     ` <20130125104915.GB23332-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-25 11:31       ` Joerg Roedel
2013-01-25 11:31         ` Joerg Roedel
2013-01-28 15:58       ` Joerg Roedel [this message]
2013-01-28 15:58         ` Joerg Roedel
     [not found]         ` <20130128155757.GA3643-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-01-29  9:07           ` Ingo Molnar
2013-01-29  9:07             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130128155757.GA3643@8bytes.org \
    --to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.