From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/4] drm/i915: move modeset checks out of save/restore_modeset_reg
Date: Mon, 28 Jan 2013 22:54:54 +0100 [thread overview]
Message-ID: <20130128215454.GD14766@phenom.ffwll.local> (raw)
In-Reply-To: <1359370466.3592.7.camel@ideak-mobl>
On Mon, Jan 28, 2013 at 12:54:26PM +0200, Imre Deak wrote:
> On Fri, 2013-01-25 at 17:53 +0100, Daniel Vetter wrote:
> > That way the control flow is clearer, and it prepares the stage
> > to extract these ums functions and hide them somewhere.
> >
> > There's still tons of display stuff outside of these, but that
> > requires more work.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> s/modeset/display/ as discussed on IRC. Also would be nice to use
> format-patch -C for things like patch 2/4 in the future, as that'd make
> reviewing easier imo. Otherwise on the series:
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Ok, slurped in the entire series, with your suggestion applied to patch 2
(less conflicts that way to resolve). Thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-01-28 21:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 16:53 [PATCH 0/4] disable more register safe/restore code for kms Daniel Vetter
2013-01-25 16:53 ` [PATCH 1/4] drm/i915: move modeset checks out of save/restore_modeset_reg Daniel Vetter
2013-01-28 10:54 ` Imre Deak
2013-01-28 21:54 ` Daniel Vetter [this message]
2013-01-25 16:53 ` [PATCH 2/4] drm/i915: extract ums suspend/resume into i915_ums.c Daniel Vetter
2013-01-25 16:53 ` [PATCH 3/4] drm/i915: dont save/restore VGA state for kms Daniel Vetter
2013-01-25 19:09 ` Ville Syrjälä
2013-01-25 19:25 ` Daniel Vetter
2013-01-25 16:53 ` [PATCH 4/4] drm/i915: move DP save/restore into i915_ums.c Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130128215454.GD14766@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.