All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()
Date: Mon, 28 Jan 2013 16:42:02 -0600	[thread overview]
Message-ID: <20130128224202.GE27055@sgi.com> (raw)
In-Reply-To: <20130120102449.397b3f8b@googlemail.com>

On Sun, Jan 20, 2013 at 10:24:49AM +0100, Torsten Kaiser wrote:
> From: Torsten Kaiser <just.for.lkml@googlemail.com>
> 
> Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed
> xfs_flushinval_pages() and changed its callers to use
> filemap_write_and_wait() and  truncate_pagecache_range() directly.
> 
> But in xfs_swap_extents() this change accidental switched the argument
> for 'tip' to 'ip'. This patch switches it back to 'tip'
> 
> Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com>

Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>

Thanks Torsten!

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Ben Myers <bpm@sgi.com>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Dave Chinner <david@fromorbit.com>,
	xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()
Date: Mon, 28 Jan 2013 16:42:02 -0600	[thread overview]
Message-ID: <20130128224202.GE27055@sgi.com> (raw)
In-Reply-To: <20130120102449.397b3f8b@googlemail.com>

On Sun, Jan 20, 2013 at 10:24:49AM +0100, Torsten Kaiser wrote:
> From: Torsten Kaiser <just.for.lkml@googlemail.com>
> 
> Commit fb59581404ab7ec5075299065c22cb211a9262a9 removed
> xfs_flushinval_pages() and changed its callers to use
> filemap_write_and_wait() and  truncate_pagecache_range() directly.
> 
> But in xfs_swap_extents() this change accidental switched the argument
> for 'tip' to 'ip'. This patch switches it back to 'tip'
> 
> Signed-off-by: Torsten Kaiser <just.for.lkml@googlemail.com>

Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>

Thanks Torsten!

  reply	other threads:[~2013-01-28 22:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-20  9:24 [PATCH]xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages() Torsten Kaiser
2013-01-28 22:42 ` Ben Myers [this message]
2013-01-28 22:42   ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130128224202.GE27055@sgi.com \
    --to=bpm@sgi.com \
    --cc=just.for.lkml@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.