From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Hebbar Gururaja <gururaja.hebbar@ti.com>
Cc: alsa-devel@alsa-project.org, sudhakar.raj@ti.com,
tony@atomide.com, nsekhar@ti.com,
davinci-linux-open-source@linux.davincidsp.com,
lgirdwood@gmail.com, alsa-user@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: tlv320aic3x: Convert mic bias to a supply widget
Date: Thu, 31 Jan 2013 10:32:25 +0800 [thread overview]
Message-ID: <20130131023221.GA6027@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1359552155-17426-1-git-send-email-gururaja.hebbar@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
On Wed, Jan 30, 2013 at 06:52:35PM +0530, Hebbar Gururaja wrote:
> Convert MicBias widgets to supply widget.
> On tlv320aic3x, Mic bias power on/off shares the same register bits
> with output mic bias voltage. So, when power on mic bias, we need
> reclaim it to voltage value.
This should update machine drivers that use the CODEC too.
> +- ai3x-micbias-vg - MicBias Voltage required.
> + 1 - MICBIAS output is powered to 2.0V,
> + 2 - MICBIAS output is powered to 2.5V,
> + 3 - MICBIAS output is connected to AVDD,
> + If this node is not mentioned or if the value is incorrect, then MicBias
> + is powered down.
Would 2.0V not be a more sensible default (it is the lowest voltage so
is unlikely to cause hardware damage if it's wrong)?
Otherwise this looks good.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: tlv320aic3x: Convert mic bias to a supply widget
Date: Thu, 31 Jan 2013 10:32:25 +0800 [thread overview]
Message-ID: <20130131023221.GA6027@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1359552155-17426-1-git-send-email-gururaja.hebbar@ti.com>
On Wed, Jan 30, 2013 at 06:52:35PM +0530, Hebbar Gururaja wrote:
> Convert MicBias widgets to supply widget.
> On tlv320aic3x, Mic bias power on/off shares the same register bits
> with output mic bias voltage. So, when power on mic bias, we need
> reclaim it to voltage value.
This should update machine drivers that use the CODEC too.
> +- ai3x-micbias-vg - MicBias Voltage required.
> + 1 - MICBIAS output is powered to 2.0V,
> + 2 - MICBIAS output is powered to 2.5V,
> + 3 - MICBIAS output is connected to AVDD,
> + If this node is not mentioned or if the value is incorrect, then MicBias
> + is powered down.
Would 2.0V not be a more sensible default (it is the lowest voltage so
is unlikely to cause hardware damage if it's wrong)?
Otherwise this looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130131/c8628dbd/attachment.sig>
next prev parent reply other threads:[~2013-01-31 2:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 13:22 [PATCH 1/2] ASoC: tlv320aic3x: Convert mic bias to a supply widget Hebbar Gururaja
2013-01-30 13:22 ` Hebbar Gururaja
2013-01-31 2:32 ` Mark Brown [this message]
2013-01-31 2:32 ` Mark Brown
2013-01-31 5:27 ` Hebbar, Gururaja
2013-01-31 5:27 ` Hebbar, Gururaja
2013-01-31 8:02 ` Peter Ujfalusi
2013-01-31 8:02 ` [alsa-devel] " Peter Ujfalusi
2013-01-31 8:23 ` Hebbar, Gururaja
2013-01-31 8:23 ` [alsa-devel] " Hebbar, Gururaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131023221.GA6027@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-user@lists.sourceforge.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=gururaja.hebbar@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nsekhar@ti.com \
--cc=sudhakar.raj@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.