diff for duplicates of <20130131081645.GA14812@elgon.mountain> diff --git a/a/1.txt b/N1/1.txt index bd18fd1..e230fbe 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,8 +1,8 @@ If gb_len is less than 3 it would cause an integer underflow and possibly memory corruption in nfc_llcp_parse_gb_tlv(). -I removed the old test for gb_len = 0. I also removed the test for -->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and +I removed the old test for gb_len == 0. I also removed the test for +->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and we have already dereferenced ->remote_gb_len so it's too late to test. The old test return -ENODEV but my test returns -EINVAL. @@ -24,7 +24,7 @@ index 85bc75c..746f5a2 100644 memcpy(local->remote_gb, gb, gb_len); local->remote_gb_len = gb_len; -- if (local->remote_gb = NULL || local->remote_gb_len = 0) +- if (local->remote_gb == NULL || local->remote_gb_len == 0) - return -ENODEV; - if (memcmp(local->remote_gb, llcp_magic, 3)) { diff --git a/a/content_digest b/N1/content_digest index 9cf3fda..212072d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[patch] NFC: llcp: integer underflow in nfc_llcp_set_remote_gb()\0" - "Date\0Thu, 31 Jan 2013 08:16:46 +0000\0" + "Date\0Thu, 31 Jan 2013 11:16:46 +0300\0" "To\0Lauro Ramos Venancio <lauro.venancio@openbossa.org>\0" "Cc\0Aloisio Almeida Jr <aloisio.almeida@openbossa.org>" Samuel Ortiz <sameo@linux.intel.com> @@ -17,8 +17,8 @@ "If gb_len is less than 3 it would cause an integer underflow and\n" "possibly memory corruption in nfc_llcp_parse_gb_tlv().\n" "\n" - "I removed the old test for gb_len = 0. I also removed the test for\n" - "->remote_gb = NULL. It's not possible for ->remote_gb to be NULL and\n" + "I removed the old test for gb_len == 0. I also removed the test for\n" + "->remote_gb == NULL. It's not possible for ->remote_gb to be NULL and\n" "we have already dereferenced ->remote_gb_len so it's too late to test.\n" "\n" "The old test return -ENODEV but my test returns -EINVAL.\n" @@ -40,11 +40,11 @@ " \tmemcpy(local->remote_gb, gb, gb_len);\n" " \tlocal->remote_gb_len = gb_len;\n" " \n" - "-\tif (local->remote_gb = NULL || local->remote_gb_len = 0)\n" + "-\tif (local->remote_gb == NULL || local->remote_gb_len == 0)\n" "-\t\treturn -ENODEV;\n" "-\n" " \tif (memcmp(local->remote_gb, llcp_magic, 3)) {\n" " \t\tpr_err(\"MAC does not support LLCP\\n\");\n" " \t\treturn -EINVAL;" -58e39ffec665ddceab1fedc5302b37178880eeacdeec61655f6236fa187f6729 +f50f5d130b1a0ea60f9542a94ebaaf78f67b35035e8a3cda0f3dd2ff1aed7b82
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.