All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Russell King <rmk@arm.linux.org.uk>,
	Dave Airlie <airlied@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: BUG: circular locking dependency detected
Date: Thu, 31 Jan 2013 09:21:46 +0000	[thread overview]
Message-ID: <20130131092146.GB3361@kroah.com> (raw)
In-Reply-To: <CAKMK7uGUrvh2dXza_b288kVdztiLjSCNpH304oBQgg_ZonEnzw@mail.gmail.com>

On Thu, Jan 31, 2013 at 09:21:16AM +0100, Daniel Vetter wrote:
> On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote:
> >> On Thu, Jan 31, 2013 at 11:13 AM, Russell King <rmk@arm.linux.org.uk> wrote:
> >> >
> >> > Which may or may not be a good thing depending how you look at it; it
> >> > means that once your kernel blanks, you get a lockdep dump.  At that
> >> > point you lose lockdep checking for everything else because lockdep
> >> > disables itself after the first dump.
> >>
> >> Fair enough, we may want to revert the lockdep checking for
> >> console_lock, and make re-enabling it part of the patch-series that
> >> fixes the locking.
> >>
> >> Daniel/Dave? Does that sound reasonable?
> 
> Yeah, sounds good.
> 
> > Reverting the patch is fine with me.  Just let me know so I can queue it
> > up again for 3.9.
> 
> Can you please also pick up the (currently) three locking fixups
> around fbcon? Just so that we don't repeat the same fun where people
> complain about lockdep splats, but the fixes are stuck somewhere. And
> I guess Dave would be happy to not end up as fbcon maintainer ;-) He
> has a git branch with them at
> http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes
> though I have a small bikeshed on his last patch pending.

Care to just send me the patches through email when you all get done
bikesheding?  And for some reason I thought Andrew was going to handle
these fbcon patches, but if not, I'll be glad to take them.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Russell King <rmk@arm.linux.org.uk>,
	Dave Airlie <airlied@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: BUG: circular locking dependency detected
Date: Thu, 31 Jan 2013 10:21:46 +0100	[thread overview]
Message-ID: <20130131092146.GB3361@kroah.com> (raw)
In-Reply-To: <CAKMK7uGUrvh2dXza_b288kVdztiLjSCNpH304oBQgg_ZonEnzw@mail.gmail.com>

On Thu, Jan 31, 2013 at 09:21:16AM +0100, Daniel Vetter wrote:
> On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote:
> >> On Thu, Jan 31, 2013 at 11:13 AM, Russell King <rmk@arm.linux.org.uk> wrote:
> >> >
> >> > Which may or may not be a good thing depending how you look at it; it
> >> > means that once your kernel blanks, you get a lockdep dump.  At that
> >> > point you lose lockdep checking for everything else because lockdep
> >> > disables itself after the first dump.
> >>
> >> Fair enough, we may want to revert the lockdep checking for
> >> console_lock, and make re-enabling it part of the patch-series that
> >> fixes the locking.
> >>
> >> Daniel/Dave? Does that sound reasonable?
> 
> Yeah, sounds good.
> 
> > Reverting the patch is fine with me.  Just let me know so I can queue it
> > up again for 3.9.
> 
> Can you please also pick up the (currently) three locking fixups
> around fbcon? Just so that we don't repeat the same fun where people
> complain about lockdep splats, but the fixes are stuck somewhere. And
> I guess Dave would be happy to not end up as fbcon maintainer ;-) He
> has a git branch with them at
> http://cgit.freedesktop.org/~airlied/linux/log/?h=fbcon-locking-fixes
> though I have a small bikeshed on his last patch pending.

Care to just send me the patches through email when you all get done
bikesheding?  And for some reason I thought Andrew was going to handle
these fbcon patches, but if not, I'll be glad to take them.

thanks,

greg k-h

  reply	other threads:[~2013-01-31  9:21 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 20:04 BUG: circular locking dependency detected Russell King
2013-01-30 20:06 ` Russell King
2013-01-30 20:06   ` Russell King
2013-01-30 21:52   ` Russell King
2013-01-30 21:52     ` Russell King
2013-01-30 22:07     ` Daniel Vetter
2013-01-30 22:07       ` Daniel Vetter
2013-01-30 22:19       ` Russell King
2013-01-30 22:19         ` Russell King
2013-01-30 22:19         ` Russell King
2013-01-30 22:27         ` Daniel Vetter
2013-01-30 22:27           ` Daniel Vetter
2013-01-30 23:52         ` Linus Torvalds
2013-01-30 23:52           ` Linus Torvalds
2013-01-31  0:04           ` Dave Airlie
2013-01-31  0:04             ` Dave Airlie
2013-01-31  0:13             ` Russell King
2013-01-31  0:26               ` Linus Torvalds
2013-01-31  0:26                 ` Linus Torvalds
2013-01-31  5:40                 ` Greg Kroah-Hartman
2013-01-31  5:40                   ` Greg Kroah-Hartman
2013-01-31  8:21                   ` Daniel Vetter
2013-01-31  8:21                     ` Daniel Vetter
2013-01-31  9:21                     ` Greg Kroah-Hartman [this message]
2013-01-31  9:21                       ` Greg Kroah-Hartman
2013-01-31  9:38                       ` Daniel Vetter
2013-01-31  9:38                         ` Daniel Vetter
2013-01-31 11:51                       ` Dave Airlie
2013-01-31 11:51                         ` Dave Airlie
2013-01-31 13:02                         ` Greg Kroah-Hartman
2013-01-31 13:02                           ` Greg Kroah-Hartman
2013-01-31 13:07                         ` Russell King
2013-01-31  0:09           ` Russell King
2013-01-31 10:12 ` Sedat Dilek
2013-01-31 10:12   ` Sedat Dilek
2013-01-31 10:20   ` Sedat Dilek
2013-01-31 10:20     ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130131092146.GB3361@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=FlorianSchandinat@gmx.de \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.