All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Vincent Palatin <vpalatin@chromium.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org, Olof Johansson <olofj@chromium.org>,
	Sameer Nanda <snanda@chromium.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: (lm90) Add device tree support
Date: Fri, 01 Feb 2013 21:36:40 +0000	[thread overview]
Message-ID: <20130201213640.GA1606@roeck-us.net> (raw)
In-Reply-To: <1359753502-13240-1-git-send-email-vpalatin@chromium.org>

On Fri, Feb 01, 2013 at 01:18:22PM -0800, Vincent Palatin wrote:
> Add support to instantiate LM90-compatible sensors from a device-tree
> configuration.
> When the kernel has device tree support, we avoid doing the auto-detection
> as probing the busses might mess-up sensitive I2C devices or trigger long
> timeouts on non-functional busses.
> 
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

Hi Vincent,

OF support for I2C devices should already work through the I2C subsystem,
without explicit driver patch.

As for the detect function, I am not entirely sure if we want or should get
rid of it just because OF is configured. That may have unintended side effects.
Either case, I would argue that if we do want to do that, it should be done
for _all_ I2C devices and not just for the lm90 driver. In other words, it
should be done in the I2C subsystem, maybe with a separate configuration option.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Vincent Palatin <vpalatin@chromium.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	lm-sensors@lm-sensors.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Rob Herring <rob.herring@calxeda.com>,
	linux-kernel@vger.kernel.org, Olof Johansson <olofj@chromium.org>,
	Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH] hwmon: (lm90) Add device tree support
Date: Fri, 1 Feb 2013 13:36:40 -0800	[thread overview]
Message-ID: <20130201213640.GA1606@roeck-us.net> (raw)
In-Reply-To: <1359753502-13240-1-git-send-email-vpalatin@chromium.org>

On Fri, Feb 01, 2013 at 01:18:22PM -0800, Vincent Palatin wrote:
> Add support to instantiate LM90-compatible sensors from a device-tree
> configuration.
> When the kernel has device tree support, we avoid doing the auto-detection
> as probing the busses might mess-up sensitive I2C devices or trigger long
> timeouts on non-functional busses.
> 
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>

Hi Vincent,

OF support for I2C devices should already work through the I2C subsystem,
without explicit driver patch.

As for the detect function, I am not entirely sure if we want or should get
rid of it just because OF is configured. That may have unintended side effects.
Either case, I would argue that if we do want to do that, it should be done
for _all_ I2C devices and not just for the lm90 driver. In other words, it
should be done in the I2C subsystem, maybe with a separate configuration option.

Thanks,
Guenter

  reply	other threads:[~2013-02-01 21:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-01 21:18 [lm-sensors] [PATCH] hwmon: (lm90) Add device tree support Vincent Palatin
2013-02-01 21:18 ` Vincent Palatin
2013-02-01 21:36 ` Guenter Roeck [this message]
2013-02-01 21:36   ` Guenter Roeck
2013-02-01 21:57   ` [lm-sensors] " Jean Delvare
2013-02-01 21:57     ` Jean Delvare
2013-02-01 22:03 ` [lm-sensors] " Vincent Palatin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130201213640.GA1606@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=grant.likely@secretlab.ca \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=olofj@chromium.org \
    --cc=rob.herring@calxeda.com \
    --cc=snanda@chromium.org \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.