From: Tony Lindgren <tony@atomide.com>
To: Philip Avinash <avinashphilip@ti.com>
Cc: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, artem.bityutskiy@linux.intel.com,
zonque@gmail.com, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
nsekhar@ti.com, gururaja.hebbar@ti.com
Subject: Re: [PATCH] ARM: OMAP: gpmc: Add device tree documentation for elm handle
Date: Fri, 1 Feb 2013 13:58:54 -0800 [thread overview]
Message-ID: <20130201215854.GW22517@atomide.com> (raw)
In-Reply-To: <1358485066-27495-1-git-send-email-avinashphilip@ti.com>
* Philip Avinash <avinashphilip@ti.com> [130117 21:00]:
> In case ELM module available, omap2 NAND driver can opt for hardware
> correction method for bit flip errors in NAND flash with BCH. Hence the
> detection of ELM module is done through devicetree population of elm_id.
> This patch update device tree documentation for gpmc-nand for elm-id
> data population.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> This patch based [1] and depends on [2]. As Artem suggested, this patch can
> go in omap_tree due to the dependency on [3].
> Discussion can found at [4]
>
> Tony,
> Can you accept this patch.
Thanks applying into omap-for-v3.9/gpmc.
Regards,
Tony
> 1. http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=shortlog;h=refs/heads/omap-for-v3.9/gpmc
> 2. mtd: nand: omap2: Support for hardware BCH error correction
> http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/576daed18c3f27bb5d0e57e1df11e8f7b493dce8
> 3. ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=bc6b1e7b86f5d8e4a6fc1c0189e64bba4077efe0
> 4. https://lkml.org/lkml/2013/1/17/167
>
> .../devicetree/bindings/mtd/gpmc-nand.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> index 9f464f9..e7f8d7e 100644
> --- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> @@ -29,6 +29,9 @@ Optional properties:
> "bch4" 4-bit BCH ecc code
> "bch8" 8-bit BCH ecc code
>
> + - elm_id: Specifies elm device node. This is required to support BCH
> + error correction using ELM module.
> +
> For inline partiton table parsing (optional):
>
> - #address-cells: should be set to 1
> @@ -46,6 +49,7 @@ Example for an AM33xx board:
> #address-cells = <2>;
> #size-cells = <1>;
> ranges = <0 0 0x08000000 0x2000>; /* CS0: NAND */
> + elm_id = <&elm>;
>
> nand@0,0 {
> reg = <0 0 0>; /* CS0, offset 0 */
> --
> 1.7.9.5
>
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: gpmc: Add device tree documentation for elm handle
Date: Fri, 1 Feb 2013 13:58:54 -0800 [thread overview]
Message-ID: <20130201215854.GW22517@atomide.com> (raw)
In-Reply-To: <1358485066-27495-1-git-send-email-avinashphilip@ti.com>
* Philip Avinash <avinashphilip@ti.com> [130117 21:00]:
> In case ELM module available, omap2 NAND driver can opt for hardware
> correction method for bit flip errors in NAND flash with BCH. Hence the
> detection of ELM module is done through devicetree population of elm_id.
> This patch update device tree documentation for gpmc-nand for elm-id
> data population.
>
> Signed-off-by: Philip Avinash <avinashphilip@ti.com>
> ---
> This patch based [1] and depends on [2]. As Artem suggested, this patch can
> go in omap_tree due to the dependency on [3].
> Discussion can found at [4]
>
> Tony,
> Can you accept this patch.
Thanks applying into omap-for-v3.9/gpmc.
Regards,
Tony
> 1. http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=shortlog;h=refs/heads/omap-for-v3.9/gpmc
> 2. mtd: nand: omap2: Support for hardware BCH error correction
> http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/576daed18c3f27bb5d0e57e1df11e8f7b493dce8
> 3. ARM: OMAP: gpmc: add DT bindings for GPMC timings and NAND
> http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=commit;h=bc6b1e7b86f5d8e4a6fc1c0189e64bba4077efe0
> 4. https://lkml.org/lkml/2013/1/17/167
>
> .../devicetree/bindings/mtd/gpmc-nand.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> index 9f464f9..e7f8d7e 100644
> --- a/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpmc-nand.txt
> @@ -29,6 +29,9 @@ Optional properties:
> "bch4" 4-bit BCH ecc code
> "bch8" 8-bit BCH ecc code
>
> + - elm_id: Specifies elm device node. This is required to support BCH
> + error correction using ELM module.
> +
> For inline partiton table parsing (optional):
>
> - #address-cells: should be set to 1
> @@ -46,6 +49,7 @@ Example for an AM33xx board:
> #address-cells = <2>;
> #size-cells = <1>;
> ranges = <0 0 0x08000000 0x2000>; /* CS0: NAND */
> + elm_id = <&elm>;
>
> nand at 0,0 {
> reg = <0 0 0>; /* CS0, offset 0 */
> --
> 1.7.9.5
>
next prev parent reply other threads:[~2013-02-01 21:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 4:57 [PATCH] ARM: OMAP: gpmc: Add device tree documentation for elm handle Philip Avinash
2013-01-18 4:57 ` Philip Avinash
2013-01-18 4:57 ` Philip Avinash
2013-02-01 21:58 ` Tony Lindgren [this message]
2013-02-01 21:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201215854.GW22517@atomide.com \
--to=tony@atomide.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=avinashphilip@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gururaja.hebbar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.