All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/16] fs/ext4/indirect.c: use WARN
Date: Sat, 02 Feb 2013 01:07:37 +0000	[thread overview]
Message-ID: <20130202010737.GA9892@thunk.org> (raw)
In-Reply-To: <1351940317-14812-10-git-send-email-Julia.Lawall@lip6.fr>

On Sat, Nov 03, 2012 at 11:58:30AM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
> 
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression list es;
> @@
> 
> -printk(
> +WARN(1,
>   es);
> -WARN_ON(1);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied.

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/16] fs/ext4/indirect.c: use WARN
Date: Fri, 1 Feb 2013 20:07:37 -0500	[thread overview]
Message-ID: <20130202010737.GA9892@thunk.org> (raw)
In-Reply-To: <1351940317-14812-10-git-send-email-Julia.Lawall@lip6.fr>

On Sat, Nov 03, 2012 at 11:58:30AM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Use WARN rather than printk followed by WARN_ON(1), for conciseness.
> 
> A simplified version of the semantic patch that makes this transformation
> is as follows: (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression list es;
> @@
> 
> -printk(
> +WARN(1,
>   es);
> -WARN_ON(1);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied.

					- Ted

  reply	other threads:[~2013-02-02  1:07 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-03 10:58 [PATCH 0/16] use WARN Julia Lawall
2012-11-03 10:58 ` Julia Lawall
2012-11-03 10:58 ` [PATCH 1/16] drivers/gpu/drm/drm_cache.c: use WARN_ONCE Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 2/16] fs/hfsplus/bnode.c: use WARN Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-04 10:49   ` Vyacheslav Dubeyko
2012-11-04 11:49     ` Vyacheslav Dubeyko
2012-11-03 10:58 ` [PATCH 3/16] drivers/md/raid5.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 4/16] drivers/usb/wusbcore: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 5/16] drivers/scsi: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 6/16] drivers/infiniband/hw/cxgb4/cm.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
     [not found]   ` <1351940317-14812-7-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-11-03 12:40     ` Steve Wise
2012-11-03 12:40       ` Steve Wise
2012-11-03 12:40       ` Steve Wise
2012-11-03 10:58 ` [PATCH 7/16] drivers/scsi/gdth.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 8/16] drivers/infiniband/hw/cxgb3/iwch_cm.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
     [not found]   ` <1351940317-14812-9-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-11-03 12:39     ` Steve Wise
2012-11-03 12:39       ` Steve Wise
2012-11-03 12:39       ` Steve Wise
2012-11-03 10:58 ` [PATCH 9/16] fs/ext4/indirect.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2013-02-02  1:07   ` Theodore Ts'o [this message]
2013-02-02  1:07     ` Theodore Ts'o
2012-11-03 10:58 ` [PATCH 10/16] drivers/net/ethernet/ibm/emac/mal.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 11:30   ` walter harms
2012-11-03 11:30     ` walter harms
2012-11-03 14:14     ` Julia Lawall
2012-11-03 14:14       ` Julia Lawall
2012-11-03 16:26       ` walter harms
2012-11-03 16:26         ` walter harms
2012-11-03 16:35         ` Julia Lawall
2012-11-03 16:35           ` Julia Lawall
2012-11-03 19:43   ` David Miller
2012-11-03 19:43     ` David Miller
2012-11-03 10:58 ` [PATCH 11/16] drivers/misc/kgdbts.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 12:11   ` walter harms
2012-11-03 12:11     ` walter harms
2012-11-03 14:26     ` [PATCH] drivers/misc/kgdbts.c: remove eprintk Julia Lawall
2012-11-03 14:26       ` Julia Lawall
2012-11-04 19:39       ` Arnd Bergmann
2012-11-04 19:39         ` Arnd Bergmann
2012-11-04 19:58         ` Julia Lawall
2012-11-04 19:58           ` Julia Lawall
2012-11-04 20:51           ` Arnd Bergmann
2012-11-04 20:51             ` Arnd Bergmann
2012-11-04 21:04             ` Julia Lawall
2012-11-04 21:04               ` Julia Lawall
2012-11-05 16:26               ` Arnd Bergmann
2012-11-05 16:26                 ` Arnd Bergmann
2012-11-05 16:57                 ` Julia Lawall
2012-11-05 16:57                   ` Julia Lawall
2012-11-05 20:01                   ` Arnd Bergmann
2012-11-05 20:01                     ` Arnd Bergmann
2012-11-03 10:58 ` [PATCH 12/16] fs/logfs/gc.c: use WARN Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 13/16] fs/btrfs: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-05 15:38   ` David Sterba
2012-11-05 15:38     ` David Sterba
2012-11-03 10:58 ` [PATCH 14/16] drivers/ssb/main.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 15/16] drivers/parisc/pdc_stable.c: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall
2012-11-03 10:58 ` [PATCH 16/16] drivers/infiniband/hw/nes: " Julia Lawall
2012-11-03 10:58   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130202010737.GA9892@thunk.org \
    --to=tytso@mit.edu \
    --cc=Julia.Lawall@lip6.fr \
    --cc=adilger.kernel@dilger.ca \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.