Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

On (02/01/13 21:37), Thomas Waldecker wrote:
> Updated the shellscript with changes made by Igor posted in mailing list
> https://lists.01.org/pipermail/powertop/2012-July/000165.html
> ---

Cc Igor

All right, first, my bad, I should admit that I overlooked this patch. Sorry Igor, and
thanks to Thomas.

Second, Thomas, were you aware of the V2 patch by the time you submitted Igor's V1?



>From ethical point of view, I think only original author can change this line

 -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
 -
 +# Written by Igor Zhbanov <i.zhbanov at samsung.com>


	-ss


>  .gitignore      |  1 -
>  src/Makefile.am |  3 +--
>  src/csstoh.sh   | 21 ++++++++++-----------
>  3 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 96ffdba..35d41c2 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -39,7 +39,6 @@ po/*.gmo
>  po/stamp-po
>  src/powertop
>  src/css.h
> -src/csstoh
>  src/Makefile.in
>  src/.deps/
>  src/Makefile
> diff --git a/src/Makefile.am b/src/Makefile.am
> index a53d942..398b8a7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>  BUILT_SOURCES = css.h
>  CLEANFILES = css.h
>  css.h: powertop.css
> -	chmod +x ./csstoh.sh
> -	./csstoh.sh "$(srcdir)"/powertop.css css.h
> +	$(SHELL) ./csstoh.sh powertop.css css.h
>  
> diff --git a/src/csstoh.sh b/src/csstoh.sh
> index 5918d12..9d4100b 100755
> --- a/src/csstoh.sh
> +++ b/src/csstoh.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  #
>  # This program file is free software; you can redistribute it and/or modify it
>  # under the terms of the GNU General Public License as published by the
> @@ -16,8 +16,7 @@
>  # Boston, MA 02110-1301 USA
>  # or just google for it.
>  #
> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> -
> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>  
>  if [ $# -lt 2 ]; then
>  	echo "Usage: csstoh.sh cssfile header.h"
> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
>  	exit 1
>  fi
>  
> -if ! echo -n>$2; then
> +if ! echo -n >$2; then
>  	echo "Can't open file $2 for writing."
>  	exit 1
>  fi
>  
> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
> -echo>>  $2
> -echo "const char css[] = ">>  $2
> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
> +echo >> $2
> +echo "const char css[] = " >> $2
>  
> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
>  
> -echo ";">>  $2
> -echo "#endif">>  $2
> +echo ";" >> $2
> +echo "#endif" >> $2
> -- 
> 1.8.1
> 
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Igor Zhbanov]

[-- Attachment #1: Type: text/plain, Size: 3386 bytes --]

Kristen Carlson Accardi wrote:
> On Tue, 05 Feb 2013 13:50:34 +0400
> Igor Zhbanov <i.zhbanov(a)samsung.com> wrote:
>
>> Thomas Waldecker wrote:
>>> Updated the shellscript with changes made by Igor posted in mailing list
>>> https://lists.01.org/pipermail/powertop/2012-July/000165.html
>>>
>>> Signed-off-by: Thomas Waldecker <thomas.waldecker(a)gmail.com>
>>> ---
>>>    src/Makefile.am |  3 +--
>>>    src/csstoh.sh   | 21 ++++++++++-----------
>>>    2 files changed, 11 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/src/Makefile.am b/src/Makefile.am
>>> index a53d942..398b8a7 100644
>>> --- a/src/Makefile.am
>>> +++ b/src/Makefile.am
>>> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>>>    BUILT_SOURCES = css.h
>>>    CLEANFILES = css.h
>>>    css.h: powertop.css
>>> -	chmod +x ./csstoh.sh
>>> -	./csstoh.sh "$(srcdir)"/powertop.css css.h
>>> +	$(SHELL) ./csstoh.sh powertop.css css.h
>>>    
>>> diff --git a/src/csstoh.sh b/src/csstoh.sh
>>> index 5918d12..9d4100b 100755
>>> --- a/src/csstoh.sh
>>> +++ b/src/csstoh.sh
>>> @@ -1,4 +1,4 @@
>>> -#!/bin/bash
>>> +#!/bin/sh
>>>    #
>>>    # This program file is free software; you can redistribute it and/or modify it
>>>    # under the terms of the GNU General Public License as published by the
>>> @@ -16,8 +16,7 @@
>>>    # Boston, MA 02110-1301 USA
>>>    # or just google for it.
>>>    #
>>> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
>>> -
>>> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>>>    
>>>    if [ $# -lt 2 ]; then
>>>    	echo "Usage: csstoh.sh cssfile header.h"
>>> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
>>>    	exit 1
>>>    fi
>>>    
>>> -if ! echo -n>$2; then
>>> +if ! echo -n >$2; then
>>>    	echo "Can't open file $2 for writing."
>>>    	exit 1
>>>    fi
>>>    
>>> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
>>> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
>>> -echo>>  $2
>>> -echo "const char css[] = ">>  $2
>>> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
>>> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
>>> +echo >> $2
>>> +echo "const char css[] = " >> $2
>>>    
>>> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
>>> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
>>>    
>>> -echo ";">>  $2
>>> -echo "#endif">>  $2
>>> +echo ";" >> $2
>>> +echo "#endif" >> $2
>> The space characters issue was because of bad mail-client.
>> The spaces were always there. :-)
>> Last patch was sent by git, so it was transmitted exactly.
>>
>> Also it the last version of the patch /bin/bash was changed to /bin/sh
>> for better portability. So the (this) last version is better. :-)
>> I use it for cross-compilation. My own version is the same except
>> of my e-mail. I have "@" instead of "at" in it. The "at" word was created
>> by bad mail client. But this is not important. :-)
>>
> So would you like us to go ahead and apply this patch?
>
Yes. :-) With correct white-space characters, /bin/bash -> /bin/sh
and added $(SHELL) to Makefile, this patch would be better than first version.

-- 
Best regards,
Igor Zhbanov,
Sub-Project Leader,
phone: +7 (495) 797 25 00 ext 3981
e-mail: i.zhbanov(a)samsung.com

Mobile group, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]

On Tue, 05 Feb 2013 13:50:34 +0400
Igor Zhbanov <i.zhbanov(a)samsung.com> wrote:

> Thomas Waldecker wrote:
> > Updated the shellscript with changes made by Igor posted in mailing list
> > https://lists.01.org/pipermail/powertop/2012-July/000165.html
> >
> > Signed-off-by: Thomas Waldecker <thomas.waldecker(a)gmail.com>
> > ---
> >   src/Makefile.am |  3 +--
> >   src/csstoh.sh   | 21 ++++++++++-----------
> >   2 files changed, 11 insertions(+), 13 deletions(-)
> >
> > diff --git a/src/Makefile.am b/src/Makefile.am
> > index a53d942..398b8a7 100644
> > --- a/src/Makefile.am
> > +++ b/src/Makefile.am
> > @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
> >   BUILT_SOURCES = css.h
> >   CLEANFILES = css.h
> >   css.h: powertop.css
> > -	chmod +x ./csstoh.sh
> > -	./csstoh.sh "$(srcdir)"/powertop.css css.h
> > +	$(SHELL) ./csstoh.sh powertop.css css.h
> >   
> > diff --git a/src/csstoh.sh b/src/csstoh.sh
> > index 5918d12..9d4100b 100755
> > --- a/src/csstoh.sh
> > +++ b/src/csstoh.sh
> > @@ -1,4 +1,4 @@
> > -#!/bin/bash
> > +#!/bin/sh
> >   #
> >   # This program file is free software; you can redistribute it and/or modify it
> >   # under the terms of the GNU General Public License as published by the
> > @@ -16,8 +16,7 @@
> >   # Boston, MA 02110-1301 USA
> >   # or just google for it.
> >   #
> > -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> > -
> > +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
> >   
> >   if [ $# -lt 2 ]; then
> >   	echo "Usage: csstoh.sh cssfile header.h"
> > @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
> >   	exit 1
> >   fi
> >   
> > -if ! echo -n>$2; then
> > +if ! echo -n >$2; then
> >   	echo "Can't open file $2 for writing."
> >   	exit 1
> >   fi
> >   
> > -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
> > -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
> > -echo>>  $2
> > -echo "const char css[] = ">>  $2
> > +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
> > +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
> > +echo >> $2
> > +echo "const char css[] = " >> $2
> >   
> > -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
> > +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
> >   
> > -echo ";">>  $2
> > -echo "#endif">>  $2
> > +echo ";" >> $2
> > +echo "#endif" >> $2
> The space characters issue was because of bad mail-client.
> The spaces were always there. :-)
> Last patch was sent by git, so it was transmitted exactly.
> 
> Also it the last version of the patch /bin/bash was changed to /bin/sh
> for better portability. So the (this) last version is better. :-)
> I use it for cross-compilation. My own version is the same except
> of my e-mail. I have "@" instead of "at" in it. The "at" word was created
> by bad mail client. But this is not important. :-)
> 

So would you like us to go ahead and apply this patch?

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Igor Zhbanov]

[-- Attachment #1: Type: text/plain, Size: 2863 bytes --]

Thomas Waldecker wrote:
> Updated the shellscript with changes made by Igor posted in mailing list
> https://lists.01.org/pipermail/powertop/2012-July/000165.html
>
> Signed-off-by: Thomas Waldecker <thomas.waldecker(a)gmail.com>
> ---
>   src/Makefile.am |  3 +--
>   src/csstoh.sh   | 21 ++++++++++-----------
>   2 files changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index a53d942..398b8a7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>   BUILT_SOURCES = css.h
>   CLEANFILES = css.h
>   css.h: powertop.css
> -	chmod +x ./csstoh.sh
> -	./csstoh.sh "$(srcdir)"/powertop.css css.h
> +	$(SHELL) ./csstoh.sh powertop.css css.h
>   
> diff --git a/src/csstoh.sh b/src/csstoh.sh
> index 5918d12..9d4100b 100755
> --- a/src/csstoh.sh
> +++ b/src/csstoh.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>   #
>   # This program file is free software; you can redistribute it and/or modify it
>   # under the terms of the GNU General Public License as published by the
> @@ -16,8 +16,7 @@
>   # Boston, MA 02110-1301 USA
>   # or just google for it.
>   #
> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> -
> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>   
>   if [ $# -lt 2 ]; then
>   	echo "Usage: csstoh.sh cssfile header.h"
> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
>   	exit 1
>   fi
>   
> -if ! echo -n>$2; then
> +if ! echo -n >$2; then
>   	echo "Can't open file $2 for writing."
>   	exit 1
>   fi
>   
> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
> -echo>>  $2
> -echo "const char css[] = ">>  $2
> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
> +echo >> $2
> +echo "const char css[] = " >> $2
>   
> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
>   
> -echo ";">>  $2
> -echo "#endif">>  $2
> +echo ";" >> $2
> +echo "#endif" >> $2
The space characters issue was because of bad mail-client.
The spaces were always there. :-)
Last patch was sent by git, so it was transmitted exactly.

Also it the last version of the patch /bin/bash was changed to /bin/sh
for better portability. So the (this) last version is better. :-)
I use it for cross-compilation. My own version is the same except
of my e-mail. I have "@" instead of "at" in it. The "at" word was created
by bad mail client. But this is not important. :-)

-- 
Best regards,
Igor Zhbanov,
Sub-Project Leader,
phone: +7 (495) 797 25 00 ext 3981
e-mail: i.zhbanov(a)samsung.com

Mobile group, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation

[Powertop] [PATCH] csstoh shell-script for cross-compiling

[Thomas Waldecker]

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

Updated the shellscript with changes made by Igor posted in mailing list
https://lists.01.org/pipermail/powertop/2012-July/000165.html

Signed-off-by: Thomas Waldecker <thomas.waldecker(a)gmail.com>
---
 src/Makefile.am |  3 +--
 src/csstoh.sh   | 21 ++++++++++-----------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index a53d942..398b8a7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
 BUILT_SOURCES = css.h
 CLEANFILES = css.h
 css.h: powertop.css
-	chmod +x ./csstoh.sh
-	./csstoh.sh "$(srcdir)"/powertop.css css.h
+	$(SHELL) ./csstoh.sh powertop.css css.h
 
diff --git a/src/csstoh.sh b/src/csstoh.sh
index 5918d12..9d4100b 100755
--- a/src/csstoh.sh
+++ b/src/csstoh.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # This program file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by the
@@ -16,8 +16,7 @@
 # Boston, MA 02110-1301 USA
 # or just google for it.
 #
-# Written by Igor Zhbanov<i.zhbanov at samsung.com>
-
+# Written by Igor Zhbanov <i.zhbanov at samsung.com>
 
 if [ $# -lt 2 ]; then
 	echo "Usage: csstoh.sh cssfile header.h"
@@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
 	exit 1
 fi
 
-if ! echo -n>$2; then
+if ! echo -n >$2; then
 	echo "Can't open file $2 for writing."
 	exit 1
 fi
 
-echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
-echo "#define __INCLUDE_GUARD_CCS_H">>  $2
-echo>>  $2
-echo "const char css[] = ">>  $2
+echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
+echo "#define __INCLUDE_GUARD_CCS_H" >> $2
+echo >> $2
+echo "const char css[] = " >> $2
 
-sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
+sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
 
-echo ";">>  $2
-echo "#endif">>  $2
+echo ";" >> $2
+echo "#endif" >> $2
-- 
1.8.1

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]

On Fri,  1 Feb 2013 21:37:09 +0100
Thomas Waldecker <thomas.waldecker(a)gmail.com> wrote:

> Updated the shellscript with changes made by Igor posted in mailing list
> https://lists.01.org/pipermail/powertop/2012-July/000165.html

The patch no longer applies, because I took Sergey's patch removing
csstoh.  You'll have to redo it.

I don't have a problem with taking this patch if you say it works for
you, with or without Igor's ack, as long as it's harmless to native
compiling.  I'm never going to test cross compiling though.

My suggestion to you is to just CC Igor on your revised patch - if he
wants to nack it and resubmit his own he can, otherwise I'll take
yours after some reasonable period of time.

> ---
>  .gitignore      |  1 -
>  src/Makefile.am |  3 +--
>  src/csstoh.sh   | 21 ++++++++++-----------
>  3 files changed, 11 insertions(+), 14 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index 96ffdba..35d41c2 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -39,7 +39,6 @@ po/*.gmo
>  po/stamp-po
>  src/powertop
>  src/css.h
> -src/csstoh
>  src/Makefile.in
>  src/.deps/
>  src/Makefile
> diff --git a/src/Makefile.am b/src/Makefile.am
> index a53d942..398b8a7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>  BUILT_SOURCES = css.h
>  CLEANFILES = css.h
>  css.h: powertop.css
> -	chmod +x ./csstoh.sh
> -	./csstoh.sh "$(srcdir)"/powertop.css css.h
> +	$(SHELL) ./csstoh.sh powertop.css css.h
>  
> diff --git a/src/csstoh.sh b/src/csstoh.sh
> index 5918d12..9d4100b 100755
> --- a/src/csstoh.sh
> +++ b/src/csstoh.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>  #
>  # This program file is free software; you can redistribute it and/or modify it
>  # under the terms of the GNU General Public License as published by the
> @@ -16,8 +16,7 @@
>  # Boston, MA 02110-1301 USA
>  # or just google for it.
>  #
> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> -
> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>  
>  if [ $# -lt 2 ]; then
>  	echo "Usage: csstoh.sh cssfile header.h"
> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
>  	exit 1
>  fi
>  
> -if ! echo -n>$2; then
> +if ! echo -n >$2; then
>  	echo "Can't open file $2 for writing."
>  	exit 1
>  fi
>  
> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
> -echo>>  $2
> -echo "const char css[] = ">>  $2
> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
> +echo >> $2
> +echo "const char css[] = " >> $2
>  
> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
>  
> -echo ";">>  $2
> -echo "#endif">>  $2
> +echo ";" >> $2
> +echo "#endif" >> $2

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Kristen Carlson Accardi]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

On Sat, 2 Feb 2013 09:26:56 +0300
Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com> wrote:

> On (02/01/13 21:37), Thomas Waldecker wrote:
> > Updated the shellscript with changes made by Igor posted in mailing list
> > https://lists.01.org/pipermail/powertop/2012-July/000165.html
> > ---
> 
> Cc Igor
> 
> All right, first, my bad, I should admit that I overlooked this patch. Sorry Igor, and
> thanks to Thomas.
> 
> Second, Thomas, were you aware of the V2 patch by the time you submitted Igor's V1?
> 
> 
> 
> From ethical point of view, I think only original author can change this line
> 
>  -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
>  -
>  +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
> 
> 
> 	-ss
> 

It's just a whitespace change. I see no issue.

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On (02/04/13 10:40), Thomas Waldecker wrote:
> Hi Sergey,
> 
> > well, the whole situation is confusing. we've pushed Igor's patch on behalf of Thomas and
> > now we are about to do similar thing (diff between two Igor's patches) again.
> > I'm sorry Thomas, I appreciate your help, but I can't ACK your patch without Igor's
> > ACK/patch of his own/etc.
> 
> I don't understand your patch apply policy. 

Apparently, I do mistakes or, at least, not very attentive sometimes.
My word is not the last one, and project owners may have different opinion/decision, 
I just said I don't think this is completely right.


> I also don't understand why nobody didn't apply Igors patch first time.
>

I can't tell.

 
> I just applied the changes which he did in his V2. I think it is a
> reasonable change.


> It would be also ok for me if you just use the patch and change the author.
>

Not sure I got this.


	-ss

 
> P.S. Sorry for double post, forgot to include mailing list again
> 
> Kind regards,
> Thomas
> 

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Thomas Waldecker]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi Sergey,

> well, the whole situation is confusing. we've pushed Igor's patch on behalf of Thomas and
> now we are about to do similar thing (diff between two Igor's patches) again.
> I'm sorry Thomas, I appreciate your help, but I can't ACK your patch without Igor's
> ACK/patch of his own/etc.

I don't understand your patch apply policy. I also don't understand
why nobody didn't apply
Igors patch first time.

I just applied the changes which he did in his V2. I think it is a
reasonable change.
It would be also ok for me if you just use the patch and change the author.

P.S. Sorry for double post, forgot to include mailing list again

Kind regards,
Thomas

Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 4442 bytes --]

On (02/02/13 10:03), Thomas Waldecker wrote:
> Forgot to include mailing list.
> 
> Hi Sergey,
> 
> no I were not aware of the V2 patch. V1 just worked for me.
> 
> Magnus made me aware of the V2 of the patch:
> https://lists.01.org/pipermail/powertop/2013-January/000725.html
>

Hello,

wow! that's something... somehow I did not receive this message. I can see it in my
gmail web interface, on mailing list web page, but fetchmail (usually trusted) refused
to fetch it and thus I missed it. thanks for pointing that out for me.

well, the whole situation is confusing. we've pushed Igor's patch on behalf of Thomas and
now we are about to do similar thing (diff between two Igor's patches) again. 
I'm sorry Thomas, I appreciate your help, but I can't ACK your patch without Igor's
ACK/patch of his own/etc.

thanks,

	-ss

 
> For some reason my patch didn't go as a respose to his email.
> 
> Thomas
> 
> 2013/2/2 Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>:
> > On (02/01/13 21:37), Thomas Waldecker wrote:
> >> Updated the shellscript with changes made by Igor posted in mailing list
> >> https://lists.01.org/pipermail/powertop/2012-July/000165.html
> >> ---
> >
> > Cc Igor
> >
> > All right, first, my bad, I should admit that I overlooked this patch. Sorry Igor, and
> > thanks to Thomas.
> >
> > Second, Thomas, were you aware of the V2 patch by the time you submitted Igor's V1?
> >
> >
> >
> > From ethical point of view, I think only original author can change this line
> >
> >  -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> >  -
> >  +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
> >
> >
> >         -ss
> >
> >
> >>  .gitignore      |  1 -
> >>  src/Makefile.am |  3 +--
> >>  src/csstoh.sh   | 21 ++++++++++-----------
> >>  3 files changed, 11 insertions(+), 14 deletions(-)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 96ffdba..35d41c2 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -39,7 +39,6 @@ po/*.gmo
> >>  po/stamp-po
> >>  src/powertop
> >>  src/css.h
> >> -src/csstoh
> >>  src/Makefile.in
> >>  src/.deps/
> >>  src/Makefile
> >> diff --git a/src/Makefile.am b/src/Makefile.am
> >> index a53d942..398b8a7 100644
> >> --- a/src/Makefile.am
> >> +++ b/src/Makefile.am
> >> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
> >>  BUILT_SOURCES = css.h
> >>  CLEANFILES = css.h
> >>  css.h: powertop.css
> >> -     chmod +x ./csstoh.sh
> >> -     ./csstoh.sh "$(srcdir)"/powertop.css css.h
> >> +     $(SHELL) ./csstoh.sh powertop.css css.h
> >>
> >> diff --git a/src/csstoh.sh b/src/csstoh.sh
> >> index 5918d12..9d4100b 100755
> >> --- a/src/csstoh.sh
> >> +++ b/src/csstoh.sh
> >> @@ -1,4 +1,4 @@
> >> -#!/bin/bash
> >> +#!/bin/sh
> >>  #
> >>  # This program file is free software; you can redistribute it and/or modify it
> >>  # under the terms of the GNU General Public License as published by the
> >> @@ -16,8 +16,7 @@
> >>  # Boston, MA 02110-1301 USA
> >>  # or just google for it.
> >>  #
> >> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
> >> -
> >> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
> >>
> >>  if [ $# -lt 2 ]; then
> >>       echo "Usage: csstoh.sh cssfile header.h"
> >> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
> >>       exit 1
> >>  fi
> >>
> >> -if ! echo -n>$2; then
> >> +if ! echo -n >$2; then
> >>       echo "Can't open file $2 for writing."
> >>       exit 1
> >>  fi
> >>
> >> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
> >> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
> >> -echo>>  $2
> >> -echo "const char css[] = ">>  $2
> >> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
> >> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
> >> +echo >> $2
> >> +echo "const char css[] = " >> $2
> >>
> >> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
> >> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
> >>
> >> -echo ";">>  $2
> >> -echo "#endif">>  $2
> >> +echo ";" >> $2
> >> +echo "#endif" >> $2
> >> --
> >> 1.8.1
> >>
> >> _______________________________________________
> >> PowerTop mailing list
> >> PowerTop(a)lists.01.org
> >> https://lists.01.org/mailman/listinfo/powertop
> >>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
> 

[Powertop] [PATCH] csstoh shell-script for cross-compiling

[Thomas Waldecker]

[-- Attachment #1: Type: text/plain, Size: 3680 bytes --]

Forgot to include mailing list.


---------- Forwarded message ----------
From: Thomas Waldecker <thomas.waldecker(a)gmail.com>
Date: 2013/2/2
Subject: Re: [Powertop] [PATCH] csstoh shell-script for cross-compiling
To: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>


Hi Sergey,

no I were not aware of the V2 patch. V1 just worked for me.

Magnus made me aware of the V2 of the patch:
https://lists.01.org/pipermail/powertop/2013-January/000725.html

For some reason my patch didn't go as a respose to his email.

Thomas

2013/2/2 Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>:
> On (02/01/13 21:37), Thomas Waldecker wrote:
>> Updated the shellscript with changes made by Igor posted in mailing list
>> https://lists.01.org/pipermail/powertop/2012-July/000165.html
>> ---
>
> Cc Igor
>
> All right, first, my bad, I should admit that I overlooked this patch. Sorry Igor, and
> thanks to Thomas.
>
> Second, Thomas, were you aware of the V2 patch by the time you submitted Igor's V1?
>
>
>
> From ethical point of view, I think only original author can change this line
>
>  -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
>  -
>  +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>
>
>         -ss
>
>
>>  .gitignore      |  1 -
>>  src/Makefile.am |  3 +--
>>  src/csstoh.sh   | 21 ++++++++++-----------
>>  3 files changed, 11 insertions(+), 14 deletions(-)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 96ffdba..35d41c2 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -39,7 +39,6 @@ po/*.gmo
>>  po/stamp-po
>>  src/powertop
>>  src/css.h
>> -src/csstoh
>>  src/Makefile.in
>>  src/.deps/
>>  src/Makefile
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index a53d942..398b8a7 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
>>  BUILT_SOURCES = css.h
>>  CLEANFILES = css.h
>>  css.h: powertop.css
>> -     chmod +x ./csstoh.sh
>> -     ./csstoh.sh "$(srcdir)"/powertop.css css.h
>> +     $(SHELL) ./csstoh.sh powertop.css css.h
>>
>> diff --git a/src/csstoh.sh b/src/csstoh.sh
>> index 5918d12..9d4100b 100755
>> --- a/src/csstoh.sh
>> +++ b/src/csstoh.sh
>> @@ -1,4 +1,4 @@
>> -#!/bin/bash
>> +#!/bin/sh
>>  #
>>  # This program file is free software; you can redistribute it and/or modify it
>>  # under the terms of the GNU General Public License as published by the
>> @@ -16,8 +16,7 @@
>>  # Boston, MA 02110-1301 USA
>>  # or just google for it.
>>  #
>> -# Written by Igor Zhbanov<i.zhbanov at samsung.com>
>> -
>> +# Written by Igor Zhbanov <i.zhbanov at samsung.com>
>>
>>  if [ $# -lt 2 ]; then
>>       echo "Usage: csstoh.sh cssfile header.h"
>> @@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
>>       exit 1
>>  fi
>>
>> -if ! echo -n>$2; then
>> +if ! echo -n >$2; then
>>       echo "Can't open file $2 for writing."
>>       exit 1
>>  fi
>>
>> -echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
>> -echo "#define __INCLUDE_GUARD_CCS_H">>  $2
>> -echo>>  $2
>> -echo "const char css[] = ">>  $2
>> +echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
>> +echo "#define __INCLUDE_GUARD_CCS_H" >> $2
>> +echo >> $2
>> +echo "const char css[] = " >> $2
>>
>> -sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
>> +sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
>>
>> -echo ";">>  $2
>> -echo "#endif">>  $2
>> +echo ";" >> $2
>> +echo "#endif" >> $2
>> --
>> 1.8.1
>>
>> _______________________________________________
>> PowerTop mailing list
>> PowerTop(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/powertop
>>

[Powertop] [PATCH] csstoh shell-script for cross-compiling

[Thomas Waldecker]

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

Updated the shellscript with changes made by Igor posted in mailing list
https://lists.01.org/pipermail/powertop/2012-July/000165.html
---
 .gitignore      |  1 -
 src/Makefile.am |  3 +--
 src/csstoh.sh   | 21 ++++++++++-----------
 3 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/.gitignore b/.gitignore
index 96ffdba..35d41c2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -39,7 +39,6 @@ po/*.gmo
 po/stamp-po
 src/powertop
 src/css.h
-src/csstoh
 src/Makefile.in
 src/.deps/
 src/Makefile
diff --git a/src/Makefile.am b/src/Makefile.am
index a53d942..398b8a7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -46,6 +46,5 @@ AM_LDFLAGS = $(LIBS) $(NCURSES_LIBS) $(PCIUTILS_LIBS) $(LIBNL_LIBS) $(LIBZ_LIBS)
 BUILT_SOURCES = css.h
 CLEANFILES = css.h
 css.h: powertop.css
-	chmod +x ./csstoh.sh
-	./csstoh.sh "$(srcdir)"/powertop.css css.h
+	$(SHELL) ./csstoh.sh powertop.css css.h
 
diff --git a/src/csstoh.sh b/src/csstoh.sh
index 5918d12..9d4100b 100755
--- a/src/csstoh.sh
+++ b/src/csstoh.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # This program file is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by the
@@ -16,8 +16,7 @@
 # Boston, MA 02110-1301 USA
 # or just google for it.
 #
-# Written by Igor Zhbanov<i.zhbanov at samsung.com>
-
+# Written by Igor Zhbanov <i.zhbanov at samsung.com>
 
 if [ $# -lt 2 ]; then
 	echo "Usage: csstoh.sh cssfile header.h"
@@ -29,17 +28,17 @@ if [ ! -r $1 ]; then
 	exit 1
 fi
 
-if ! echo -n>$2; then
+if ! echo -n >$2; then
 	echo "Can't open file $2 for writing."
 	exit 1
 fi
 
-echo "#ifndef __INCLUDE_GUARD_CCS_H">>  $2
-echo "#define __INCLUDE_GUARD_CCS_H">>  $2
-echo>>  $2
-echo "const char css[] = ">>  $2
+echo "#ifndef __INCLUDE_GUARD_CCS_H" >> $2
+echo "#define __INCLUDE_GUARD_CCS_H" >> $2
+echo >> $2
+echo "const char css[] = " >> $2
 
-sed -r 's/^(.*)$/\t\"\1\\n\"/' $1>>  $2
+sed -r 's/^(.*)$/\t\"\1\\n\"/' $1 >> $2
 
-echo ";">>  $2
-echo "#endif">>  $2
+echo ";" >> $2
+echo "#endif" >> $2
-- 
1.8.1