Re: [PATCH] tools/xc: restore logging in xc_save

[Olaf Hering <olaf@aepfle.de>]

On Mon, Feb 04, Ian Campbell wrote:

> On Mon, 2013-02-04 at 10:23 +0000, Olaf Hering wrote:
> > On Mon, Feb 04, Ian Campbell wrote:
> > 
> > > On Fri, 2013-02-01 at 18:58 +0000, Olaf Hering wrote:
> > > > +    lvl = si.flags & XCFLAGS_DEBUG ? XTL_DEBUG: XTL_DETAIL;
> > > > +    lflags = XTL_STDIOSTREAM_HIDE_PROGRESS;
> > > 
> > > Would it be useful (as an extension) to implement an XTL_STDIOSTREAM
> > > flag which makes it output something more suitable for logging,
> > > e.g. ...10%...20%...30%... 
> > > (or perhaps automatic based on isatty(outputfd)?)
> > 
> > I was thinking about that, to extend the called progress functions. In
> > the case of xend.log it would produce many lines of progress.
> 
> How come many lines? I imaged the above as a single line.

Oh, I did not realize that we did not talk about
XTL_STDIOSTREAM_HIDE_PROGRESS but about another new flag.


> > No idea if any caller makes use of the progress, given that it did not
> > work at all without the other patch I sent last Friday.
> 
> xl migrate uses AFAIK, which isn't to say it wasn't broken ;-)

For me it was not printed without the patch in
<6d1d516ecaade56f796e.1359738924@probook.site>

> Although I did mean to ask why the code had to move?

To get to si.flags.

Olaf