* [PATCH] media: config option for building tuners
@ 2013-01-24 22:11 Simon Que
2013-02-04 1:15 ` Michael Krufky
0 siblings, 1 reply; 3+ messages in thread
From: Simon Que @ 2013-01-24 22:11 UTC (permalink / raw)
To: mchehab, linux-media; +Cc: msb, posciak, Simon Que
This patch provides a Kconfig option, MEDIA_TUNER_SUPPORT, that
determines whether media/tuners is included in the build. This way,
the tuners don't have to be unconditionally included in the build.
Signed-off-by: Simon Que <sque@chromium.org>
---
drivers/media/Kconfig | 9 +++++++++
drivers/media/Makefile | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 4ef0d80..a266da2 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -73,6 +73,15 @@ config MEDIA_RC_SUPPORT
Say Y when you have a TV or an IR device.
+config MEDIA_TUNER_SUPPORT
+ tristate
+ help
+ This enables the tuner modules in the tuners directory. Use this
+ option to turn on tuners. The individual tuner modules can then be
+ turned on/off one-by-one.
+
+ Say Y when you have a V4L/DVB tuner in your system.
+
#
# Media controller
# Selectable only for webcam/grabbers, as other drivers don't use it
diff --git a/drivers/media/Makefile b/drivers/media/Makefile
index 620f275..679db94 100644
--- a/drivers/media/Makefile
+++ b/drivers/media/Makefile
@@ -8,7 +8,8 @@ media-objs := media-device.o media-devnode.o media-entity.o
# I2C drivers should come before other drivers, otherwise they'll fail
# when compiled as builtin drivers
#
-obj-y += i2c/ tuners/
+obj-y += i2c/
+obj-$(CONFIG_MEDIA_TUNER_SUPPORT) += tuners/
obj-$(CONFIG_DVB_CORE) += dvb-frontends/
#
--
1.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: config option for building tuners
2013-01-24 22:11 [PATCH] media: config option for building tuners Simon Que
@ 2013-02-04 1:15 ` Michael Krufky
2013-02-04 13:32 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Michael Krufky @ 2013-02-04 1:15 UTC (permalink / raw)
To: Simon Que; +Cc: mchehab, linux-media, msb, posciak
On Thu, Jan 24, 2013 at 5:11 PM, Simon Que <sque@chromium.org> wrote:
> This patch provides a Kconfig option, MEDIA_TUNER_SUPPORT, that
> determines whether media/tuners is included in the build. This way,
> the tuners don't have to be unconditionally included in the build.
>
> Signed-off-by: Simon Que <sque@chromium.org>
> ---
> drivers/media/Kconfig | 9 +++++++++
> drivers/media/Makefile | 3 ++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 4ef0d80..a266da2 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -73,6 +73,15 @@ config MEDIA_RC_SUPPORT
>
> Say Y when you have a TV or an IR device.
>
> +config MEDIA_TUNER_SUPPORT
> + tristate
> + help
> + This enables the tuner modules in the tuners directory. Use this
> + option to turn on tuners. The individual tuner modules can then be
> + turned on/off one-by-one.
> +
> + Say Y when you have a V4L/DVB tuner in your system.
> +
> #
> # Media controller
> # Selectable only for webcam/grabbers, as other drivers don't use it
> diff --git a/drivers/media/Makefile b/drivers/media/Makefile
> index 620f275..679db94 100644
> --- a/drivers/media/Makefile
> +++ b/drivers/media/Makefile
> @@ -8,7 +8,8 @@ media-objs := media-device.o media-devnode.o media-entity.o
> # I2C drivers should come before other drivers, otherwise they'll fail
> # when compiled as builtin drivers
> #
> -obj-y += i2c/ tuners/
> +obj-y += i2c/
> +obj-$(CONFIG_MEDIA_TUNER_SUPPORT) += tuners/
> obj-$(CONFIG_DVB_CORE) += dvb-frontends/
>
> #
I don't quite see the benefit of this patch. Could you explain to us
what the desired effect is that you're looking to achieve? I believe
that if you have no drivers selected that need tuners, that no tuner
drivers will be built, or at least that's how it used to work.
Even if you did select a driver that uses a tuner, you can enable the
customization options and deselect all of the tuners drivers. I don't
think this patch is needed at all, if I understand your goal
correctly.
If I'm missing something, please elaborate.
-Mike
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: config option for building tuners
2013-02-04 1:15 ` Michael Krufky
@ 2013-02-04 13:32 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2013-02-04 13:32 UTC (permalink / raw)
To: Michael Krufky; +Cc: Simon Que, linux-media, msb, posciak
Em Sun, 3 Feb 2013 20:15:53 -0500
Michael Krufky <mkrufky@linuxtv.org> escreveu:
> On Thu, Jan 24, 2013 at 5:11 PM, Simon Que <sque@chromium.org> wrote:
> > This patch provides a Kconfig option, MEDIA_TUNER_SUPPORT, that
> > determines whether media/tuners is included in the build. This way,
> > the tuners don't have to be unconditionally included in the build.
> >
> > Signed-off-by: Simon Que <sque@chromium.org>
> > ---
> > drivers/media/Kconfig | 9 +++++++++
> > drivers/media/Makefile | 3 ++-
> > 2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index 4ef0d80..a266da2 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -73,6 +73,15 @@ config MEDIA_RC_SUPPORT
> >
> > Say Y when you have a TV or an IR device.
> >
> > +config MEDIA_TUNER_SUPPORT
> > + tristate
> > + help
> > + This enables the tuner modules in the tuners directory. Use this
> > + option to turn on tuners. The individual tuner modules can then be
> > + turned on/off one-by-one.
> > +
> > + Say Y when you have a V4L/DVB tuner in your system.
> > +
> > #
> > # Media controller
> > # Selectable only for webcam/grabbers, as other drivers don't use it
> > diff --git a/drivers/media/Makefile b/drivers/media/Makefile
> > index 620f275..679db94 100644
> > --- a/drivers/media/Makefile
> > +++ b/drivers/media/Makefile
> > @@ -8,7 +8,8 @@ media-objs := media-device.o media-devnode.o media-entity.o
> > # I2C drivers should come before other drivers, otherwise they'll fail
> > # when compiled as builtin drivers
> > #
> > -obj-y += i2c/ tuners/
> > +obj-y += i2c/
> > +obj-$(CONFIG_MEDIA_TUNER_SUPPORT) += tuners/
> > obj-$(CONFIG_DVB_CORE) += dvb-frontends/
> >
> > #
>
>
> I don't quite see the benefit of this patch. Could you explain to us
> what the desired effect is that you're looking to achieve? I believe
> that if you have no drivers selected that need tuners, that no tuner
> drivers will be built, or at least that's how it used to work.
>
> Even if you did select a driver that uses a tuner, you can enable the
> customization options and deselect all of the tuners drivers. I don't
> think this patch is needed at all, if I understand your goal
> correctly.
>
> If I'm missing something, please elaborate.
I'd say that this patch is likely broken, as it doesn't take
MEDIA_SUBDRV_AUTOSELECT Kconfig option into account.
Regards,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-04 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 22:11 [PATCH] media: config option for building tuners Simon Que
2013-02-04 1:15 ` Michael Krufky
2013-02-04 13:32 ` Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.