From: Andrew Morton <akpm@linux-foundation.org>
To: Lin Feng <linfeng@cn.fujitsu.com>,
mgorman@suse.de, bcrl@kvack.org, viro@zeniv.linux.org.uk,
khlebnikov@openvz.org, walken@google.com,
kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
riel@redhat.com, rientjes@google.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, jiang.liu@huawei.com, linux-mm@kvack.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()
Date: Mon, 4 Feb 2013 16:18:48 -0800 [thread overview]
Message-ID: <20130204161848.bfd36176.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130204160624.5c20a8a0.akpm@linux-foundation.org>
Also...
On Mon, 4 Feb 2013 16:06:24 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > +put_page:
> > + /* Undo the effects of former get_user_pages(), we won't pin anything */
> > + for (i = 0; i < ret; i++)
> > + put_page(pages[i]);
We can use release_pages() here.
release_pages() is designed to be more efficient when we're putting the
final reference to (most of) the pages. It probably has little if any
benefit when putting still-in-use pages, as we're doing here.
But please consider...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Lin Feng <linfeng@cn.fujitsu.com>,
mgorman@suse.de, bcrl@kvack.org, viro@zeniv.linux.org.uk,
khlebnikov@openvz.org, walken@google.com,
kamezawa.hiroyu@jp.fujitsu.com, minchan@kernel.org,
riel@redhat.com, rientjes@google.com,
isimatu.yasuaki@jp.fujitsu.com, wency@cn.fujitsu.com,
laijs@cn.fujitsu.com, jiang.liu@huawei.com, linux-mm@kvack.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable()
Date: Mon, 4 Feb 2013 16:18:48 -0800 [thread overview]
Message-ID: <20130204161848.bfd36176.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130204160624.5c20a8a0.akpm@linux-foundation.org>
Also...
On Mon, 4 Feb 2013 16:06:24 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> > +put_page:
> > + /* Undo the effects of former get_user_pages(), we won't pin anything */
> > + for (i = 0; i < ret; i++)
> > + put_page(pages[i]);
We can use release_pages() here.
release_pages() is designed to be more efficient when we're putting the
final reference to (most of) the pages. It probably has little if any
benefit when putting still-in-use pages, as we're doing here.
But please consider...
next prev parent reply other threads:[~2013-02-05 0:18 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 10:04 [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Lin Feng
2013-02-04 10:04 ` Lin Feng
2013-02-04 10:04 ` [PATCH 1/2] mm: hotplug: implement non-movable version of get_user_pages() called get_user_pages_non_movable() Lin Feng
2013-02-04 10:04 ` Lin Feng
2013-02-04 10:04 ` Lin Feng
2013-02-05 0:06 ` Andrew Morton
2013-02-05 0:06 ` Andrew Morton
2013-02-05 0:06 ` Andrew Morton
2013-02-05 0:18 ` Andrew Morton [this message]
2013-02-05 0:18 ` Andrew Morton
2013-02-05 3:09 ` Lin Feng
2013-02-05 3:09 ` Lin Feng
2013-02-05 3:09 ` Lin Feng
2013-02-05 21:13 ` Andrew Morton
2013-02-05 21:13 ` Andrew Morton
2013-02-05 21:13 ` Andrew Morton
2013-02-05 11:57 ` Mel Gorman
2013-02-05 11:57 ` Mel Gorman
2013-02-05 11:57 ` Mel Gorman
2013-02-05 13:32 ` Mel Gorman
2013-02-05 13:32 ` Mel Gorman
2013-02-05 13:32 ` Mel Gorman
2013-02-19 13:37 ` Lin Feng
2013-02-19 13:37 ` Lin Feng
2013-02-20 2:34 ` Lin Feng
2013-02-20 2:34 ` Lin Feng
2013-02-20 2:34 ` Lin Feng
2013-02-20 2:44 ` Wanpeng Li
2013-02-20 2:44 ` Wanpeng Li
2013-02-20 2:59 ` Lin Feng
2013-02-20 2:59 ` Lin Feng
2013-02-20 2:44 ` Wanpeng Li
2013-02-20 9:58 ` Simon Jeons
2013-02-20 9:58 ` Simon Jeons
2013-02-20 10:23 ` Lin Feng
2013-02-20 10:23 ` Lin Feng
2013-02-20 10:23 ` Lin Feng
2013-02-20 11:31 ` Simon Jeons
2013-02-20 11:31 ` Simon Jeons
2013-02-20 11:54 ` Lin Feng
2013-02-20 11:54 ` Lin Feng
2013-02-20 11:54 ` Lin Feng
2013-02-06 2:26 ` Michel Lespinasse
2013-02-06 2:26 ` Michel Lespinasse
2013-02-06 2:26 ` Michel Lespinasse
2013-02-06 10:41 ` Mel Gorman
2013-02-06 10:41 ` Mel Gorman
2013-02-18 10:34 ` Lin Feng
2013-02-18 10:34 ` Lin Feng
2013-02-18 10:34 ` Lin Feng
2013-02-18 15:17 ` Mel Gorman
2013-02-18 15:17 ` Mel Gorman
2013-02-18 15:17 ` Mel Gorman
2013-02-19 9:55 ` Lin Feng
2013-02-19 9:55 ` Lin Feng
2013-02-19 10:34 ` Mel Gorman
2013-02-19 10:34 ` Mel Gorman
2013-02-19 10:34 ` Mel Gorman
2013-02-04 10:04 ` [PATCH 2/2] fs/aio.c: use get_user_pages_non_movable() to pin ring pages when support memory hotremove Lin Feng
2013-02-04 10:04 ` Lin Feng
2013-02-04 10:04 ` Lin Feng
2013-02-04 15:18 ` Jeff Moyer
2013-02-04 15:18 ` Jeff Moyer
2013-02-04 15:18 ` Jeff Moyer
2013-02-04 23:02 ` Zach Brown
2013-02-04 23:02 ` Zach Brown
2013-02-04 23:02 ` Zach Brown
2013-02-05 5:35 ` Lin Feng
2013-02-05 5:35 ` Lin Feng
2013-02-05 5:35 ` Lin Feng
2013-02-05 5:06 ` Lin Feng
2013-02-05 5:06 ` Lin Feng
2013-02-05 0:58 ` [PATCH 0/2] mm: hotplug: implement non-movable version of get_user_pages() to kill long-time pin pages Minchan Kim
2013-02-05 0:58 ` Minchan Kim
2013-02-05 0:58 ` Minchan Kim
2013-02-05 4:42 ` Lin Feng
2013-02-05 4:42 ` Lin Feng
2013-02-05 5:25 ` Minchan Kim
2013-02-05 5:25 ` Minchan Kim
2013-02-05 5:25 ` Minchan Kim
2013-02-05 6:18 ` Lin Feng
2013-02-05 6:18 ` Lin Feng
2013-02-05 7:45 ` Minchan Kim
2013-02-05 7:45 ` Minchan Kim
2013-02-05 7:45 ` Minchan Kim
2013-02-05 8:27 ` Lin Feng
2013-02-05 8:27 ` Lin Feng
2013-02-05 8:27 ` Lin Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204161848.bfd36176.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=khlebnikov@openvz.org \
--cc=laijs@cn.fujitsu.com \
--cc=linfeng@cn.fujitsu.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.