From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] sunrpc: fix comment in struct xdr_buf definition
Date: Mon, 4 Feb 2013 13:12:46 -0500 [thread overview]
Message-ID: <20130204181246.GK815@fieldses.org> (raw)
In-Reply-To: <1360000277-12778-1-git-send-email-jlayton@redhat.com>
On Mon, Feb 04, 2013 at 12:51:17PM -0500, Jeff Layton wrote:
> ...these pages aren't necessarily contiguous.
I guess you could say it was correct if you took "contiguous" to mean
that the xdr data they hold is meant to be contiguous.
But, yeah, at best I can't see how that comment would help anyone.
Applying absent any objections.
--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> include/linux/sunrpc/xdr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
> index 6398899..224d060 100644
> --- a/include/linux/sunrpc/xdr.h
> +++ b/include/linux/sunrpc/xdr.h
> @@ -56,7 +56,7 @@ struct xdr_buf {
> struct kvec head[1], /* RPC header + non-page data */
> tail[1]; /* Appended after page data */
>
> - struct page ** pages; /* Array of contiguous pages */
> + struct page ** pages; /* Array of pages */
> unsigned int page_base, /* Start of page data */
> page_len, /* Length of page data */
> flags; /* Flags for data disposition */
> --
> 1.7.11.7
>
prev parent reply other threads:[~2013-02-04 18:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 17:51 [PATCH] sunrpc: fix comment in struct xdr_buf definition Jeff Layton
2013-02-04 18:12 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204181246.GK815@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.