* [PATCH] sunrpc: fix comment in struct xdr_buf definition
@ 2013-02-04 17:51 Jeff Layton
2013-02-04 18:12 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2013-02-04 17:51 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs
...these pages aren't necessarily contiguous.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
include/linux/sunrpc/xdr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
index 6398899..224d060 100644
--- a/include/linux/sunrpc/xdr.h
+++ b/include/linux/sunrpc/xdr.h
@@ -56,7 +56,7 @@ struct xdr_buf {
struct kvec head[1], /* RPC header + non-page data */
tail[1]; /* Appended after page data */
- struct page ** pages; /* Array of contiguous pages */
+ struct page ** pages; /* Array of pages */
unsigned int page_base, /* Start of page data */
page_len, /* Length of page data */
flags; /* Flags for data disposition */
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sunrpc: fix comment in struct xdr_buf definition
2013-02-04 17:51 [PATCH] sunrpc: fix comment in struct xdr_buf definition Jeff Layton
@ 2013-02-04 18:12 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2013-02-04 18:12 UTC (permalink / raw)
To: Jeff Layton; +Cc: linux-nfs
On Mon, Feb 04, 2013 at 12:51:17PM -0500, Jeff Layton wrote:
> ...these pages aren't necessarily contiguous.
I guess you could say it was correct if you took "contiguous" to mean
that the xdr data they hold is meant to be contiguous.
But, yeah, at best I can't see how that comment would help anyone.
Applying absent any objections.
--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> include/linux/sunrpc/xdr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sunrpc/xdr.h b/include/linux/sunrpc/xdr.h
> index 6398899..224d060 100644
> --- a/include/linux/sunrpc/xdr.h
> +++ b/include/linux/sunrpc/xdr.h
> @@ -56,7 +56,7 @@ struct xdr_buf {
> struct kvec head[1], /* RPC header + non-page data */
> tail[1]; /* Appended after page data */
>
> - struct page ** pages; /* Array of contiguous pages */
> + struct page ** pages; /* Array of pages */
> unsigned int page_base, /* Start of page data */
> page_len, /* Length of page data */
> flags; /* Flags for data disposition */
> --
> 1.7.11.7
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-04 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-04 17:51 [PATCH] sunrpc: fix comment in struct xdr_buf definition Jeff Layton
2013-02-04 18:12 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.