From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()
Date: Tue, 5 Feb 2013 10:36:14 -0500 [thread overview]
Message-ID: <20130205153614.GA1508@redhat.com> (raw)
In-Reply-To: <20130202231135.GB3940@mtj.dyndns.org>
On Sat, Feb 02, 2013 at 03:11:35PM -0800, Tejun Heo wrote:
> On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote:
> > Fix it by ensuring proceeding to the next slot doesn't carry over the
> > unaligned offset - ie. use round_up(id + 1, slot_distance) instead of
> > id += slot_distance.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Reported-by: David Teigland <teigland@redhat.com>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> David, can you please test whether the patch makes the skipped
> deletion bug go away?
Yes, I've tested, and it works fine now.
Thanks,
Dave
WARNING: multiple messages have this Message-ID (diff)
From: David Teigland <teigland@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org, rusty@rustcorp.com.au,
linux-kernel@vger.kernel.org,
Christine Caulfield <ccaulfie@redhat.com>,
cluster-devel@redhat.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] idr: fix a subtle bug in idr_get_next()
Date: Tue, 5 Feb 2013 10:36:14 -0500 [thread overview]
Message-ID: <20130205153614.GA1508@redhat.com> (raw)
In-Reply-To: <20130202231135.GB3940@mtj.dyndns.org>
On Sat, Feb 02, 2013 at 03:11:35PM -0800, Tejun Heo wrote:
> On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote:
> > Fix it by ensuring proceeding to the next slot doesn't carry over the
> > unaligned offset - ie. use round_up(id + 1, slot_distance) instead of
> > id += slot_distance.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Reported-by: David Teigland <teigland@redhat.com>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> David, can you please test whether the patch makes the skipped
> deletion bug go away?
Yes, I've tested, and it works fine now.
Thanks,
Dave
next prev parent reply other threads:[~2013-02-05 15:36 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 1:30 [PATCHSET] idr: deprecate idr_remove_all() Tejun Heo
2013-01-26 1:30 ` [PATCH 01/14] idr: make idr_destroy() imply idr_remove_all() Tejun Heo
2013-01-26 1:31 ` [PATCH 02/14] atm/nicstar: don't use idr_remove_all() Tejun Heo
2013-01-27 6:43 ` David Miller
2013-02-04 17:52 ` [PATCH v2 " Tejun Heo
2013-02-04 18:10 ` chas williams - CONTRACTOR
2013-02-04 18:35 ` Tejun Heo
2013-01-26 1:31 ` [PATCH 03/14] block/loop: " Tejun Heo
2013-01-26 1:31 ` [PATCH 04/14] firewire: " Tejun Heo
2013-01-26 9:07 ` Stefan Richter
2013-01-26 1:31 ` [PATCH 05/14] drm: " Tejun Heo
2013-01-26 1:31 ` Tejun Heo
2013-01-26 1:31 ` [PATCH 06/14] dm: " Tejun Heo
2013-01-26 1:31 ` [PATCH 07/14] remoteproc: " Tejun Heo
2013-01-26 1:31 ` [PATCH 08/14] rpmsg: " Tejun Heo
2013-01-26 1:31 ` [Cluster-devel] [PATCH 09/14] dlm: use idr_for_each_entry() in recover_idr_clear() error path Tejun Heo
2013-01-26 1:31 ` Tejun Heo
2013-01-28 15:55 ` [Cluster-devel] " David Teigland
2013-01-28 15:55 ` David Teigland
2013-01-26 1:31 ` [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all() Tejun Heo
2013-01-26 1:31 ` Tejun Heo
2013-01-28 15:57 ` [Cluster-devel] " David Teigland
2013-01-28 15:57 ` David Teigland
2013-01-29 15:13 ` [Cluster-devel] " David Teigland
2013-01-29 15:13 ` David Teigland
2013-01-30 21:24 ` [Cluster-devel] " David Teigland
2013-01-30 21:24 ` David Teigland
2013-01-31 23:53 ` [Cluster-devel] " Tejun Heo
2013-01-31 23:53 ` Tejun Heo
2013-02-01 0:18 ` [Cluster-devel] " Tejun Heo
2013-02-01 0:18 ` Tejun Heo
2013-02-01 17:44 ` [Cluster-devel] " David Teigland
2013-02-01 17:44 ` David Teigland
2013-02-01 18:00 ` [Cluster-devel] " Tejun Heo
2013-02-01 18:00 ` Tejun Heo
2013-02-02 23:10 ` [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next() Tejun Heo
2013-02-02 23:10 ` Tejun Heo
2013-02-02 23:11 ` [Cluster-devel] " Tejun Heo
2013-02-02 23:11 ` Tejun Heo
2013-02-03 2:15 ` [Cluster-devel] " Randy Dunlap
2013-02-03 2:15 ` Randy Dunlap
2013-02-03 17:53 ` [Cluster-devel] " Hugh Dickins
2013-02-03 17:53 ` Hugh Dickins
2013-02-05 15:36 ` David Teigland [this message]
2013-02-05 15:36 ` David Teigland
2013-02-04 3:39 ` [Cluster-devel] " Li Zefan
2013-02-04 3:39 ` Li Zefan
2013-02-04 17:44 ` [Cluster-devel] " Tejun Heo
2013-02-04 17:44 ` Tejun Heo
2013-01-26 1:31 ` [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all() Tejun Heo
2013-01-29 22:58 ` J. Bruce Fields
2013-01-30 2:18 ` Myklebust, Trond
2013-02-01 0:08 ` Tejun Heo
2013-01-26 1:31 ` [PATCH 12/14] inotify: don't use idr_remove_all() Tejun Heo
[not found] ` <1359163872-1949-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-01-26 1:31 ` [PATCH 13/14] cgroup: " Tejun Heo
2013-01-26 1:31 ` Tejun Heo
2013-01-26 1:31 ` [PATCH 14/14] idr: deprecate idr_remove_all() Tejun Heo
2013-01-26 13:48 ` Arnd Bergmann
2013-01-26 14:24 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205153614.GA1508@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.