From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 1/3] memcg: move mem_cgroup_soft_limit_tree_init to mem_cgroup_init
Date: Tue, 5 Feb 2013 13:01:16 -0500 [thread overview]
Message-ID: <20130205180116.GA993@cmpxchg.org> (raw)
In-Reply-To: <1360081441-1960-2-git-send-email-mhocko@suse.cz>
On Tue, Feb 05, 2013 at 05:23:59PM +0100, Michal Hocko wrote:
> Per-node-zone soft limit tree is currently initialized when the root
> cgroup is created which is OK but it pointlessly pollutes memcg
> allocation code with something that can be called when the memcg
> subsystem is initialized by mem_cgroup_init along with other controller
> specific parts.
>
> While we are at it let's make mem_cgroup_soft_limit_tree_init void
> because it doesn't make much sense to report memory failure because if
> we fail to allocate memory that early during the boot then we are
> screwed anyway (this saves some code).
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH 1/3] memcg: move mem_cgroup_soft_limit_tree_init to mem_cgroup_init
Date: Tue, 5 Feb 2013 13:01:16 -0500 [thread overview]
Message-ID: <20130205180116.GA993@cmpxchg.org> (raw)
In-Reply-To: <1360081441-1960-2-git-send-email-mhocko@suse.cz>
On Tue, Feb 05, 2013 at 05:23:59PM +0100, Michal Hocko wrote:
> Per-node-zone soft limit tree is currently initialized when the root
> cgroup is created which is OK but it pointlessly pollutes memcg
> allocation code with something that can be called when the memcg
> subsystem is initialized by mem_cgroup_init along with other controller
> specific parts.
>
> While we are at it let's make mem_cgroup_soft_limit_tree_init void
> because it doesn't make much sense to report memory failure because if
> we fail to allocate memory that early during the boot then we are
> screwed anyway (this saves some code).
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2013-02-05 18:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 16:23 [PATCH 0/3] cleanup memcg controller initialization Michal Hocko
2013-02-05 16:23 ` Michal Hocko
2013-02-05 16:23 ` [PATCH 1/3] memcg: move mem_cgroup_soft_limit_tree_init to mem_cgroup_init Michal Hocko
2013-02-05 16:23 ` Michal Hocko
2013-02-05 18:01 ` Johannes Weiner [this message]
2013-02-05 18:01 ` Johannes Weiner
2013-02-05 16:24 ` [PATCH 2/3] memcg: move memcg_stock initialization " Michal Hocko
2013-02-05 16:24 ` Michal Hocko
2013-02-05 18:13 ` Johannes Weiner
2013-02-05 18:13 ` Johannes Weiner
2013-02-05 16:24 ` [PATCH 3/3] memcg: cleanup mem_cgroup_init comment Michal Hocko
2013-02-05 16:24 ` Michal Hocko
2013-02-05 18:16 ` Johannes Weiner
2013-02-05 18:16 ` Johannes Weiner
2013-02-05 16:59 ` [PATCH 0/3] cleanup memcg controller initialization Tejun Heo
2013-02-05 16:59 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205180116.GA993@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.