From: Johannes Weiner <hannes@cmpxchg.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: shmem: use new radix tree iterator
Date: Tue, 5 Feb 2013 13:23:01 -0500 [thread overview]
Message-ID: <20130205182301.GD993@cmpxchg.org> (raw)
In-Reply-To: <510CCD88.30200@openvz.org>
On Sat, Feb 02, 2013 at 12:25:44PM +0400, Konstantin Khlebnikov wrote:
> Johannes Weiner wrote:
> >In shmem_find_get_pages_and_swap, use the faster radix tree iterator
> >construct from 78c1d78 "radix-tree: introduce bit-optimized iterator".
> >
> >Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
>
> Hmm, ACK. shmem_unuse_inode() also can be redone in this way.
> I did something similar year ago: https://lkml.org/lkml/2012/2/10/388
> As result we can rid of radix_tree_locate_item() and shmem_find_get_pages_and_swap()
I remember your patches and am working on a totally unrelated series
that also gets rid of shmem_find_get_pages_and_swap(). Either way,
this thing's going down, so just I didn't bother with the conversion.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] mm: shmem: use new radix tree iterator
Date: Tue, 5 Feb 2013 13:23:01 -0500 [thread overview]
Message-ID: <20130205182301.GD993@cmpxchg.org> (raw)
In-Reply-To: <510CCD88.30200@openvz.org>
On Sat, Feb 02, 2013 at 12:25:44PM +0400, Konstantin Khlebnikov wrote:
> Johannes Weiner wrote:
> >In shmem_find_get_pages_and_swap, use the faster radix tree iterator
> >construct from 78c1d78 "radix-tree: introduce bit-optimized iterator".
> >
> >Signed-off-by: Johannes Weiner<hannes@cmpxchg.org>
>
> Hmm, ACK. shmem_unuse_inode() also can be redone in this way.
> I did something similar year ago: https://lkml.org/lkml/2012/2/10/388
> As result we can rid of radix_tree_locate_item() and shmem_find_get_pages_and_swap()
I remember your patches and am working on a totally unrelated series
that also gets rid of shmem_find_get_pages_and_swap(). Either way,
this thing's going down, so just I didn't bother with the conversion.
next prev parent reply other threads:[~2013-02-05 18:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 6:13 [patch] mm: shmem: use new radix tree iterator Johannes Weiner
2013-02-01 6:13 ` Johannes Weiner
2013-02-02 8:25 ` Konstantin Khlebnikov
2013-02-02 8:25 ` Konstantin Khlebnikov
2013-02-04 3:32 ` Hugh Dickins
2013-02-04 3:32 ` Hugh Dickins
2013-02-04 13:29 ` Konstantin Khlebnikov
2013-02-04 13:29 ` Konstantin Khlebnikov
2013-02-05 18:23 ` Johannes Weiner [this message]
2013-02-05 18:23 ` Johannes Weiner
2013-02-04 2:01 ` Hugh Dickins
2013-02-04 2:01 ` Hugh Dickins
2013-02-20 12:16 ` Ric Mason
2013-02-20 12:16 ` Ric Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205182301.GD993@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.