All of lore.kernel.org
 help / color / mirror / Atom feed
From: majianpeng <majianpeng@gmail.com>
To: "Jens Axboe" <axboe@kernel.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Re: For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF.
Date: Tue, 5 Feb 2013 23:39:44 +0800	[thread overview]
Message-ID: <201302052339385271010@gmail.com> (raw)
In-Reply-To: 20130205132117.GU15092@kernel.dk

>On Sun, Feb 03 2013, majianpeng wrote:
>> Hi all,
>> 	When I wanted to do discard operations,but i set the  openflag was O_RDONLY,it returned a EBADF rather than EACCES or EPERM.
>> I searched the code and found:
>> >case BLKDISCARD:
>> >case BLKSECDISCARD: {
>> >		uint64_t range[2];
>> 
>> >		if (!(mode & FMODE_WRITE))
>> >			return -EBADF;
>> Initial i thought there was error.But i searched all code of kernel and found some places like this.
>> 
>> The description of EBADF is "Bad file numbe". There are some places where returned EBADF like,
>> >if (!f.file)
>> >		return -EBADF;
>> 
>> So i think for checking file->f_mode when failed, it should return EACCESS.
>
>But that would break the ABI at this point. I agree with you, though,
>EBADF is not the right error for this case.
>
>-- 
>Jens Axboe
>
Sorry, can you explain in detail? Why can it break the ABI ?

Thanks!
Jianpeng Ma

WARNING: multiple messages have this Message-ID (diff)
From: majianpeng <majianpeng@gmail.com>
To: "Jens Axboe" <axboe@kernel.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Re: For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF.
Date: Tue, 5 Feb 2013 23:39:44 +0800	[thread overview]
Message-ID: <201302052339385271010@gmail.com> (raw)
In-Reply-To: 20130205132117.GU15092@kernel.dk

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1052 bytes --]

>On Sun, Feb 03 2013, majianpeng wrote:
>> Hi all,
>> 	When I wanted to do discard operations,but i set the  openflag was O_RDONLY,it returned a EBADF rather than EACCES or EPERM.
>> I searched the code and found:
>> >case BLKDISCARD:
>> >case BLKSECDISCARD: {
>> >		uint64_t range[2];
>> 
>> >		if (!(mode & FMODE_WRITE))
>> >			return -EBADF;
>> Initial i thought there was error.But i searched all code of kernel and found some places like this.
>> 
>> The description of EBADF is "Bad file numbe". There are some places where returned EBADF like,
>> >if (!f.file)
>> >		return -EBADF;
>> 
>> So i think for checking file->f_mode when failed, it should return EACCESS.
>
>But that would break the ABI at this point. I agree with you, though,
>EBADF is not the right error for this case.
>
>-- 
>Jens Axboe
>
Sorry, can you explain in detail? Why can it break the ABI ?

Thanks!
Jianpeng Maÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2013-02-05 15:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04  2:07 For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF majianpeng
2013-02-04  2:07 ` majianpeng
2013-02-05 13:21 ` Jens Axboe
2013-02-05 15:39   ` majianpeng [this message]
2013-02-05 15:39     ` majianpeng
2013-02-05 20:19     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302052339385271010@gmail.com \
    --to=majianpeng@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.