From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
fengguang.wu@intel.com, Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFC][PATCH] PAGE_OWNER now depends on STACKTRACE_SUPPORT
Date: Wed, 06 Feb 2013 09:47:48 -0800 [thread overview]
Message-ID: <20130206174748.467A1FFD@kernel.stglabs.ibm.com> (raw)
One of the enhancements I made to the PAGE_OWNER code was to make
it use the generic stack trace support. However, there are some
architectures that do not support it, like m68k. So, make
PAGE_OWNER also depend on having STACKTRACE_SUPPORT.
This isn't ideal since it restricts the number of places
PAGE_OWNER runs now, but it at least hits all the major
architectures.
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 83b324c5ff5cca85bbeb2ba913d465f108afe472
commit: 2a561c9d47c295ed91984c2b916a4dd450ee0279 [484/499] debugging-keep-track-of-page-owners-fix
config: make ARCH=m68k allmodconfig
All warnings:
warning: (PAGE_OWNER && STACK_TRACER && BLK_DEV_IO_TRACE && KMEMCHECK) selects STACKTRACE which has unmet direct dependencies (STACKTRACE_SUPPORT)
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT lib/Kconfig.debug
--- linux-2.6.git/lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT 2013-02-06 09:44:01.372619511 -0800
+++ linux-2.6.git-dave/lib/Kconfig.debug 2013-02-06 09:44:10.648711604 -0800
@@ -101,7 +101,7 @@ config UNUSED_SYMBOLS
config PAGE_OWNER
bool "Track page owner"
- depends on DEBUG_KERNEL
+ depends on DEBUG_KERNEL && STACKTRACE_SUPPORT
select DEBUG_FS
select STACKTRACE
help
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
fengguang.wu@intel.com, Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFC][PATCH] PAGE_OWNER now depends on STACKTRACE_SUPPORT
Date: Wed, 06 Feb 2013 09:47:48 -0800 [thread overview]
Message-ID: <20130206174748.467A1FFD@kernel.stglabs.ibm.com> (raw)
One of the enhancements I made to the PAGE_OWNER code was to make
it use the generic stack trace support. However, there are some
architectures that do not support it, like m68k. So, make
PAGE_OWNER also depend on having STACKTRACE_SUPPORT.
This isn't ideal since it restricts the number of places
PAGE_OWNER runs now, but it at least hits all the major
architectures.
tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 83b324c5ff5cca85bbeb2ba913d465f108afe472
commit: 2a561c9d47c295ed91984c2b916a4dd450ee0279 [484/499] debugging-keep-track-of-page-owners-fix
config: make ARCH=m68k allmodconfig
All warnings:
warning: (PAGE_OWNER && STACK_TRACER && BLK_DEV_IO_TRACE && KMEMCHECK) selects STACKTRACE which has unmet direct dependencies (STACKTRACE_SUPPORT)
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---
linux-2.6.git-dave/lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT lib/Kconfig.debug
--- linux-2.6.git/lib/Kconfig.debug~now-depends-on-STACKTRACE_SUPPORT 2013-02-06 09:44:01.372619511 -0800
+++ linux-2.6.git-dave/lib/Kconfig.debug 2013-02-06 09:44:10.648711604 -0800
@@ -101,7 +101,7 @@ config UNUSED_SYMBOLS
config PAGE_OWNER
bool "Track page owner"
- depends on DEBUG_KERNEL
+ depends on DEBUG_KERNEL && STACKTRACE_SUPPORT
select DEBUG_FS
select STACKTRACE
help
_
next reply other threads:[~2013-02-06 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 17:47 Dave Hansen [this message]
2013-02-06 17:47 ` [RFC][PATCH] PAGE_OWNER now depends on STACKTRACE_SUPPORT Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206174748.467A1FFD@kernel.stglabs.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.