From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] macb: register the phy after the macb is init
Date: Wed, 6 Feb 2013 20:35:40 +0100 [thread overview]
Message-ID: <20130206193540.GL1906@pengutronix.de> (raw)
In-Reply-To: <1360059306-31118-2-git-send-email-plagnioj@jcrosoft.com>
On Tue, Feb 05, 2013 at 11:15:04AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> drivers/net/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 15b1e93..8eac4a8 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -476,8 +476,8 @@ static int macb_probe(struct device_d *dev)
>
> macb_writel(macb, NCFGR, ncfgr);
>
> - mdiobus_register(&macb->miibus);
> eth_register(edev);
> + mdiobus_register(&macb->miibus);
Why?
Most other drivers do it the other way round and you do not provide
information why this is done.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-06 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 10:12 [PATCH 0/4] macb: more fixes Jean-Christophe PLAGNIOL-VILLARD
2013-02-05 10:15 ` [PATCH 1/4] macb: use dev_xx message Jean-Christophe PLAGNIOL-VILLARD
2013-02-05 10:15 ` [PATCH 2/4] macb: register the phy after the macb is init Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 19:35 ` Sascha Hauer [this message]
2013-02-06 19:37 ` Sascha Hauer
2013-02-06 20:16 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 20:32 ` Sascha Hauer
2013-02-06 20:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 20:39 ` Sascha Hauer
2013-02-05 10:15 ` [PATCH 3/4] macb: report timeout on send Jean-Christophe PLAGNIOL-VILLARD
2013-02-05 10:15 ` [PATCH 4/4] macb: drop non used define Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 8:36 ` [PATCH 1/4] macb: use dev_xx message Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206193540.GL1906@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.