Re: [PATCH 2/4] macb: register the phy after the macb is init - Jean-Christophe PLAGNIOL-VILLARD

From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] macb: register the phy after the macb is init
Date: Wed, 6 Feb 2013 21:34:28 +0100	[thread overview]
Message-ID: <20130206203428.GI19322@game.jcrosoft.org> (raw)
In-Reply-To: <20130206203253.GO1906@pengutronix.de>

On 21:32 Wed 06 Feb     , Sascha Hauer wrote:
> On Wed, Feb 06, 2013 at 09:16:24PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 20:35 Wed 06 Feb     , Sascha Hauer wrote:
> > > On Tue, Feb 05, 2013 at 11:15:04AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > >  drivers/net/macb.c |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> > > > index 15b1e93..8eac4a8 100644
> > > > --- a/drivers/net/macb.c
> > > > +++ b/drivers/net/macb.c
> > > > @@ -476,8 +476,8 @@ static int macb_probe(struct device_d *dev)
> > > >  
> > > >  	macb_writel(macb, NCFGR, ncfgr);
> > > >  
> > > > -	mdiobus_register(&macb->miibus);
> > > >  	eth_register(edev);
> > > > +	mdiobus_register(&macb->miibus);
> > > 
> > > Why?
> > > 
> > > Most other drivers do it the other way round and you do not provide
> > > information why this is done.
> > because the is not ready
> > 
> > as we init it as _init which is done during the eth_register
> 
> Then you should probably call macb_init from your probe function
> manually. This implicit dependency is not good.

so init callback is for what?

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox