From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Improve CLKSRC_OF matching
Date: Thu, 7 Feb 2013 23:45:52 +0000 [thread overview]
Message-ID: <201302072345.52195.arnd@arndb.de> (raw)
In-Reply-To: <51143A87.4040205@gmail.com>
On Thursday 07 February 2013, Rob Herring wrote:
> How so? I don't see a warning as there is no type checking on the init
> function since of_device_id.data is just a void *. It would be good to
> have type checking here if you know a way, but I don't.
Ah, that's right. So it silently builds find even though the
prototypes don't match, and given the C calling conventions
it even ends up working correctly, it just feels wrong.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Rob Herring <robherring2@gmail.com>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 0/4] Improve CLKSRC_OF matching
Date: Thu, 7 Feb 2013 23:45:52 +0000 [thread overview]
Message-ID: <201302072345.52195.arnd@arndb.de> (raw)
In-Reply-To: <51143A87.4040205@gmail.com>
On Thursday 07 February 2013, Rob Herring wrote:
> How so? I don't see a warning as there is no type checking on the init
> function since of_device_id.data is just a void *. It would be good to
> have type checking here if you know a way, but I don't.
Ah, that's right. So it silently builds find even though the
prototypes don't match, and given the C calling conventions
it even ends up working correctly, it just feels wrong.
Arnd
next prev parent reply other threads:[~2013-02-07 23:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 19:09 [PATCH 0/4] Improve CLKSRC_OF matching Rob Herring
2013-02-07 19:09 ` Rob Herring
2013-02-07 19:09 ` [PATCH 1/4] clocksource: pass DT node pointer to init functions Rob Herring
2013-02-07 19:09 ` Rob Herring
2013-02-13 16:21 ` Michal Simek
2013-02-13 16:21 ` Michal Simek
2013-02-13 16:33 ` Rob Herring
2013-02-13 16:33 ` Rob Herring
2013-02-13 17:33 ` Michal Simek
2013-02-13 17:33 ` Michal Simek
2013-02-14 1:30 ` Rob Herring
2013-02-14 1:30 ` Rob Herring
2013-02-14 6:45 ` Michal Simek
2013-02-14 6:45 ` Michal Simek
2013-02-14 14:22 ` Rob Herring
2013-02-14 14:22 ` Rob Herring
2013-02-07 19:09 ` [PATCH 2/4] clocksource: bcm2835: use the device_node pointer passed to init Rob Herring
2013-02-07 19:09 ` Rob Herring
2013-02-09 3:47 ` Stephen Warren
2013-02-09 3:47 ` Stephen Warren
2013-02-07 19:09 ` [PATCH 3/4] clocksource: vt8500: " Rob Herring
2013-02-07 19:09 ` Rob Herring
2013-02-07 19:09 ` [PATCH 4/4] clocksource: tegra20: " Rob Herring
2013-02-07 19:09 ` Rob Herring
2013-02-07 19:39 ` Stephen Warren
2013-02-07 19:39 ` Stephen Warren
2013-02-07 20:05 ` Hiroshi Doyu
2013-02-07 20:05 ` Hiroshi Doyu
2013-02-07 22:44 ` [PATCH 0/4] Improve CLKSRC_OF matching Arnd Bergmann
2013-02-07 22:44 ` Arnd Bergmann
2013-02-07 23:36 ` Rob Herring
2013-02-07 23:36 ` Rob Herring
2013-02-07 23:45 ` Arnd Bergmann [this message]
2013-02-07 23:45 ` Arnd Bergmann
2013-02-08 4:51 ` Tony Prisk
2013-02-08 4:51 ` Tony Prisk
2013-02-08 13:07 ` Rob Herring
2013-02-08 13:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302072345.52195.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.