* [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.
@ 2013-02-08 8:40 Hans Verkuil
2013-02-09 0:33 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2013-02-08 8:40 UTC (permalink / raw)
To: linux-media; +Cc: Mauro Carvalho Chehab, Andy Walls
Mauro,
Please fast-track this for 3.8. Yesterday I discovered that commits made earlier
for 3.8 kill ivtv and cx18 (as in: unable to boot, instant crash) since a
function was made __init that was actually called *after* initialization.
We are already at rc6 and this *must* make it for 3.8. Without this patch
anyone with a cx18/ivtv will crash immediately as soon as they upgrade to 3.8.
Regards,
Hans
The following changes since commit 248ac368ce4b3cd36515122d888403909d7a2500:
[media] s5p-fimc: Fix fimc-lite entities deregistration (2013-02-06 09:42:19 -0200)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git ivtv
for you to fetch changes up to ddf276062e68607323fca363b99bdf426dddad9b:
cx18/ivtv: fix regression: remove __init from a non-init function. (2013-02-08 09:30:11 +0100)
----------------------------------------------------------------
Hans Verkuil (1):
cx18/ivtv: fix regression: remove __init from a non-init function.
drivers/media/pci/cx18/cx18-alsa-main.c | 2 +-
drivers/media/pci/ivtv/ivtv-alsa-main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.
2013-02-08 8:40 [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function Hans Verkuil
@ 2013-02-09 0:33 ` Mauro Carvalho Chehab
2013-02-09 8:45 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2013-02-09 0:33 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, Andy Walls
Em Fri, 8 Feb 2013 09:40:27 +0100
Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> Mauro,
>
> Please fast-track this for 3.8. Yesterday I discovered that commits made earlier
> for 3.8 kill ivtv and cx18 (as in: unable to boot, instant crash) since a
> function was made __init that was actually called *after* initialization.
>
> We are already at rc6 and this *must* make it for 3.8. Without this patch
> anyone with a cx18/ivtv will crash immediately as soon as they upgrade to 3.8.
>
> Regards,
>
> Hans
>
> The following changes since commit 248ac368ce4b3cd36515122d888403909d7a2500:
>
> [media] s5p-fimc: Fix fimc-lite entities deregistration (2013-02-06 09:42:19 -0200)
>
> are available in the git repository at:
>
> git://linuxtv.org/hverkuil/media_tree.git ivtv
>
> for you to fetch changes up to ddf276062e68607323fca363b99bdf426dddad9b:
>
> cx18/ivtv: fix regression: remove __init from a non-init function. (2013-02-08 09:30:11 +0100)
>
> ----------------------------------------------------------------
> Hans Verkuil (1):
> cx18/ivtv: fix regression: remove __init from a non-init function.
Hmm... the patch seems to be broken/incomplete:
WARNING: drivers/media/pci/cx18/cx18-alsa.o(.text+0x449): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
The function cx18_alsa_load() references
the function __init snd_cx18_pcm_create().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_pcm_create is wrong.
WARNING: drivers/media/pci/cx18/built-in.o(.text+0x1be69): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
The function cx18_alsa_load() references
the function __init snd_cx18_pcm_create().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_pcm_create is wrong.
WARNING: drivers/media/pci/ivtv/ivtv-alsa.o(.text+0x454): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
The function ivtv_alsa_load() references
the function __init snd_ivtv_pcm_create().
This is often because ivtv_alsa_load lacks a __init
annotation or the annotation of snd_ivtv_pcm_create is wrong.
WARNING: drivers/media/pci/ivtv/built-in.o(.text+0x20790): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
The function ivtv_alsa_load() references
the function __init snd_ivtv_pcm_create().
This is often because ivtv_alsa_load lacks a __init
annotation or the annotation of snd_ivtv_pcm_create is wrong.
WARNING: drivers/media/pci/built-in.o(.text+0x6b958): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
The function ivtv_alsa_load() references
the function __init snd_ivtv_pcm_create().
This is often because ivtv_alsa_load lacks a __init
annotation or the annotation of snd_ivtv_pcm_create is wrong.
WARNING: drivers/media/pci/built-in.o(.text+0x9fc21): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
The function cx18_alsa_load() references
the function __init snd_cx18_pcm_create().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_pcm_create is wrong.
WARNING: drivers/media/built-in.o(.text+0x289f48): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
The function ivtv_alsa_load() references
the function __init snd_ivtv_pcm_create().
This is often because ivtv_alsa_load lacks a __init
annotation or the annotation of snd_ivtv_pcm_create is wrong.
WARNING: drivers/media/built-in.o(.text+0x2be211): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
The function cx18_alsa_load() references
the function __init snd_cx18_pcm_create().
This is often because cx18_alsa_load lacks a __init
annotation or the annotation of snd_cx18_pcm_create is wrong.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.
2013-02-09 0:33 ` Mauro Carvalho Chehab
@ 2013-02-09 8:45 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2013-02-09 8:45 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, Andy Walls
On Sat February 9 2013 01:33:44 Mauro Carvalho Chehab wrote:
> Em Fri, 8 Feb 2013 09:40:27 +0100
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>
> > Mauro,
> >
> > Please fast-track this for 3.8. Yesterday I discovered that commits made earlier
> > for 3.8 kill ivtv and cx18 (as in: unable to boot, instant crash) since a
> > function was made __init that was actually called *after* initialization.
> >
> > We are already at rc6 and this *must* make it for 3.8. Without this patch
> > anyone with a cx18/ivtv will crash immediately as soon as they upgrade to 3.8.
> >
> > Regards,
> >
> > Hans
> >
> > The following changes since commit 248ac368ce4b3cd36515122d888403909d7a2500:
> >
> > [media] s5p-fimc: Fix fimc-lite entities deregistration (2013-02-06 09:42:19 -0200)
> >
> > are available in the git repository at:
> >
> > git://linuxtv.org/hverkuil/media_tree.git ivtv
> >
> > for you to fetch changes up to ddf276062e68607323fca363b99bdf426dddad9b:
> >
> > cx18/ivtv: fix regression: remove __init from a non-init function. (2013-02-08 09:30:11 +0100)
> >
> > ----------------------------------------------------------------
> > Hans Verkuil (1):
> > cx18/ivtv: fix regression: remove __init from a non-init function.
>
> Hmm... the patch seems to be broken/incomplete:
It turned out that the cx18/ivtv-alsa-pcm.h header had an __init annotation,
although the corresponding function in the c source didn't. And
CONFIG_DEBUG_SECTION_MISMATCH was turned off, so I didn't see the full warning
message (now corrected). The fact that __init wasn't present in the C source
is the reason why the fix worked.
I'll post a new pull request fixing the headers as well.
Regards,
Hans
>
>
> WARNING: drivers/media/pci/cx18/cx18-alsa.o(.text+0x449): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
> The function cx18_alsa_load() references
> the function __init snd_cx18_pcm_create().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_pcm_create is wrong.
>
> WARNING: drivers/media/pci/cx18/built-in.o(.text+0x1be69): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
> The function cx18_alsa_load() references
> the function __init snd_cx18_pcm_create().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_pcm_create is wrong.
>
> WARNING: drivers/media/pci/ivtv/ivtv-alsa.o(.text+0x454): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
> The function ivtv_alsa_load() references
> the function __init snd_ivtv_pcm_create().
> This is often because ivtv_alsa_load lacks a __init
> annotation or the annotation of snd_ivtv_pcm_create is wrong.
>
> WARNING: drivers/media/pci/ivtv/built-in.o(.text+0x20790): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
> The function ivtv_alsa_load() references
> the function __init snd_ivtv_pcm_create().
> This is often because ivtv_alsa_load lacks a __init
> annotation or the annotation of snd_ivtv_pcm_create is wrong.
>
> WARNING: drivers/media/pci/built-in.o(.text+0x6b958): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
> The function ivtv_alsa_load() references
> the function __init snd_ivtv_pcm_create().
> This is often because ivtv_alsa_load lacks a __init
> annotation or the annotation of snd_ivtv_pcm_create is wrong.
>
> WARNING: drivers/media/pci/built-in.o(.text+0x9fc21): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
> The function cx18_alsa_load() references
> the function __init snd_cx18_pcm_create().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_pcm_create is wrong.
>
> WARNING: drivers/media/built-in.o(.text+0x289f48): Section mismatch in reference from the function ivtv_alsa_load() to the function .init.text:snd_ivtv_pcm_create()
> The function ivtv_alsa_load() references
> the function __init snd_ivtv_pcm_create().
> This is often because ivtv_alsa_load lacks a __init
> annotation or the annotation of snd_ivtv_pcm_create is wrong.
>
> WARNING: drivers/media/built-in.o(.text+0x2be211): Section mismatch in reference from the function cx18_alsa_load() to the function .init.text:snd_cx18_pcm_create()
> The function cx18_alsa_load() references
> the function __init snd_cx18_pcm_create().
> This is often because cx18_alsa_load lacks a __init
> annotation or the annotation of snd_cx18_pcm_create is wrong.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function.
@ 2013-02-09 8:49 Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2013-02-09 8:49 UTC (permalink / raw)
To: linux-media; +Cc: Andy Walls
Mauro,
Please fast-track this for 3.8. Two days ago I discovered that commits made
earlier for 3.8 kill ivtv and cx18 (as in: unable to boot, instant crash) since
a function was made __init that was actually called after initialization.
We are already at rc7 and this should make it for 3.8 if at all possible.
Without this patch anyone with a cx18/ivtv will crash immediately as soon
as they upgrade to 3.8.
This second version of the pull request also corrects two headers where __init
was present for the snd_cx18/ivtv_pcm_create function. The function in the C
source didn't have that annotation, so the first version of my fix worked fine,
it just generated false warnings which are now fixed as well.
Regards,
Hans
The following changes since commit 4880f56438ef56457edd5548b257382761591998:
[media] stv0900: remove unnecessary null pointer check (2013-02-08 18:05:48 -0200)
are available in the git repository at:
git://linuxtv.org/hverkuil/media_tree.git ivtv2
for you to fetch changes up to 6a2f1a23e007690d498f7a904bc9fc408f0afc5f:
cx18/ivtv: fix regression: remove __init from a non-init function. (2013-02-09 09:40:10 +0100)
----------------------------------------------------------------
Hans Verkuil (1):
cx18/ivtv: fix regression: remove __init from a non-init function.
drivers/media/pci/cx18/cx18-alsa-main.c | 2 +-
drivers/media/pci/cx18/cx18-alsa-pcm.h | 2 +-
drivers/media/pci/ivtv/ivtv-alsa-main.c | 2 +-
drivers/media/pci/ivtv/ivtv-alsa-pcm.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-09 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-08 8:40 [GIT PULL FOR v3.8] Regression fix: cx18/ivtv: remove __init from a non-init function Hans Verkuil
2013-02-09 0:33 ` Mauro Carvalho Chehab
2013-02-09 8:45 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2013-02-09 8:49 Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.