From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hpa@zytor.com,
mingo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/2] add helper for highmem checks
Date: Sat, 9 Feb 2013 11:47:52 +0100 [thread overview]
Message-ID: <20130209104751.GC17728@pd.tnic> (raw)
In-Reply-To: <20130209094121.GB17728@pd.tnic>
On Sat, Feb 09, 2013 at 10:41:21AM +0100, Borislav Petkov wrote:
> > +static inline bool phys_addr_is_highmem(phys_addr_t addr)
> > +{
> > + return addr > last_lowmem_paddr();
>
> I think you mean last_lowmem_phys_addr() here:
>
> include/linux/mm.h: In function a??phys_addr_is_highmema??:
> include/linux/mm.h:1764:2: error: implicit declaration of function a??last_lowmem_paddra?? [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
>
> Changed.
With this change, they definitely fix something because I even get X on
the box started. Previously, it would spit out the warning and wouldn't
start X with the login window. And my suspicion is that wdm (WINGs
display manager) I'm using, does /dev/mem accesses when it starts and it
obviously failed. Now not so much :-)
Tested-by: Borislav Petkov <bp@suse.de>
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hpa@zytor.com,
mingo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 1/2] add helper for highmem checks
Date: Sat, 9 Feb 2013 11:47:52 +0100 [thread overview]
Message-ID: <20130209104751.GC17728@pd.tnic> (raw)
In-Reply-To: <20130209094121.GB17728@pd.tnic>
On Sat, Feb 09, 2013 at 10:41:21AM +0100, Borislav Petkov wrote:
> > +static inline bool phys_addr_is_highmem(phys_addr_t addr)
> > +{
> > + return addr > last_lowmem_paddr();
>
> I think you mean last_lowmem_phys_addr() here:
>
> include/linux/mm.h: In function ‘phys_addr_is_highmem’:
> include/linux/mm.h:1764:2: error: implicit declaration of function ‘last_lowmem_paddr’ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1
>
> Changed.
With this change, they definitely fix something because I even get X on
the box started. Previously, it would spit out the warning and wouldn't
start X with the login window. And my suspicion is that wdm (WINGs
display manager) I'm using, does /dev/mem accesses when it starts and it
obviously failed. Now not so much :-)
Tested-by: Borislav Petkov <bp@suse.de>
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-09 10:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 20:28 [PATCH 1/2] add helper for highmem checks Dave Hansen
2013-02-08 20:28 ` Dave Hansen
2013-02-08 20:28 ` [PATCH 2/2] make /dev/kmem return error for highmem Dave Hansen
2013-02-08 20:28 ` Dave Hansen
2013-02-08 20:48 ` H. Peter Anvin
2013-02-08 20:48 ` H. Peter Anvin
2013-02-08 20:50 ` [PATCH 1/2] add helper for highmem checks H. Peter Anvin
2013-02-08 20:50 ` H. Peter Anvin
2013-02-08 23:16 ` Dave Hansen
2013-02-08 23:16 ` Dave Hansen
2013-02-09 9:41 ` Borislav Petkov
2013-02-09 9:41 ` Borislav Petkov
2013-02-09 10:47 ` Borislav Petkov [this message]
2013-02-09 10:47 ` Borislav Petkov
2013-02-11 17:32 ` Dave Hansen
2013-02-11 17:32 ` Dave Hansen
2013-02-11 18:09 ` H. Peter Anvin
2013-02-11 18:09 ` H. Peter Anvin
2013-02-11 18:28 ` Borislav Petkov
2013-02-11 18:28 ` Borislav Petkov
2013-02-11 19:44 ` H. Peter Anvin
2013-02-11 19:44 ` H. Peter Anvin
2013-02-11 22:34 ` Borislav Petkov
2013-02-11 22:34 ` Borislav Petkov
2013-02-11 22:46 ` H. Peter Anvin
2013-02-11 22:46 ` H. Peter Anvin
2013-02-11 23:00 ` Borislav Petkov
2013-02-11 23:00 ` Borislav Petkov
2013-02-11 23:02 ` H. Peter Anvin
2013-02-11 23:02 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209104751.GC17728@pd.tnic \
--to=bp@alien8.de \
--cc=dave@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.