From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] gpio: vt8500: memory cleanup missing
Date: Sat, 09 Feb 2013 13:38:21 +0000 [thread overview]
Message-ID: <20130209133821.5FDC93E30EC@localhost> (raw)
In-Reply-To: <1358485102-6585-1-git-send-email-linux@prisktech.co.nz>
On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk <linux@prisktech.co.nz> wrote:
> This driver is missing a .remove callback, and the fail path on
> probe is incomplete.
>
> If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
> The driver is also ignoring the return value from this function so
> if a chip fails to register it completes as successful.
>
> Replaced pr_err with dev_err in vt8500_add_chips since the device is
> available.
>
> There is also no .remove callback defined so the function is added.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Applied, thanks.
g.
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: Tony Prisk <linux@prisktech.co.nz>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
vt8500-wm8505-linux-kernel@googlegroups.com,
Tony Prisk <linux@prisktech.co.nz>
Subject: Re: [PATCH v3] gpio: vt8500: memory cleanup missing
Date: Sat, 09 Feb 2013 13:38:21 +0000 [thread overview]
Message-ID: <20130209133821.5FDC93E30EC@localhost> (raw)
In-Reply-To: <1358485102-6585-1-git-send-email-linux@prisktech.co.nz>
On Fri, 18 Jan 2013 17:58:22 +1300, Tony Prisk <linux@prisktech.co.nz> wrote:
> This driver is missing a .remove callback, and the fail path on
> probe is incomplete.
>
> If an error occurs in vt8500_add_chips, gpio_base is not unmapped.
> The driver is also ignoring the return value from this function so
> if a chip fails to register it completes as successful.
>
> Replaced pr_err with dev_err in vt8500_add_chips since the device is
> available.
>
> There is also no .remove callback defined so the function is added.
>
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Applied, thanks.
g.
next prev parent reply other threads:[~2013-02-09 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 4:58 [PATCH v3] gpio: vt8500: memory cleanup missing Tony Prisk
2013-01-18 4:58 ` Tony Prisk
2013-02-09 13:38 ` Grant Likely [this message]
2013-02-09 13:38 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209133821.5FDC93E30EC@localhost \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.