From: Tony Lindgren <tony@atomide.com>
To: Ruslan Bilovol <ruslan.bilovol@ti.com>
Cc: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ARM: OMAP2+: Export SoC information to userspace
Date: Mon, 11 Feb 2013 09:56:53 -0800 [thread overview]
Message-ID: <20130211175653.GQ4801@atomide.com> (raw)
In-Reply-To: <1360191049-24017-3-git-send-email-ruslan.bilovol@ti.com>
* Ruslan Bilovol <ruslan.bilovol@ti.com> [130206 14:54]:
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -602,6 +602,7 @@ void __init omap4430_init_late(void)
> omap2_common_pm_late_init();
> omap4_pm_init();
> omap2_clk_enable_autoidle_all();
> + omap_soc_device_init();
> }
> #endif
Looks like this should be called for all omaps instead
of just omap4430?
I suggest you create omap_common_init_late() that
calls all the common init_late functions:
static void __init omap_common_init_late(void)
{
omap_mux_late_init();
omap2_common_pm_late_init();
omap_soc_device_init();
}
Needs to be verified that these really are common to
all omap2+ though :)
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: OMAP2+: Export SoC information to userspace
Date: Mon, 11 Feb 2013 09:56:53 -0800 [thread overview]
Message-ID: <20130211175653.GQ4801@atomide.com> (raw)
In-Reply-To: <1360191049-24017-3-git-send-email-ruslan.bilovol@ti.com>
* Ruslan Bilovol <ruslan.bilovol@ti.com> [130206 14:54]:
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -602,6 +602,7 @@ void __init omap4430_init_late(void)
> omap2_common_pm_late_init();
> omap4_pm_init();
> omap2_clk_enable_autoidle_all();
> + omap_soc_device_init();
> }
> #endif
Looks like this should be called for all omaps instead
of just omap4430?
I suggest you create omap_common_init_late() that
calls all the common init_late functions:
static void __init omap_common_init_late(void)
{
omap_mux_late_init();
omap2_common_pm_late_init();
omap_soc_device_init();
}
Needs to be verified that these really are common to
all omap2+ though :)
Regards,
Tony
next prev parent reply other threads:[~2013-02-11 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 22:50 [PATCH v3 0/2] ARM: OMAP2+: Export SoC information to userspace using SoC infrastructure Ruslan Bilovol
2013-02-06 22:50 ` Ruslan Bilovol
2013-02-06 22:50 ` [PATCH v3 1/2] ARM: OMAP2+: SoC name and revision unification Ruslan Bilovol
2013-02-06 22:50 ` Ruslan Bilovol
2013-02-06 22:50 ` [PATCH v3 2/2] ARM: OMAP2+: Export SoC information to userspace Ruslan Bilovol
2013-02-06 22:50 ` Ruslan Bilovol
2013-02-11 17:56 ` Tony Lindgren [this message]
2013-02-11 17:56 ` Tony Lindgren
2013-02-13 14:17 ` Ruslan Bilovol
2013-02-13 14:17 ` Ruslan Bilovol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211175653.GQ4801@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ruslan.bilovol@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.