From: Denys Dmytriyenko <denys@ti.com>
To: "Zhou, Jingting" <zhoujt@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: new image recipe
Date: Mon, 11 Feb 2013 15:29:02 -0500 [thread overview]
Message-ID: <20130211202902.GG11440@edge> (raw)
In-Reply-To: <3C08AEEB3C731745938BC83D029FE5E391813D@DFLE09.ent.ti.com>
On Mon, Feb 11, 2013 at 03:25:44PM -0500, Zhou, Jingting wrote:
> 1. I'll use another name
It's not the name. Why cannot you use the existing arago-headless-tisdk-image
recipe? Can you extend it instead of creating another one?
> 2. the white spaces are consistent in my computer......
Some lines use spaces and some use tabs, which is inconsistent - you may want
to configure your text editor to show you one vs. another visually.
--
Denys
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, February 11, 2013 3:08 PM
> To: Zhou, Jingting
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] new image recipe
>
> On Wed, Feb 06, 2013 at 09:18:15PM +0000, Zhou, Jingting wrote:
> > Hey all, attached is the recipe for a new image
> > arago-headless-tisdk-keystone2-image. Please take a look. Thanks~
>
> All the comments I made to your previous patch are still applicable here,
> plus:
>
> 1. Don't make tasks or images specific to a machine/SoC like that. First of
> all, you can avoid making it completely machine-specific and second, you may
> need to use overrides in the recipe itself for really specific things.
>
> 2. Please make sure the whitespaces are consistent.
prev parent reply other threads:[~2013-02-11 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 21:18 new image recipe Zhou, Jingting
2013-02-11 20:08 ` Denys Dmytriyenko
2013-02-11 20:25 ` Zhou, Jingting
2013-02-11 20:29 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211202902.GG11440@edge \
--to=denys@ti.com \
--cc=meta-arago@arago-project.org \
--cc=zhoujt@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.