* [PATCH] unmodified_drivers: __devinit was removed in linux-3.8
@ 2013-02-11 15:28 Olaf Hering
2013-02-12 10:00 ` Jan Beulich
2013-02-12 10:09 ` [PATCH v2] " Olaf Hering
0 siblings, 2 replies; 5+ messages in thread
From: Olaf Hering @ 2013-02-11 15:28 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1360595055 -3600
# Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7
# Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 2fdca30363f0 -r e80418f1f58b unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
--- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
+++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
@@ -24,6 +24,11 @@
#include <linux/pci.h>
+#ifndef __devinit
+#define __devinit
+#define __devinitdata
+#endif
+
unsigned long alloc_xen_mmio(unsigned long len);
void platform_pci_resume(void);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] unmodified_drivers: __devinit was removed in linux-3.8
2013-02-11 15:28 [PATCH] unmodified_drivers: __devinit was removed in linux-3.8 Olaf Hering
@ 2013-02-12 10:00 ` Jan Beulich
2013-02-12 10:10 ` Olaf Hering
2013-02-12 10:09 ` [PATCH v2] " Olaf Hering
1 sibling, 1 reply; 5+ messages in thread
From: Jan Beulich @ 2013-02-12 10:00 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
>>> On 11.02.13 at 16:28, Olaf Hering <olaf@aepfle.de> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1360595055 -3600
> # Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7
> # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
> unmodified_drivers: __devinit was removed in linux-3.8
I recognize the need for dealing with this, but ...
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> diff -r 2fdca30363f0 -r e80418f1f58b
> unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
... this is the wrong file. See compat-include/xen/platform-compat.h
(including how it already deals with non-present __init).
Jan
> @@ -24,6 +24,11 @@
>
> #include <linux/pci.h>
>
> +#ifndef __devinit
> +#define __devinit
> +#define __devinitdata
> +#endif
> +
> unsigned long alloc_xen_mmio(unsigned long len);
> void platform_pci_resume(void);
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] unmodified_drivers: __devinit was removed in linux-3.8
2013-02-11 15:28 [PATCH] unmodified_drivers: __devinit was removed in linux-3.8 Olaf Hering
2013-02-12 10:00 ` Jan Beulich
@ 2013-02-12 10:09 ` Olaf Hering
2013-02-12 10:31 ` Jan Beulich
1 sibling, 1 reply; 5+ messages in thread
From: Olaf Hering @ 2013-02-12 10:09 UTC (permalink / raw)
To: xen-devel
# HG changeset patch
# User Olaf Hering <olaf@aepfle.de>
# Date 1360663714 -3600
# Node ID 37bca0abac676afdece18363ba3170027378659c
# Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
unmodified_drivers: __devinit was removed in linux-3.8
Signed-off-by: Olaf Hering <olaf@aepfle.de>
diff -r 2fdca30363f0 -r 37bca0abac67 unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
--- a/unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
+++ b/unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
@@ -171,4 +171,9 @@ typedef irqreturn_t (*irq_handler_t)(int
#define synch_test_bit sync_test_bit
#endif
+#ifndef __devinit
+#define __devinit
+#define __devinitdata
#endif
+
+#endif
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] unmodified_drivers: __devinit was removed in linux-3.8
2013-02-12 10:00 ` Jan Beulich
@ 2013-02-12 10:10 ` Olaf Hering
0 siblings, 0 replies; 5+ messages in thread
From: Olaf Hering @ 2013-02-12 10:10 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel
On Tue, Feb 12, Jan Beulich wrote:
> >>> On 11.02.13 at 16:28, Olaf Hering <olaf@aepfle.de> wrote:
> > # HG changeset patch
> > # User Olaf Hering <olaf@aepfle.de>
> > # Date 1360595055 -3600
> > # Node ID e80418f1f58bf36fe953af587cc0e6dbd52dffa7
> > # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
> > unmodified_drivers: __devinit was removed in linux-3.8
>
> I recognize the need for dealing with this, but ...
>
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
> >
> > diff -r 2fdca30363f0 -r e80418f1f58b
> > unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> > --- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
> > +++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.h
>
> ... this is the wrong file. See compat-include/xen/platform-compat.h
> (including how it already deals with non-present __init).
Thanks, I sent v2 of this patch.
Olaf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] unmodified_drivers: __devinit was removed in linux-3.8
2013-02-12 10:09 ` [PATCH v2] " Olaf Hering
@ 2013-02-12 10:31 ` Jan Beulich
0 siblings, 0 replies; 5+ messages in thread
From: Jan Beulich @ 2013-02-12 10:31 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
>>> On 12.02.13 at 11:09, Olaf Hering <olaf@aepfle.de> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@aepfle.de>
> # Date 1360663714 -3600
> # Node ID 37bca0abac676afdece18363ba3170027378659c
> # Parent 2fdca30363f08026971c094e8a1a84e19ca3e55b
> unmodified_drivers: __devinit was removed in linux-3.8
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Committed, but it would have been nice if you had followed the
advice I gave and thus saved me from having to edit the patch
before checking in.
Jan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-12 10:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-11 15:28 [PATCH] unmodified_drivers: __devinit was removed in linux-3.8 Olaf Hering
2013-02-12 10:00 ` Jan Beulich
2013-02-12 10:10 ` Olaf Hering
2013-02-12 10:09 ` [PATCH v2] " Olaf Hering
2013-02-12 10:31 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.