From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Ball <cjb@laptop.org>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
Namjae Jeon <linkinjeon@gmail.com>,
Konstantin Dorfman <kdorfman@codeaurora.org>,
Venkatraman S <svenkatr@ti.com>,
linux-mmc@vger.kernel.org, kbuild@01.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: check correct variable after kzalloc()
Date: Tue, 12 Feb 2013 12:35:00 +0000 [thread overview]
Message-ID: <20130212123500.GP4937@mwanda> (raw)
In-Reply-To: <87pq05ogy9.fsf@octavius.laptop.org>
On Tue, Feb 12, 2013 at 07:27:26AM -0500, Chris Ball wrote:
> Hi Dan,
>
> On Tue, Feb 12 2013, Dan Carpenter wrote:
> > There is a typo here so we check "mqrq_cur->packed" instead of
> > "mqrq_prev->packed".
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
> > index c0d1315..97a848b 100644
> > --- a/drivers/mmc/card/queue.c
> > +++ b/drivers/mmc/card/queue.c
> > @@ -378,7 +378,7 @@ int mmc_packed_init(struct mmc_queue *mq, struct mmc_card *card)
> > }
> >
> > mqrq_prev->packed = kzalloc(sizeof(struct mmc_packed), GFP_KERNEL);
> > - if (!mqrq_cur->packed) {
> > + if (!mqrq_prev->packed) {
> > pr_warn("%s: unable to allocate packed cmd for mqrq_prev\n",
> > mmc_card_name(card));
> > kfree(mqrq_cur->packed);
> >
>
> Thanks, this is already fixed via a rebase edit to to the original patch
> in mmc-next. (Fengguang's 0-day bot caught it.)
>
Ah, grand. We try to avoid duplicates but there is a gap in our
system...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Ball <cjb@laptop.org>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
Namjae Jeon <linkinjeon@gmail.com>,
Konstantin Dorfman <kdorfman@codeaurora.org>,
Venkatraman S <svenkatr@ti.com>,
linux-mmc@vger.kernel.org, kbuild@01.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: check correct variable after kzalloc()
Date: Tue, 12 Feb 2013 15:35:00 +0300 [thread overview]
Message-ID: <20130212123500.GP4937@mwanda> (raw)
In-Reply-To: <87pq05ogy9.fsf@octavius.laptop.org>
On Tue, Feb 12, 2013 at 07:27:26AM -0500, Chris Ball wrote:
> Hi Dan,
>
> On Tue, Feb 12 2013, Dan Carpenter wrote:
> > There is a typo here so we check "mqrq_cur->packed" instead of
> > "mqrq_prev->packed".
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
> > index c0d1315..97a848b 100644
> > --- a/drivers/mmc/card/queue.c
> > +++ b/drivers/mmc/card/queue.c
> > @@ -378,7 +378,7 @@ int mmc_packed_init(struct mmc_queue *mq, struct mmc_card *card)
> > }
> >
> > mqrq_prev->packed = kzalloc(sizeof(struct mmc_packed), GFP_KERNEL);
> > - if (!mqrq_cur->packed) {
> > + if (!mqrq_prev->packed) {
> > pr_warn("%s: unable to allocate packed cmd for mqrq_prev\n",
> > mmc_card_name(card));
> > kfree(mqrq_cur->packed);
> >
>
> Thanks, this is already fixed via a rebase edit to to the original patch
> in mmc-next. (Fengguang's 0-day bot caught it.)
>
Ah, grand. We try to avoid duplicates but there is a gap in our
system...
regards,
dan carpenter
next prev parent reply other threads:[~2013-02-12 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 12:24 [patch] mmc: check correct variable after kzalloc() Dan Carpenter
2013-02-12 12:24 ` Dan Carpenter
2013-02-12 12:27 ` Chris Ball
2013-02-12 12:27 ` Chris Ball
2013-02-12 12:35 ` Dan Carpenter [this message]
2013-02-12 12:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212123500.GP4937@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cjb@laptop.org \
--cc=kbuild@01.org \
--cc=kdorfman@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=svenkatr@ti.com \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.