From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: Tony Luck <tony.luck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Xishi Qiu <qiuxishi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
fenghua.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Liujiang <jiang.liu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
Hanjun Guo <guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
WuJianguo <wujianguo-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting
Date: Tue, 12 Feb 2013 16:22:22 -0800 [thread overview]
Message-ID: <20130212162222.e4103ddb.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+8MBb+3_xWv1wMWv0+gwWm9exPCNTZWG3mXQnBsUbc5fJnuiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, 12 Feb 2013 16:11:33 -0800
Tony Luck <tony.luck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Building linux-next today (tag next-20130212) I get the following errors when
> building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig,
> sim_defconfig}
>
> arch/ia64/mm/init.c: In function 'free_initrd_mem':
> arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use in
> this function)
> arch/ia64/mm/init.c:215: error: (Each undeclared identifier is
> reported only once
> arch/ia64/mm/init.c:215: error: for each function it appears in.)
> arch/ia64/mm/init.c:216: error: implicit declaration of function
> 'GRANULEROUNDDOWN'
>
`max_addr' is an awesomely bad name for a global identifier, btw.
And this:
-static u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
+u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
needlessly exported `mem_limit' and `min_addr' as well. These too are
very poor global identifiers.
Also, Matt suggested an alternative implementation which afaik hasn't
been responded to.
I think I'll just drop the patch.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tony Luck <tony.luck@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
Matt Fleming <matt.fleming@intel.com>,
fenghua.yu@intel.com, Liujiang <jiang.liu@huawei.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-mm@kvack.org,
Hanjun Guo <guohanjun@huawei.com>,
WuJianguo <wujianguo@huawei.com>
Subject: Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting
Date: Wed, 13 Feb 2013 00:22:22 +0000 [thread overview]
Message-ID: <20130212162222.e4103ddb.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+8MBb+3_xWv1wMWv0+gwWm9exPCNTZWG3mXQnBsUbc5fJnuiA@mail.gmail.com>
On Tue, 12 Feb 2013 16:11:33 -0800
Tony Luck <tony.luck@gmail.com> wrote:
> Building linux-next today (tag next-20130212) I get the following errors when
> building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig,
> sim_defconfig}
>
> arch/ia64/mm/init.c: In function 'free_initrd_mem':
> arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use in
> this function)
> arch/ia64/mm/init.c:215: error: (Each undeclared identifier is
> reported only once
> arch/ia64/mm/init.c:215: error: for each function it appears in.)
> arch/ia64/mm/init.c:216: error: implicit declaration of function
> 'GRANULEROUNDDOWN'
>
`max_addr' is an awesomely bad name for a global identifier, btw.
And this:
-static u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
+u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
needlessly exported `mem_limit' and `min_addr' as well. These too are
very poor global identifiers.
Also, Matt suggested an alternative implementation which afaik hasn't
been responded to.
I think I'll just drop the patch.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tony Luck <tony.luck@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
Matt Fleming <matt.fleming@intel.com>,
fenghua.yu@intel.com, Liujiang <jiang.liu@huawei.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-mm@kvack.org,
Hanjun Guo <guohanjun@huawei.com>,
WuJianguo <wujianguo@huawei.com>
Subject: Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting
Date: Tue, 12 Feb 2013 16:22:22 -0800 [thread overview]
Message-ID: <20130212162222.e4103ddb.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+8MBb+3_xWv1wMWv0+gwWm9exPCNTZWG3mXQnBsUbc5fJnuiA@mail.gmail.com>
On Tue, 12 Feb 2013 16:11:33 -0800
Tony Luck <tony.luck@gmail.com> wrote:
> Building linux-next today (tag next-20130212) I get the following errors when
> building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig,
> sim_defconfig}
>
> arch/ia64/mm/init.c: In function 'free_initrd_mem':
> arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use in
> this function)
> arch/ia64/mm/init.c:215: error: (Each undeclared identifier is
> reported only once
> arch/ia64/mm/init.c:215: error: for each function it appears in.)
> arch/ia64/mm/init.c:216: error: implicit declaration of function
> 'GRANULEROUNDDOWN'
>
`max_addr' is an awesomely bad name for a global identifier, btw.
And this:
-static u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
+u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
needlessly exported `mem_limit' and `min_addr' as well. These too are
very poor global identifiers.
Also, Matt suggested an alternative implementation which afaik hasn't
been responded to.
I think I'll just drop the patch.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Tony Luck <tony.luck@gmail.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>,
Matt Fleming <matt.fleming@intel.com>,
fenghua.yu@intel.com, Liujiang <jiang.liu@huawei.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-efi@vger.kernel.org, linux-mm@kvack.org,
Hanjun Guo <guohanjun@huawei.com>,
WuJianguo <wujianguo@huawei.com>
Subject: Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting
Date: Tue, 12 Feb 2013 16:22:22 -0800 [thread overview]
Message-ID: <20130212162222.e4103ddb.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+8MBb+3_xWv1wMWv0+gwWm9exPCNTZWG3mXQnBsUbc5fJnuiA@mail.gmail.com>
On Tue, 12 Feb 2013 16:11:33 -0800
Tony Luck <tony.luck@gmail.com> wrote:
> Building linux-next today (tag next-20130212) I get the following errors when
> building arch/ia64/configs/{tiger_defconfig, zx1_defconfig, bigsur_defconfig,
> sim_defconfig}
>
> arch/ia64/mm/init.c: In function 'free_initrd_mem':
> arch/ia64/mm/init.c:215: error: 'max_addr' undeclared (first use in
> this function)
> arch/ia64/mm/init.c:215: error: (Each undeclared identifier is
> reported only once
> arch/ia64/mm/init.c:215: error: for each function it appears in.)
> arch/ia64/mm/init.c:216: error: implicit declaration of function
> 'GRANULEROUNDDOWN'
>
`max_addr' is an awesomely bad name for a global identifier, btw.
And this:
-static u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
+u64 mem_limit = ~0UL, max_addr = ~0UL, min_addr = 0UL;
needlessly exported `mem_limit' and `min_addr' as well. These too are
very poor global identifiers.
Also, Matt suggested an alternative implementation which afaik hasn't
been responded to.
I think I'll just drop the patch.
next prev parent reply other threads:[~2013-02-13 0:22 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 3:52 [PATCH] ia64/mm: fix a bad_page bug when crash kernel booting Xishi Qiu
2013-01-29 3:52 ` Xishi Qiu
2013-01-29 3:52 ` Xishi Qiu
2013-01-29 3:52 ` Xishi Qiu
2013-02-04 16:32 ` Matt Fleming
2013-02-04 16:32 ` Matt Fleming
2013-02-04 16:32 ` Matt Fleming
2013-02-05 3:48 ` Xishi Qiu
2013-02-05 3:48 ` Xishi Qiu
2013-02-05 3:48 ` Xishi Qiu
2013-02-05 3:48 ` Xishi Qiu
[not found] ` <1359995565.7515.178.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-07 2:32 ` [PATCH V2] " Xishi Qiu
2013-02-07 2:32 ` Xishi Qiu
2013-02-07 2:32 ` Xishi Qiu
2013-02-07 2:32 ` Xishi Qiu
[not found] ` <51131248.3080203-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-02-07 6:09 ` [PATCH V3] " Xishi Qiu
2013-02-07 6:09 ` Xishi Qiu
2013-02-07 6:09 ` Xishi Qiu
2013-02-07 6:09 ` Xishi Qiu
[not found] ` <5113450C.1080109-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-02-13 0:11 ` Tony Luck
2013-02-13 0:11 ` Tony Luck
2013-02-13 0:11 ` Tony Luck
2013-02-13 0:11 ` Tony Luck
[not found] ` <CA+8MBb+3_xWv1wMWv0+gwWm9exPCNTZWG3mXQnBsUbc5fJnuiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-13 0:19 ` Andrew Morton
2013-02-13 0:19 ` Andrew Morton
2013-02-13 0:19 ` Andrew Morton
2013-02-13 0:19 ` Andrew Morton
2013-02-13 0:32 ` Tony Luck
2013-02-13 0:32 ` Tony Luck
2013-02-13 0:32 ` Tony Luck
2013-02-13 0:22 ` Andrew Morton [this message]
2013-02-13 0:22 ` Andrew Morton
2013-02-13 0:22 ` Andrew Morton
2013-02-13 0:22 ` Andrew Morton
2013-02-19 21:56 ` Tony Luck
2013-02-19 21:56 ` Tony Luck
2013-02-19 21:56 ` Tony Luck
2013-02-19 21:56 ` Tony Luck
2013-02-20 1:38 ` Xishi Qiu
2013-02-20 1:38 ` Xishi Qiu
2013-02-20 1:38 ` Xishi Qiu
2013-02-21 18:21 ` Tony Luck
2013-02-21 18:21 ` Tony Luck
2013-02-21 18:21 ` Tony Luck
2013-02-13 10:07 ` Matt Fleming
2013-02-13 10:07 ` Matt Fleming
2013-02-13 10:07 ` Matt Fleming
[not found] ` <1360750028.24917.28.camel-ZqTwcBeJ+wsBof6jY8KHXm7IUlhRatedral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-02-16 1:55 ` Xishi Qiu
2013-02-16 1:55 ` Xishi Qiu
2013-02-16 1:55 ` Xishi Qiu
2013-02-16 1:55 ` Xishi Qiu
2013-02-19 21:38 ` Luck, Tony
2013-02-19 21:38 ` Luck, Tony
2013-02-19 21:38 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212162222.e4103ddb.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=fenghua.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=jiang.liu-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=qiuxishi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tony.luck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wujianguo-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.