All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: "Holger Hoffstätte" <holger.hoffstaette@googlemail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
	Tilman Schmidt <tilman@imap.cc>,
	Matthias Schniedermeyer <ms@citd.de>
Subject: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Date: Tue, 12 Feb 2013 12:42:24 -0800	[thread overview]
Message-ID: <20130212204224.GC8427@xanatos> (raw)
In-Reply-To: <511A1AF1.9080107@googlemail.com>

On Tue, Feb 12, 2013 at 11:35:29AM +0100, Holger Hoffstätte wrote:
> On 02/12/13 01:40, Sarah Sharp wrote:
> > Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING,
> > recompile the 3.7.5 kernel, and send me dmesg starting from the point
> > you unmount the device and then power it off?
> 
> I don't even need to mount/unmount; just plugging in/unplugging
> reproduces the problem. Note again that this is independent of both the
> used USB 3.0 card (might be the same chipset though?) and the attached
> device/enclosure.
> 
> So time to make a freshly built 3.8-rc7 go Ding Dong! :)

xHCI doorbells are fun. :)

I think I see the issue.  Your host controller reports the Inactive
state after a USB disconnect.  My host controllers go to the RxDetect
state on a disconnect.

The patches that went into 3.8 and the stable kernels to better handle
the Inactive state were not designed to handle a connected device going
to the Inactive state.  I thought that would be a rare case, but
apparently it's not.

There was a further set of patches queued for 3.9 to deal with connected
devices going to the Inactive state, but they looked like they were too
big for stable:

d3b9d7a USB: Fix connected device switch to Inactive state.
a24a607 USB: Rip out recursive call on warm port reset.
2d4fa94 USB: Prepare for refactoring by adding extra udev checks.
0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs.

Can you retry with Greg's usb-next branch?

git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next

If that fixes your problem, we should either get those additional
patches into 3.8 and the stable trees, or do a revert of the whole
series and just let 3.9 carry the full patchset.

Sarah Sharp

  reply	other threads:[~2013-02-12 20:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28  4:56 Linux 3.7.5 Greg KH
2013-01-28  4:57 ` Greg KH
     [not found] ` <pan.2013.01.28.11.42.16.556318@googlemail.com>
2013-01-28 14:39   ` Greg KH
     [not found]     ` <pan.2013.01.28.20.33.44.918987@googlemail.com>
2013-01-28 20:46       ` [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5) Jonathan Nieder
2013-02-12  0:40         ` Sarah Sharp
2013-02-12  0:54           ` Jonathan Nieder
2013-02-12  8:36             ` Holger Hoffstätte
2013-02-12 10:35           ` Holger Hoffstätte
2013-02-12 20:42             ` Sarah Sharp [this message]
2013-02-13  8:28               ` Holger Hoffstätte
2013-02-13 17:16                 ` Matthias Schniedermeyer
2013-02-13 19:33                   ` Sarah Sharp
2013-02-13 20:04                     ` Matthias Schniedermeyer
2013-02-13 21:08                       ` Sarah Sharp
2013-02-13 21:31                         ` Greg KH
2013-02-13 22:12                           ` Sarah Sharp
2013-03-01 16:48                             ` Greg KH
2013-03-05 22:10                               ` Stable backport request, Was: " Sarah Sharp
2013-03-06  2:11                                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130212204224.GC8427@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=holger.hoffstaette@googlemail.com \
    --cc=jrnieder@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ms@citd.de \
    --cc=stable@vger.kernel.org \
    --cc=tilman@imap.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.