All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org, Steffen Prohaska <prohaska@zib.de>,
	Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 1/3] Documentation/Makefile: fix spaces around assignments
Date: Tue, 12 Feb 2013 13:00:29 -0800	[thread overview]
Message-ID: <20130212210029.GD12240@google.com> (raw)
In-Reply-To: <48645e424b932536e8cd877962a29b9cfa8bdebd.1360700102.git.john@keeping.me.uk>

Hi,

John Keeping wrote:

> [Subject: [PATCH 1/3] Documentation/Makefile: fix spaces around assignments]

It's not so much "fix spaces" as "use consistent spacing", no?

Aside from that nit, looks like a sensible no-op to me, so
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

  reply	other threads:[~2013-02-12 21:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 20:17 [PATCH 0/3] Fix installation paths with "make install-doc" John Keeping
2013-02-12 20:17 ` [PATCH 1/3] Documentation/Makefile: fix spaces around assignments John Keeping
2013-02-12 21:00   ` Jonathan Nieder [this message]
2013-02-12 20:17 ` [PATCH 2/3] Documentation/Makefile: move infodir to be with other '*dir's John Keeping
2013-02-12 21:01   ` Jonathan Nieder
2013-02-12 21:18     ` John Keeping
2013-02-12 20:17 ` [PATCH 3/3] Documentation/Makefile: fix inherited {html,info,man}dir John Keeping
2013-02-12 22:25 ` [PATCH 0/3] Fix installation paths with "make install-doc" Jonathan Nieder
2013-02-12 22:36   ` John Keeping
2013-02-12 22:39     ` Jonathan Nieder
2013-02-12 22:45   ` Junio C Hamano
2013-02-12 22:57     ` Junio C Hamano
2013-02-12 23:06       ` John Keeping
2013-02-12 23:16         ` Junio C Hamano
2013-02-12 23:09       ` [PATCH] Makefile: do not export mandir/htmldir/infodir Junio C Hamano
2013-02-12 23:16         ` Jonathan Nieder
2013-02-12 23:20           ` John Keeping
2013-02-24 19:55         ` [PATCH] Makefile: make mandir, htmldir and infodir absolute John Keeping
2013-02-25 20:35           ` Junio C Hamano
2013-02-12 23:00     ` [PATCH 0/3] Fix installation paths with "make install-doc" John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130212210029.GD12240@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=john@keeping.me.uk \
    --cc=prohaska@zib.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.