From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Steffen Prohaska <prohaska@zib.de>,
Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 0/3] Fix installation paths with "make install-doc"
Date: Tue, 12 Feb 2013 23:06:00 +0000 [thread overview]
Message-ID: <20130212230600.GB22779@river> (raw)
In-Reply-To: <7vip5xdtt6.fsf@alter.siamese.dyndns.org>
On Tue, Feb 12, 2013 at 02:57:25PM -0800, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > I _think_ exporting mandir/html/infodir from the top-level Makefile
> > is wrong to begin with. We should drop the "export mandir" from
> > there.
>
> Ah, it is this thing, isn't it?
>
> commit d8cf908cb6012cd4dc3d1089a849daf646150c2e
> Author: Junio C Hamano <gitster@pobox.com>
> Date: Sat Feb 2 17:58:49 2013 -0800
>
> config.mak.in: remove unused definitions
>
> When 5566771 (autoconf: Use autoconf to write installation
> directories to config.mak.autogen, 2006-07-03) introduced support
> for autoconf generated config.mak file, it added an "export" for a
> few common makefile variables, in addition to definitions of srcdir
> and VPATH.
>
> The "export" logically does not belong there. The make variables
> like mandir, prefix, etc, should be exported to submakes for people
> who use config.mak and people who use config.mak.autogen the same
> way; if we want to get these exported, that should be in the main
> Makefile.
>
> We do use mandir and htmldir in Documentation/Makefile, so let's
> add export for them in the main Makefile instead.
>
> We may eventually want to support VPATH, and srcdir may turn out to
> be useful for that purpose, but right now nobody uses it, so it is
> useless to define them in this file.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looks like it - I tried this for the first time today (with pu) so I
didn't realise it was a recent change, and I didn't think to blame the
export line.
John
next prev parent reply other threads:[~2013-02-12 23:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 20:17 [PATCH 0/3] Fix installation paths with "make install-doc" John Keeping
2013-02-12 20:17 ` [PATCH 1/3] Documentation/Makefile: fix spaces around assignments John Keeping
2013-02-12 21:00 ` Jonathan Nieder
2013-02-12 20:17 ` [PATCH 2/3] Documentation/Makefile: move infodir to be with other '*dir's John Keeping
2013-02-12 21:01 ` Jonathan Nieder
2013-02-12 21:18 ` John Keeping
2013-02-12 20:17 ` [PATCH 3/3] Documentation/Makefile: fix inherited {html,info,man}dir John Keeping
2013-02-12 22:25 ` [PATCH 0/3] Fix installation paths with "make install-doc" Jonathan Nieder
2013-02-12 22:36 ` John Keeping
2013-02-12 22:39 ` Jonathan Nieder
2013-02-12 22:45 ` Junio C Hamano
2013-02-12 22:57 ` Junio C Hamano
2013-02-12 23:06 ` John Keeping [this message]
2013-02-12 23:16 ` Junio C Hamano
2013-02-12 23:09 ` [PATCH] Makefile: do not export mandir/htmldir/infodir Junio C Hamano
2013-02-12 23:16 ` Jonathan Nieder
2013-02-12 23:20 ` John Keeping
2013-02-24 19:55 ` [PATCH] Makefile: make mandir, htmldir and infodir absolute John Keeping
2013-02-25 20:35 ` Junio C Hamano
2013-02-12 23:00 ` [PATCH 0/3] Fix installation paths with "make install-doc" John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212230600.GB22779@river \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.