From: Olof Johansson <olof@lixom.net>
To: Rob Herring <robherring2@gmail.com>
Cc: Doug Anderson <dianders@chromium.org>,
arm@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <rob.herring@calxeda.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: exynos: move exynos4210-combiner to drivers/irqchip
Date: Tue, 12 Feb 2013 14:52:27 -0800 [thread overview]
Message-ID: <20130212225227.GA24096@quad.lixom.net> (raw)
In-Reply-To: <1360706692-13622-1-git-send-email-robherring2@gmail.com>
On Tue, Feb 12, 2013 at 04:04:52PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Exynos boot is broken with commit 0529e315 (ARM: use common irqchip_init
> for GIC init). This commit split the irqchip initialization into 2 calls
> to of_irq_init. This does not work because of_irq_init requires interrupt
> parents to be in the match list.
>
> Rather than reverting exynos changes, make it do the proper thing by using
> IRQCHIP_DECLARE. This requires moving the combiner code to drivers/irqchip.
>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-samsung-soc@vger.kernel.org
> ---
>
> I thought there may be other platforms broken in the same way, but I
> checked and exynos is the only one.
>
> This is based on my gic/vic irqchip branch in arm-soc.
Applied to next/cleanup.
I guess this answers whether anyone boots linux-next regularly on Exynos
hardware. :(
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: exynos: move exynos4210-combiner to drivers/irqchip
Date: Tue, 12 Feb 2013 14:52:27 -0800 [thread overview]
Message-ID: <20130212225227.GA24096@quad.lixom.net> (raw)
In-Reply-To: <1360706692-13622-1-git-send-email-robherring2@gmail.com>
On Tue, Feb 12, 2013 at 04:04:52PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Exynos boot is broken with commit 0529e315 (ARM: use common irqchip_init
> for GIC init). This commit split the irqchip initialization into 2 calls
> to of_irq_init. This does not work because of_irq_init requires interrupt
> parents to be in the match list.
>
> Rather than reverting exynos changes, make it do the proper thing by using
> IRQCHIP_DECLARE. This requires moving the combiner code to drivers/irqchip.
>
> Reported-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: linux-samsung-soc at vger.kernel.org
> ---
>
> I thought there may be other platforms broken in the same way, but I
> checked and exynos is the only one.
>
> This is based on my gic/vic irqchip branch in arm-soc.
Applied to next/cleanup.
I guess this answers whether anyone boots linux-next regularly on Exynos
hardware. :(
-Olof
next prev parent reply other threads:[~2013-02-12 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 22:04 [PATCH] ARM: exynos: move exynos4210-combiner to drivers/irqchip Rob Herring
2013-02-12 22:04 ` Rob Herring
2013-02-12 22:52 ` Olof Johansson [this message]
2013-02-12 22:52 ` Olof Johansson
2013-02-13 18:51 ` Doug Anderson
2013-02-13 18:51 ` Doug Anderson
2013-02-14 14:25 ` Rob Herring
2013-02-14 14:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212225227.GA24096@quad.lixom.net \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=dianders@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.