Re: [PATCH 2/6] drm/i915: Don't wait for page flips if there was GPU reset

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Feb 13, 2013 at 10:23:28AM +0000, Damien Lespiau wrote:
> On Tue, Jan 29, 2013 at 06:13:34PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > If a GPU reset occurs while a page flip has been submitted to the ring,
> > the flip will never complete once the ring has been reset.
> > 
> > The GPU reset can be detected by sampling the reset_counter before the
> > flip is submitted, and then while waiting for the flip, the sampled
> > counter is compared with the current reset_counter value.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> You might want to rename reset_counter to flip_reset_counter to indicate
> this field is specific to the flipping code. Other parts of the code
> might need something similar as well?

IIRC I used flip_reset_counter initially but then I decided it's too
long and dropped the flip_ part. I can change it back if that's what
people prefer.

-- 
Ville Syrjälä
Intel OTC