From: Tony Lindgren <tony@atomide.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
balbi@ti.com, santosh.shilimkar@ti.com, b-cousson@ti.com,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm: dts: omap4-panda: Add I2c pinctrl data
Date: Wed, 13 Feb 2013 08:40:05 -0800 [thread overview]
Message-ID: <20130213164004.GE7144@atomide.com> (raw)
In-Reply-To: <511BBA1B.9050501@ti.com>
* Jon Hunter <jon-hunter@ti.com> [130213 08:10]:
> On 02/13/2013 09:57 AM, Jon Hunter wrote:
> > On 02/13/2013 03:28 AM, Sourav Poddar wrote:
> >
> > A quick look at the data manual shows that omap4430 and omap4460 has the
> > same pin mux options for i2c. Furthermore, the data manual shows only
> > one mux option for i2c1-4. Therefore, should these mux options be placed
> > in omap4.dtsi? Boards not using specific i2c controllers can disabled
> > them in there board dts file (same way we do for mmc).
>
> I guess for i2c, a given omap4 board may use external pull-ups and not
> use the internal ones and so putting this in the omap4.dtsi may not be
> desirable. However, it seems that a common omap4-panda.dtsi could be
> used here.
Yes the mux options need to be board specific. If something is complex
and common, it's best to put it into omap4-i2c1.dts file that can be
included from the board specific .dts files as needed.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm: dts: omap4-panda: Add I2c pinctrl data
Date: Wed, 13 Feb 2013 08:40:05 -0800 [thread overview]
Message-ID: <20130213164004.GE7144@atomide.com> (raw)
In-Reply-To: <511BBA1B.9050501@ti.com>
* Jon Hunter <jon-hunter@ti.com> [130213 08:10]:
> On 02/13/2013 09:57 AM, Jon Hunter wrote:
> > On 02/13/2013 03:28 AM, Sourav Poddar wrote:
> >
> > A quick look at the data manual shows that omap4430 and omap4460 has the
> > same pin mux options for i2c. Furthermore, the data manual shows only
> > one mux option for i2c1-4. Therefore, should these mux options be placed
> > in omap4.dtsi? Boards not using specific i2c controllers can disabled
> > them in there board dts file (same way we do for mmc).
>
> I guess for i2c, a given omap4 board may use external pull-ups and not
> use the internal ones and so putting this in the omap4.dtsi may not be
> desirable. However, it seems that a common omap4-panda.dtsi could be
> used here.
Yes the mux options need to be board specific. If something is complex
and common, it's best to put it into omap4-i2c1.dts file that can be
included from the board specific .dts files as needed.
Regards,
Tony
next prev parent reply other threads:[~2013-02-13 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 9:28 [PATCH 3/5] arm: dts: omap4-panda: Add I2c pinctrl data Sourav Poddar
2013-02-13 9:28 ` Sourav Poddar
2013-02-13 9:28 ` Sourav Poddar
2013-02-13 15:57 ` Jon Hunter
2013-02-13 15:57 ` Jon Hunter
2013-02-13 15:57 ` Jon Hunter
2013-02-13 16:06 ` Jon Hunter
2013-02-13 16:06 ` Jon Hunter
2013-02-13 16:06 ` Jon Hunter
2013-02-13 16:40 ` Tony Lindgren [this message]
2013-02-13 16:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213164004.GE7144@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.