All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin LaHaise <bcrl@kvack.org>
To: Zach Brown <zab@redhat.com>
Cc: Kent Overstreet <koverstreet@google.com>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][WIP v1] aio: experimental use of threads, demonstration of cancel method
Date: Thu, 14 Feb 2013 16:03:09 -0500	[thread overview]
Message-ID: <20130214210309.GD25505@kvack.org> (raw)
In-Reply-To: <20130214205328.GB25505@kvack.org>

On Thu, Feb 14, 2013 at 03:53:28PM -0500, Benjamin LaHaise wrote:
> If the kiocb has been cancelled, this code ensures that the helper thread 
> has received the SIGSEGV.  This ensures that the signal can then be flushed 
> by flush_signals().  If the kiocb has not been cancelled, it can no longer 
> be cancelled after the cmpxchg() has executed.

Whoops, SIGSEGV will certainly need special handling.  The cancel code 
should really be using SIGKILL.  I will add that to the list of things 
to fix.

		-ben
-- 
"Thought is the essence of where you are now."

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin LaHaise <bcrl@kvack.org>
To: Zach Brown <zab@redhat.com>
Cc: Kent Overstreet <koverstreet@google.com>,
	linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][WIP v1] aio: experimental use of threads, demonstration of cancel method
Date: Thu, 14 Feb 2013 16:03:09 -0500	[thread overview]
Message-ID: <20130214210309.GD25505@kvack.org> (raw)
In-Reply-To: <20130214205328.GB25505@kvack.org>

On Thu, Feb 14, 2013 at 03:53:28PM -0500, Benjamin LaHaise wrote:
> If the kiocb has been cancelled, this code ensures that the helper thread 
> has received the SIGSEGV.  This ensures that the signal can then be flushed 
> by flush_signals().  If the kiocb has not been cancelled, it can no longer 
> be cancelled after the cmpxchg() has executed.

Whoops, SIGSEGV will certainly need special handling.  The cancel code 
should really be using SIGKILL.  I will add that to the list of things 
to fix.

		-ben
-- 
"Thought is the essence of where you are now."

  reply	other threads:[~2013-02-14 21:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 22:16 [PATCH][WIP v1] aio: experimental use of threads, demonstration of cancel method Benjamin LaHaise
2013-02-13 22:16 ` Benjamin LaHaise
2013-02-14 19:33 ` Zach Brown
2013-02-14 19:33   ` Zach Brown
2013-02-14 20:53   ` Benjamin LaHaise
2013-02-14 20:53     ` Benjamin LaHaise
2013-02-14 21:03     ` Benjamin LaHaise [this message]
2013-02-14 21:03       ` Benjamin LaHaise
2013-02-14 21:51     ` Zach Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130214210309.GD25505@kvack.org \
    --to=bcrl@kvack.org \
    --cc=koverstreet@google.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.