From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wu Fengguang <fengguang.wu@intel.com>,
Glauber Costa <glommer@parallels.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] ia64: rename cache_show to topology_cache_show
Date: Fri, 15 Feb 2013 14:46:29 -0800 [thread overview]
Message-ID: <20130215144629.be18bae9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1360931904-5720-1-git-send-email-mhocko@suse.cz>
On Fri, 15 Feb 2013 13:38:24 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> Fenguang Wu has reported the following compile time issue
> arch/ia64/kernel/topology.c:278:16: error: conflicting types for 'cache_show'
> include/linux/slab.h:224:5: note: previous declaration of 'cache_show' was here
>
> which has been introduced by 749c5415 (memcg: aggregate memcg cache
> values in slabinfo). Let's rename ia64 local function to prevent from
> the name conflict.
Confused. Tony fixed this ages ago?
: commit 4fafc8c21487f6b5259d462e9bee98661a02390d
: Author: Tony Luck <tony.luck@intel.com>
: Date: Wed Nov 7 15:51:04 2012 -0800
:
: [IA64] Resolve name space collision for cache_show()
:
: We have a local static function named rather generically
: "cache_show()". Changes in progress in the slab code want
: to use this same name globally - so they are adding their
: declaration to <linux/slab.h> which then causes the compiler
: to choke with:
:
: arch/ia64/kernel/topology.c:278: error: conflicting types for 'cache_show'
:
: Fix by adding an "ia64_" prefix to our local function.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wu Fengguang <fengguang.wu@intel.com>,
Glauber Costa <glommer@parallels.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] ia64: rename cache_show to topology_cache_show
Date: Fri, 15 Feb 2013 14:46:29 -0800 [thread overview]
Message-ID: <20130215144629.be18bae9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1360931904-5720-1-git-send-email-mhocko@suse.cz>
On Fri, 15 Feb 2013 13:38:24 +0100
Michal Hocko <mhocko@suse.cz> wrote:
> Fenguang Wu has reported the following compile time issue
> arch/ia64/kernel/topology.c:278:16: error: conflicting types for 'cache_show'
> include/linux/slab.h:224:5: note: previous declaration of 'cache_show' was here
>
> which has been introduced by 749c5415 (memcg: aggregate memcg cache
> values in slabinfo). Let's rename ia64 local function to prevent from
> the name conflict.
Confused. Tony fixed this ages ago?
: commit 4fafc8c21487f6b5259d462e9bee98661a02390d
: Author: Tony Luck <tony.luck@intel.com>
: Date: Wed Nov 7 15:51:04 2012 -0800
:
: [IA64] Resolve name space collision for cache_show()
:
: We have a local static function named rather generically
: "cache_show()". Changes in progress in the slab code want
: to use this same name globally - so they are adding their
: declaration to <linux/slab.h> which then causes the compiler
: to choke with:
:
: arch/ia64/kernel/topology.c:278: error: conflicting types for 'cache_show'
:
: Fix by adding an "ia64_" prefix to our local function.
next prev parent reply other threads:[~2013-02-15 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <511e236a.o0ibbB2U8xMoURgd%fengguang.wu@intel.com>
2013-02-15 12:38 ` [PATCH] ia64: rename cache_show to topology_cache_show Michal Hocko
2013-02-15 12:38 ` Michal Hocko
2013-02-15 13:05 ` Michal Hocko
2013-02-15 13:05 ` Michal Hocko
2013-02-15 22:46 ` Andrew Morton [this message]
2013-02-15 22:46 ` Andrew Morton
2013-02-16 12:18 ` Michal Hocko
2013-02-16 12:18 ` Michal Hocko
2013-02-17 1:36 ` Fengguang Wu
2013-02-17 1:36 ` Fengguang Wu
2013-02-17 9:54 ` Michal Hocko
2013-02-17 9:54 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215144629.be18bae9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=fenghua.yu@intel.com \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.