From: "Jörn Engel" <joern@logfs.org>
To: Patrick O'Grady <patrick@baymotion.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] phram: Allow the user to set the erase page size.
Date: Fri, 15 Feb 2013 14:42:23 -0500 [thread overview]
Message-ID: <20130215194223.GA22790@logfs.org> (raw)
In-Reply-To: <CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com>
On Fri, 15 February 2013 12:35:46 -0800, Patrick O'Grady wrote:
>
> Permit the user to specify the erase page size as a parameter.
> This solves two problems:
>
> - phram can access images made by mkfs.jffs2. mkfs.jffs2 won't
> create images with erase sizes less than 8KiB; many architectures
> define PAGE_SIZE as 4KiB.
>
> - Allows more effective use of small capacity devices. JFFS2
> needs somewhere between 2 and 5 empty pages for garbage collection;
> and for an NVRAM part with only 32KiB of space, a smaller erase page
> allows much better utilization in applications where garbage collection
> is important.
>
> Signed-off-by: Patrick O'Grady <patrick@baymotion.com>
I can't see any argument against this.
Reviewed-by: Joern Engel <joern@logfs.org>
Jörn
--
"[One] doesn't need to know [...] how to cause a headache in order
to take an aspirin."
-- Scott Culp, Manager of the Microsoft Security Response Center, 2001
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: "Patrick O'Grady" <patrick@baymotion.com>
Cc: Joern Engel <joern@lazybastard.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phram: Allow the user to set the erase page size.
Date: Fri, 15 Feb 2013 14:42:23 -0500 [thread overview]
Message-ID: <20130215194223.GA22790@logfs.org> (raw)
In-Reply-To: <CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com>
On Fri, 15 February 2013 12:35:46 -0800, Patrick O'Grady wrote:
>
> Permit the user to specify the erase page size as a parameter.
> This solves two problems:
>
> - phram can access images made by mkfs.jffs2. mkfs.jffs2 won't
> create images with erase sizes less than 8KiB; many architectures
> define PAGE_SIZE as 4KiB.
>
> - Allows more effective use of small capacity devices. JFFS2
> needs somewhere between 2 and 5 empty pages for garbage collection;
> and for an NVRAM part with only 32KiB of space, a smaller erase page
> allows much better utilization in applications where garbage collection
> is important.
>
> Signed-off-by: Patrick O'Grady <patrick@baymotion.com>
I can't see any argument against this.
Reviewed-by: Joern Engel <joern@logfs.org>
Jörn
--
"[One] doesn't need to know [...] how to cause a headache in order
to take an aspirin."
-- Scott Culp, Manager of the Microsoft Security Response Center, 2001
next prev parent reply other threads:[~2013-02-15 21:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 20:35 [PATCH] phram: Allow the user to set the erase page size Patrick O'Grady
2013-02-15 19:42 ` Jörn Engel [this message]
2013-02-15 19:42 ` Jörn Engel
2013-03-02 15:16 ` Artem Bityutskiy
2013-03-02 15:16 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2020-11-24 6:10 Guohua Zhong
2020-11-24 6:10 ` Guohua Zhong
2020-11-24 8:51 ` kernel test robot
2020-11-24 8:51 ` kernel test robot
2020-11-24 8:51 ` kernel test robot
2020-11-24 14:27 ` Guohua Zhong
2020-11-24 14:27 ` Guohua Zhong
2020-11-24 14:27 ` Guohua Zhong
2020-11-24 9:12 ` kernel test robot
2020-11-24 9:12 ` kernel test robot
2020-11-24 9:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215194223.GA22790@logfs.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=patrick@baymotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.