Re: [PATCH] tools/xc: print messages from xc_save with xc_report

[Olaf Hering <olaf@aepfle.de>]

On Fri, Feb 15, Olaf Hering wrote:

> +++ b/tools/xcutils/xc_save.c

>      si.xce = xc_evtchn_open(NULL, 0);
>      if (si.xce == NULL)
> -        warnx("failed to open event channel handle");
> +        WPRINTF("failed to open event channel handle");
>      else
>      {
>          port = xs_suspend_evtchn_port(si.domid);
>  
>          if (port < 0)
> -            warnx("failed to get the suspend evtchn port\n");
> +            WPRINTF("failed to get the suspend evtchn port\n");
>          else
>          {
>              si.suspend_evtchn =
>                xc_suspend_evtchn_init(si.xch, si.xce, si.domid, port);
>  
>              if (si.suspend_evtchn < 0)
> -                warnx("suspend event channel initialization failed, "
> +                WPRINTF("suspend event channel initialization failed, "
>                         "using slow path");
>          }

Is this path well tested, or should these three be fatal errors?

Olaf