All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas
Date: Sat, 16 Feb 2013 12:49:08 +0000	[thread overview]
Message-ID: <201302161249.08597.arnd@arndb.de> (raw)
In-Reply-To: <1360142010-10598-4-git-send-email-iamjoonsoo.kim@lge.com>

On Wednesday 06 February 2013, Joonsoo Kim wrote:
> @@ -859,17 +864,12 @@ static void __init pci_reserve_io(void)
>  {
>  	struct vm_struct *vm;
>  	unsigned long addr;
> +	struct static_vm *svm;
>  
> -	/* we're still single threaded hence no lock needed here */
> -	for (vm = vmlist; vm; vm = vm->next) {
> -		if (!(vm->flags & VM_ARM_STATIC_MAPPING))
> -			continue;
> -		addr = (unsigned long)vm->addr;
> -		addr &= ~(SZ_2M - 1);
> -		if (addr == PCI_IO_VIRT_BASE)
> -			return;
> +	svm = find_static_vm_vaddr((void *)PCI_IO_VIRT_BASE);
> +	if (svm)
> +		return;
>  
> -	}

This is causing build warnings in a bunch of configurations now,
see patch below.

	Arnd

8<-----
ARM: mm: remove unused variables in pci_reserve_io

Patch "ARM: 7646/1: mm: use static_vm for managing static mapped areas"
removed code from pci_reserve_io but left variable declarations
in place that are now unused, as gcc correctly warns.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index c6fe15a..c6d45c8 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -901,8 +901,6 @@ static void __init fill_pmd_gaps(void)
 #if defined(CONFIG_PCI) && !defined(CONFIG_NEED_MACH_IO_H)
 static void __init pci_reserve_io(void)
 {
-	struct vm_struct *vm;
-	unsigned long addr;
 	struct static_vm *svm;
 
 	svm = find_static_vm_vaddr((void *)PCI_IO_VIRT_BASE);

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Russell King <linux@arm.linux.org.uk>,
	js1304@gmail.com, Nicolas Pitre <nico@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org,
	Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas
Date: Sat, 16 Feb 2013 12:49:08 +0000	[thread overview]
Message-ID: <201302161249.08597.arnd@arndb.de> (raw)
In-Reply-To: <1360142010-10598-4-git-send-email-iamjoonsoo.kim@lge.com>

On Wednesday 06 February 2013, Joonsoo Kim wrote:
> @@ -859,17 +864,12 @@ static void __init pci_reserve_io(void)
>  {
>  	struct vm_struct *vm;
>  	unsigned long addr;
> +	struct static_vm *svm;
>  
> -	/* we're still single threaded hence no lock needed here */
> -	for (vm = vmlist; vm; vm = vm->next) {
> -		if (!(vm->flags & VM_ARM_STATIC_MAPPING))
> -			continue;
> -		addr = (unsigned long)vm->addr;
> -		addr &= ~(SZ_2M - 1);
> -		if (addr == PCI_IO_VIRT_BASE)
> -			return;
> +	svm = find_static_vm_vaddr((void *)PCI_IO_VIRT_BASE);
> +	if (svm)
> +		return;
>  
> -	}

This is causing build warnings in a bunch of configurations now,
see patch below.

	Arnd

8<-----
ARM: mm: remove unused variables in pci_reserve_io

Patch "ARM: 7646/1: mm: use static_vm for managing static mapped areas"
removed code from pci_reserve_io but left variable declarations
in place that are now unused, as gcc correctly warns.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
index c6fe15a..c6d45c8 100644
--- a/arch/arm/mm/mmu.c
+++ b/arch/arm/mm/mmu.c
@@ -901,8 +901,6 @@ static void __init fill_pmd_gaps(void)
 #if defined(CONFIG_PCI) && !defined(CONFIG_NEED_MACH_IO_H)
 static void __init pci_reserve_io(void)
 {
-	struct vm_struct *vm;
-	unsigned long addr;
 	struct static_vm *svm;
 
 	svm = find_static_vm_vaddr((void *)PCI_IO_VIRT_BASE);

  reply	other threads:[~2013-02-16 12:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06  9:13 [PATCH v6 0/3] introduce static_vm for ARM-specific static mapped area Joonsoo Kim
2013-02-06  9:13 ` Joonsoo Kim
2013-02-06  9:13 ` [PATCH v6 1/3] ARM: vmregion: remove vmregion code entirely Joonsoo Kim
2013-02-06  9:13   ` Joonsoo Kim
2013-02-06  9:13 ` [PATCH v6 2/3] ARM: ioremap: introduce an infrastructure for static mapped area Joonsoo Kim
2013-02-06  9:13   ` Joonsoo Kim
2013-02-06  9:13 ` [PATCH v6 3/3] ARM: mm: use static_vm for managing static mapped areas Joonsoo Kim
2013-02-06  9:13   ` Joonsoo Kim
2013-02-16 12:49   ` Arnd Bergmann [this message]
2013-02-16 12:49     ` Arnd Bergmann
2013-02-16 12:52     ` Russell King - ARM Linux
2013-02-16 12:52       ` Russell King - ARM Linux
2013-02-16 13:17       ` Arnd Bergmann
2013-02-16 13:17         ` Arnd Bergmann
2013-02-16 13:52       ` Nicolas Pitre
2013-02-16 13:52         ` Nicolas Pitre
2013-02-16 13:51     ` Nicolas Pitre
2013-02-16 13:51       ` Nicolas Pitre
2013-02-07  4:09 ` [PATCH v6 0/3] introduce static_vm for ARM-specific static mapped area Nicolas Pitre
2013-02-07  4:09   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302161249.08597.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.