From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox
Date: Mon, 18 Feb 2013 17:49:37 -0500 [thread overview]
Message-ID: <20130218224937.GC3722@bill-the-cat> (raw)
In-Reply-To: <1356548233-5570-1-git-send-email-sjg@chromium.org>
On Wed, Dec 26, 2012 at 10:56:53AM -0800, Simon Glass wrote:
> This series aims to get all the memory functions running correctly
> on sandbox.
>
> There was some discussion about this a while ago, and a commit was
> added to show a possible approach:
>
> 355a8357 sandbox: Change md command to use map_physmem
>
> This commit was subsequently reverted because it used map_physmem()
> instead of the NOP that most architectures need for the memory functions.
>
> This series introduces map_sysmem(), a NOP on all architectures
> except sandbox. It allows us to use a ram buffer to which all U-Boot
> addresses are relative. The memory commands (including hashing) are
> updated to use this so that sandbox can now use those commands.
>
> Half of the mtest code is behind #ifdefs and there is duplication of
> some functions in both versions of the memory test. Several patches
> here clean this up a bit and get it working on sandbox.
>
> The numeric setenv_ulong() function is a useful way of avoiding a
> 'char buf[17]; sprintf(buf, "%ld", ...); setenv("...", buf)' sequence.
> There is also setenv_addr(). What is missing is setenv_hex() which sets
> a ulong in hex format. Add this function and then make use of it in the
> main places: common/ drivers/ and net/.
>
> The recently added and very basic hash instructure can help reduce
> code duplication in some cases. Redo the crc32 command to use this, and
> make it available through the 'hash' command. Also a few bugs were
> found in hashing with verify disabled - the arg count was not checked and
> a variable declaration was missing.
>
> To permit the memory tester to run on sandbox, we need ctrl-C to work.
> To achieve this, add a proper implementation of sandbox's tstc(), with a
> simple FIFO for character input. An os_usleep() is added to ensure that
> U-Boot does not consume infinite CPU when setting at the command prompt.
>
> With all of this it is possible to use the memory commands in sandbox, as
> well as crc32 and the other hashing commands.
So, aside from a few posted comments:
Reviewed-by: Tom Rini <trini@ti.com>
And pending the answer to if you plan to v2 the hash command part (and
since everyone sets CONFIG_CMD_CRC32, we do want to be careful), I'm OK
with applying this bundle.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130218/ebf94f74/attachment.pgp>
prev parent reply other threads:[~2013-02-18 22:49 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 18:56 [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 01/20] Tidy up error checking and fix bug in hash command Simon Glass
2013-02-15 23:48 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 02/20] Update print_buffer() to use const Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 03/20] sandbox: Improve sandbox serial port keyboard interface Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 04/20] sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 05/20] sandbox: Change memory commands to use map_physmem Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 06/20] Split out the memory tests into separate functions Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 07/20] Use common mtest iteration counting Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 08/20] Fix mtest indenting Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 09/20] Bring mtest putc() into common code Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 10/20] Reduce casting in mtest Simon Glass
2013-02-15 23:54 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-14 20:00 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-15 23:54 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-25 10:52 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-27 18:48 ` Barak Wasserstrom
2012-12-26 18:57 ` [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:08 ` Tom Rini
2013-02-24 17:45 ` Simon Glass
2013-02-24 20:53 ` Tom Rini
2013-02-25 3:42 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 13/20] drivers: " Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:37 ` Tom Rini
2012-12-26 18:57 ` [U-Boot] [PATCH 14/20] net: " Simon Glass
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 15/20] image: Use crc header file instead of C prototypes Simon Glass
2012-12-26 22:02 ` Marek Vasut
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure Simon Glass
2013-02-15 23:57 ` Simon Glass
2013-02-17 20:53 ` Wolfgang Denk
2013-02-17 21:34 ` Simon Glass
2013-02-17 23:26 ` Tom Rini
2013-02-18 11:35 ` Wolfgang Denk
2013-02-18 16:36 ` Simon Glass
2013-02-18 17:05 ` Tom Rini
2013-02-18 17:06 ` Simon Glass
2013-02-18 22:45 ` Tom Rini
2013-02-19 5:24 ` Simon Glass
2013-02-20 17:04 ` Simon Glass
2013-02-18 23:14 ` Wolfgang Denk
2012-12-26 18:57 ` [U-Boot] [PATCH 17/20] sandbox: config: Enable hash functions and mtest Simon Glass
2013-02-15 23:57 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 18/20] Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 19/20] sandbox: Update mtest to fix crashes Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 20/20] sandbox: Allow hash functions to work correctly Simon Glass
2013-02-15 23:58 ` Simon Glass
2013-02-18 22:49 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218224937.GC3722@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.