From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure
Date: Tue, 19 Feb 2013 00:14:06 +0100 [thread overview]
Message-ID: <20130218231406.5373C200538@gemini.denx.de> (raw)
In-Reply-To: <CAPnjgZ09okKf0qTnifKOrvg37nEnSNLFzyLBLp+4jt6U_L3RCg@mail.gmail.com>
Dear Simon,
In message <CAPnjgZ09okKf0qTnifKOrvg37nEnSNLFzyLBLp+4jt6U_L3RCg@mail.gmail.com> you wrote:
>
> > -> bloat-o-meter u-boot-before u-boot
>
> What board is this please?
That was TQM5200S
> This is the generic hashing command. What is happening here is that
> the crc32 command is getting a few more features, more like sha1sum.
> However, this might not be desriable - and in fact this patch changes
> the behaviour of the CRC storage and verify to support using an
> environment variable, and requiring * before the argument when an
> address is required! That needs to be fixed, at least.
Indeed - such a change of user interface must not be done here (though
it does make a lot of sense to use common code for this stuff).
> The intent is to try to unify the hashing/crc features into a single
Understood and appreciayed.
> framework. If you enable only crc32 and nothing else then this has
> quite a cost (0.5KB at present). I think I can reduce this code by
> making the full features of hash.c only available when something more
> than just crc32 is enabled. However, it might involve some #ifdefs...
Actually 0.5 k is quite heavy impact, so I guess the #ifdef's win...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
But the only way of discovering the limits of the possible is to
venture a little way past them into the impossible.
- _Profiles of the Future_ (1962; rev. 1973)
``Hazards of Prophecy: The Failure of Imagination''
next prev parent reply other threads:[~2013-02-18 23:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 18:56 [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 01/20] Tidy up error checking and fix bug in hash command Simon Glass
2013-02-15 23:48 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 02/20] Update print_buffer() to use const Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 03/20] sandbox: Improve sandbox serial port keyboard interface Simon Glass
2013-02-15 23:49 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 04/20] sandbox: Add un/map_sysmen() to deal with sandbox's ram_buf Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 05/20] sandbox: Change memory commands to use map_physmem Simon Glass
2013-02-15 23:51 ` Simon Glass
2012-12-26 18:56 ` [U-Boot] [PATCH 06/20] Split out the memory tests into separate functions Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 07/20] Use common mtest iteration counting Simon Glass
2013-02-15 23:52 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 08/20] Fix mtest indenting Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 09/20] Bring mtest putc() into common code Simon Glass
2013-02-15 23:53 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 10/20] Reduce casting in mtest Simon Glass
2013-02-15 23:54 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-14 20:00 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-15 23:54 ` [U-Boot] [PATCH 11/20] Update set_working_fdt_addr() to use setenv_addr() Simon Glass
2013-02-25 10:52 ` [U-Boot] [PATCH] common/main: move set_working_fdt_addr to enable usage of $fdtaddr Barak Wasserstrom
2013-02-27 18:48 ` Barak Wasserstrom
2012-12-26 18:57 ` [U-Boot] [PATCH 12/20] common: Use new numeric setenv functions Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:08 ` Tom Rini
2013-02-24 17:45 ` Simon Glass
2013-02-24 20:53 ` Tom Rini
2013-02-25 3:42 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 13/20] drivers: " Simon Glass
2013-02-15 23:55 ` Simon Glass
2013-02-18 22:37 ` Tom Rini
2012-12-26 18:57 ` [U-Boot] [PATCH 14/20] net: " Simon Glass
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 15/20] image: Use crc header file instead of C prototypes Simon Glass
2012-12-26 22:02 ` Marek Vasut
2013-02-15 23:56 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 16/20] Roll crc32 into hash infrastructure Simon Glass
2013-02-15 23:57 ` Simon Glass
2013-02-17 20:53 ` Wolfgang Denk
2013-02-17 21:34 ` Simon Glass
2013-02-17 23:26 ` Tom Rini
2013-02-18 11:35 ` Wolfgang Denk
2013-02-18 16:36 ` Simon Glass
2013-02-18 17:05 ` Tom Rini
2013-02-18 17:06 ` Simon Glass
2013-02-18 22:45 ` Tom Rini
2013-02-19 5:24 ` Simon Glass
2013-02-20 17:04 ` Simon Glass
2013-02-18 23:14 ` Wolfgang Denk [this message]
2012-12-26 18:57 ` [U-Boot] [PATCH 17/20] sandbox: config: Enable hash functions and mtest Simon Glass
2013-02-15 23:57 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 18/20] Move CONFIG_SYS_MEMTEST_SCRATCH #ifdef to top of file Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 19/20] sandbox: Update mtest to fix crashes Simon Glass
2013-02-15 23:58 ` Simon Glass
2012-12-26 18:57 ` [U-Boot] [PATCH 20/20] sandbox: Allow hash functions to work correctly Simon Glass
2013-02-15 23:58 ` Simon Glass
2013-02-18 22:49 ` [U-Boot] [PATCH 0/20] Improvements to memory, hashing functions for sandbox Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218231406.5373C200538@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.