From: gorcunov@openvz.org (Cyrill Gorcunov)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP
Date: Wed, 20 Feb 2013 01:54:32 +0400 [thread overview]
Message-ID: <20130219215432.GP20312@moon> (raw)
In-Reply-To: <20130219134256.f4cedf44.akpm@linux-foundation.org>
On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote:
> > Index: linux-2.6.git/kernel/Makefile
> > ===================================================================
> > --- linux-2.6.git.orig/kernel/Makefile
> > +++ linux-2.6.git/kernel/Makefile
> > @@ -25,9 +25,7 @@ endif
> > obj-y += sched/
> > obj-y += power/
> >
> > -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
> > -obj-$(CONFIG_X86) += kcmp.o
> > -endif
> > +obj-$(CONFIG_KCMP) += kcmp.o
> > obj-$(CONFIG_FREEZER) += freezer.o
> > obj-$(CONFIG_PROFILING) += profile.o
> > obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n.
> Is there any point in doing that?
>
> What would be wrong with just doing
>
> obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o
I think this syscall is usefull even without c/r stuff.
That's why I made it with separate config option.
WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Michal Marek <mmarek@suse.cz>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ebiederm@xmission.com,
xemul@parallels.com, Andrey Vagin <avagin@openvz.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Glauber Costa <glommer@parallels.com>,
Andi Kleen <andi@firstfloor.org>, Tejun Heo <tj@kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP
Date: Wed, 20 Feb 2013 01:54:32 +0400 [thread overview]
Message-ID: <20130219215432.GP20312@moon> (raw)
In-Reply-To: <20130219134256.f4cedf44.akpm@linux-foundation.org>
On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote:
> > Index: linux-2.6.git/kernel/Makefile
> > ===================================================================
> > --- linux-2.6.git.orig/kernel/Makefile
> > +++ linux-2.6.git/kernel/Makefile
> > @@ -25,9 +25,7 @@ endif
> > obj-y += sched/
> > obj-y += power/
> >
> > -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
> > -obj-$(CONFIG_X86) += kcmp.o
> > -endif
> > +obj-$(CONFIG_KCMP) += kcmp.o
> > obj-$(CONFIG_FREEZER) += freezer.o
> > obj-$(CONFIG_PROFILING) += profile.o
> > obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n.
> Is there any point in doing that?
>
> What would be wrong with just doing
>
> obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o
I think this syscall is usefull even without c/r stuff.
That's why I made it with separate config option.
next prev parent reply other threads:[~2013-02-19 21:54 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 6:48 [patch 0/2] make kcmp own config entry Cyrill Gorcunov
2013-02-19 6:48 ` Cyrill Gorcunov
2013-02-19 6:48 ` [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP Cyrill Gorcunov
2013-02-19 6:48 ` Cyrill Gorcunov
2013-02-19 8:47 ` KOSAKI Motohiro
2013-02-19 8:47 ` KOSAKI Motohiro
2013-02-19 9:22 ` Michal Marek
2013-02-19 9:22 ` Michal Marek
2013-02-19 9:31 ` Cyrill Gorcunov
2013-02-19 9:31 ` Cyrill Gorcunov
2013-02-19 17:53 ` H. Peter Anvin
2013-02-19 17:53 ` H. Peter Anvin
2013-02-19 18:28 ` Cyrill Gorcunov
2013-02-19 18:28 ` Cyrill Gorcunov
2013-02-19 21:42 ` Andrew Morton
2013-02-19 21:42 ` Andrew Morton
2013-02-19 21:48 ` H. Peter Anvin
2013-02-19 21:48 ` H. Peter Anvin
2013-02-19 22:02 ` Cyrill Gorcunov
2013-02-19 22:02 ` Cyrill Gorcunov
2013-02-19 21:54 ` Cyrill Gorcunov [this message]
2013-02-19 21:54 ` Cyrill Gorcunov
2013-02-19 22:00 ` Andrew Morton
2013-02-19 22:00 ` Andrew Morton
2013-02-19 22:11 ` Cyrill Gorcunov
2013-02-19 22:11 ` Cyrill Gorcunov
2013-02-19 22:15 ` Cyrill Gorcunov
2013-02-19 22:15 ` Cyrill Gorcunov
2013-02-19 22:32 ` Cyrill Gorcunov
2013-02-19 22:32 ` Cyrill Gorcunov
2013-02-19 23:41 ` H. Peter Anvin
2013-02-19 23:41 ` H. Peter Anvin
2013-02-19 6:48 ` [patch 2/2] arm: Wire up kcmp syscall Cyrill Gorcunov
2013-02-19 6:48 ` Cyrill Gorcunov
2013-02-19 7:07 ` Cyrill Gorcunov
2013-02-19 7:07 ` Cyrill Gorcunov
2013-02-20 7:56 ` Cyrill Gorcunov
2013-02-20 23:17 ` Andrew Morton
2013-02-20 23:17 ` Andrew Morton
2013-02-21 5:43 ` Cyrill Gorcunov
2013-02-21 5:43 ` Cyrill Gorcunov
2013-02-23 22:31 ` Arnd Bergmann
2013-02-23 22:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219215432.GP20312@moon \
--to=gorcunov@openvz.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.