* [PATCH] tools: btmgmt: Fix return value to return request id
@ 2013-02-20 16:26 Timo Mueller
2013-02-20 17:20 ` Vinicius Costa Gomes
2013-02-20 18:16 ` Johan Hedberg
0 siblings, 2 replies; 3+ messages in thread
From: Timo Mueller @ 2013-02-20 16:26 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Timo Mueller
From: Timo Mueller <timo.mueller@bmw-carit.de>
Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
send_cmd which returned the index of the adapter instead of the
request id. As a result no mgmt command could be sent to hci0, as 0
marks an invalid request id.
---
tools/btmgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index 4650876..4c6665e 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -833,7 +833,7 @@ static unsigned int send_cmd(struct mgmt *mgmt, uint16_t op, uint16_t id,
if (send_id == 0)
g_free(data);
- return id;
+ return send_id;
}
static void setting_rsp(uint16_t op, uint16_t id, uint8_t status, uint16_t len,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: btmgmt: Fix return value to return request id
2013-02-20 16:26 [PATCH] tools: btmgmt: Fix return value to return request id Timo Mueller
@ 2013-02-20 17:20 ` Vinicius Costa Gomes
2013-02-20 18:16 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Vinicius Costa Gomes @ 2013-02-20 17:20 UTC (permalink / raw)
To: Timo Mueller; +Cc: linux-bluetooth, Timo Mueller
Hi Timo,
On 17:26 Wed 20 Feb, Timo Mueller wrote:
> From: Timo Mueller <timo.mueller@bmw-carit.de>
>
> Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
> send_cmd which returned the index of the adapter instead of the
> request id. As a result no mgmt command could be sent to hci0, as 0
> marks an invalid request id.
> ---
Ack.
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: btmgmt: Fix return value to return request id
2013-02-20 16:26 [PATCH] tools: btmgmt: Fix return value to return request id Timo Mueller
2013-02-20 17:20 ` Vinicius Costa Gomes
@ 2013-02-20 18:16 ` Johan Hedberg
1 sibling, 0 replies; 3+ messages in thread
From: Johan Hedberg @ 2013-02-20 18:16 UTC (permalink / raw)
To: Timo Mueller; +Cc: linux-bluetooth, Timo Mueller
Hi Timo,
On Wed, Feb 20, 2013, Timo Mueller wrote:
> Commit 947a7477d2a2ab6a61e5a7de44fd5b7cd2ab8d9c introduced the method
> send_cmd which returned the index of the adapter instead of the
> request id. As a result no mgmt command could be sent to hci0, as 0
> marks an invalid request id.
> ---
> tools/btmgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch. The patch has been applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-20 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-20 16:26 [PATCH] tools: btmgmt: Fix return value to return request id Timo Mueller
2013-02-20 17:20 ` Vinicius Costa Gomes
2013-02-20 18:16 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.